[Framework-Team] Re: PLIP #215: Include new KSS versions
On Jan 30, 2008, at 9:33 AM, Balazs Ree wrote: Hi Andi, hi balazs, my mail is not coming up on the freamwork list, which I don't understand anyway here is the cc. i'll cc the list and try to quote all of your mail so people have enough context... Andi wrote: while the delay would have been fine with me as well (for the record), we didn't receive any updates on this from you, and i don't seem to be able to find a review bundle either. therefore i'd assume this will (have to) be deferred until 3.2, right? I am very sorry for the delay that was caused on my part, and let me describe the situation a bit further, telling a bit more about the content of the new kss version we are about to roll out. no problem about the delay really — we're badly lagging with the reviews ourselves and it's open source after all. it'll just mean that it probably cannot make it into 3.1 anymore. however, that's just my impression and i'd very much like to get opinions from the other team members and wichert about this as well. First of all, it contains some important stuff developed and finished already before last August. This includes the usage of base2 which causes a 4-5 times clean speedup of page load according to our benchmarks because of faster css selection. My intention was to get these in to the first 3.0 bugfix release, but I got into minority with my opinion against Godefroid at that time and as a consequence those improvements are parking on kss.core trunk (and Plone trunk) since then. The other part of the improvements we also decided and blueprinted in August with the kss team. It was my task to implement these and I completely finished this task by the first week of January. However it could not be merged to trunk until Godefroid could review it, and in addition Godefroid made a major refactoring of the codebase which was only merged to trunk during January. As a consequence, I had no other choice than to spend almost the whole snowsprint on merging my work on top of Godefroid's changes, practically redoing everything manually. Hence the delay. as i said, no problem here. i think we all know what it's like... thanks for elaborating, btw. :) The reasons why I still suggest Plone 3.1 to ship with the new kss version are the following: - Big part of the code we ship is not last minute but quite old (in fact, at the moment we even retargeted so many features to the _next_ kss version that we will be able to prerelease it during March, which means we hopefully won't get into the same situation again.) i don't think it matters that much how old and therefore hopefully mature code is in this case. of course it usually does, but the point is that we need a stable bundle in time to be able to review and merge things without affecting the release schedule. i know this sounds pretty funny considering we've only just started to get going with the reviews ourselves, but imho — and please correct me if i'm wrong — your plip will be quite a chunk to review and there's simply not enough time left. - The new code brings some new features, is somewhat faster, but most importantly, it is more clean and much better tested then the previous version. So it is actually more stable then the one currently included. - It has little or no impact to the application part of Plone, other then speedups and fixing some issues. Which means it's pretty easy to swap it around even in the last moment, in case that becomes necessary. still, it needs to be thoroughly reviewed and testet, which takes time and resources we don't seem to have. in my view one of the consequences of this might have to be that we'll have to lower the load a little bit by being strict about the submission deadline. however, i also think this doesn't have to affect your release at all — the new version can still act as a drop-in replacement known to work with 3.1, it just wouldn't come with 3.1 ootb. this way it'd be likely to be really well tested when it comes to 3.2. again, that's just my opinion here — the other team members might think different... :) I will give a preview buildout today together with the changelog. However I understand that this may not give enough time for the Framework Team to review, and that missing the deadline in itself qualifies for a rejection. I also did not want a special procedure for kss, and I really wanted to comply to the deadlines very hard. As mentioned above, the reasons to fail this were mostly organizational. So I would leave it to the best consideration of the Framework Team to decide about the inclusion. In case of any decision made, the new kss version will be released together with Plone 3.1. that's great to know, at least. and like i said (or maybe not yet), those reasons are perfectly understandable. i wanted to start reviewing things by the beginning of last week myself, but couldn't
Re: [Framework-Team] review deadline coming up
On Jan 29, 2008, at 11:11 AM, Wichert Akkerman wrote: I get the impression that the framework team is not going to be able to meet the current deadline. ok, obviously coming up with an overview took me way longer than i thought, since i could again only work on and off today. anyway, here it is: only one plip, namely #195: Support product dependencies, has been reviewed so far, thanks to raphael and tom (see https://dev.plone.org/plone/ticket/7733) . then, no review bundles have been submitted for the following plips: #196 — see https://dev.plone.org/plone/ticket/7734 #210 — see https://dev.plone.org/plone/ticket/7745 #211 — see https://dev.plone.org/plone/ticket/7746 #215 — see https://dev.plone.org/plone/ticket/7749 #216 — see https://dev.plone.org/plone/ticket/7750 #219 — see https://dev.plone.org/plone/ticket/7753 #221 — see https://dev.plone.org/plone/ticket/7755 i've closed these tickets while cc'ing the plip authors in case they'd like to comment (of course choosing to not do so is perfectly fine as well).all other plips still need to be reviewed — the list of pending reviews can be found at http://tinyurl.com/39aqyq in other words, that's 16 reviews to go with only four days left according to the original schedule. i think despite some of the plips being really small i'm gonna have to agree with wichert that this seems pretty unrealistic, especially considering that everybody seems to be quite busy atm. Instead of me setting a deadline lets try to reverse things: once you have made a list and distributed the reviews amongst the framework team members can you give me a reasonably deadline when all reviews can be finished? first of all, +1. as i've said above, i don't think things will be ready until saturday, and imho we cannot compensate for losing review resources (i.e. martijn) either. so, could every team member please respond asap to let us know what the status is and until when they can finished their shares of reviews?! of course, to answer the second part we first need to distribute those 16 review. however, as i don't think anyone would be too happy to go ahead and do this for you, you should initially each grab at least three of them yourselves: * raphael, you've offered to look at martin's plips — is that still valid? i know they're probably a more substantial ones, so i suppose you could leave one or two for someone else * martijn, when will you be able to work on this again? and do you have any preferences about what plips you'd like to review? * tom, i know you were still planning to do the reviews this week, so how much time will you have for this? * danny, could you perhaps go through to see what you think would be okay for you, i.e. not too technical, and grab those? in case there are tickets left unassigned by tomorrow afternoon, say 2pm, i'll try to come up with some suggestions for assigning them, in which case you'll have to take care of finding good reasons to pass those reviews on yourselves... ;) cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] review deadline coming up
On Jan 30, 2008, at 9:14 AM, Raphael Ritz wrote: Andreas Zeidler wrote: * raphael, you've offered to look at martin's plips — is that still valid? Yes; and I've look somewhat more closely at two already but didn't check in any comments yet ah, cool. could you tell me which or assign them to yourself, please? just so we don't start duplicating efforts with the little remaining time we've got left anyway... I've also spend quite some time on the WebDAV PLIP and that turns out to be non-trivial to test (for me at least) as I never seriously used WebDAV myself (except for demo purposes). i thought it would. :( Would be great if someone else could give that one a more thorough analysis. could you elaborate a little bit? can you identify the problems you ran into and perhaps also what the difficulties are when testing? ideally in the ticket, i.e. http://dev.plone.org/plone/ticket/7732 Regarding my schedule: as I'm leaving for the States Friday morning I'm hoping to be able to much of the flight time on this as well as Saturday morning (I'm sure the 9 hour time shift will affect my sleeping schedule ;-) ok, fair enough. but again, could you go ahead and assign the tickets you're planning to work on to yourself asap? we really need to have someone responsible for each ticket, or else i'm afraid they'll just linger... andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] review deadline coming up
On Jan 30, 2008, at 1:44 AM, Andreas Zeidler wrote: so, could every team member please respond asap to let us know what the status is and until when they can finished their shares of reviews?! of course, to answer the second part we first need to distribute those 16 review. however, as i don't think anyone would be too happy to go ahead and do this for you, you should initially each grab at least three of them yourselves: i've just assigned a few to myself: #205, #208, #212, #213, #217, #218. i was thinking about also taking #207 as it's related to #205/ #218 anyway, but i'd rather see how quickly (or slowly) i can manage to review those other 6. and btw, i intend to be done with them by saturday, as i've already moved things around anyway... cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP #215: Include new KSS versions
On Jan 21, 2008, at 4:17 PM, Raphael Ritz wrote: Wichert Akkerman wrote: I sort of agree, but I do want to note that I can not find a reference of PLIP 215 being proposed before. It was submitted by Balazs on December 13 via email to this list (search for new kss version). just for reference: http://lists.plone.org/pipermail/framework-team/2007-December/001471.html andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP #215: Include new KSS versions
On Jan 20, 2008, at 2:04 AM, Balazs Ree wrote: Dear Framework Team, hi balazs, Since we are after the first day of the sprint, I succeeded to build and test the version that contains our all merged code, but still I have to pull back the above mentioned functionality. Which means, I will only be able to submit the review buildout by tomorrow (20th) lunchtime. I hope that this delay will be accepted. while the delay would have been fine with me as well (for the record), we didn't receive any updates on this from you, and i don't seem to be able to find a review bundle either. therefore i'd assume this will (have to) be deferred until 3.2, right? cheers, andi ps: please also see the accompanying ticket at http://dev.plone.org/plone/ticket/7749 -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: PLIP #215: Include new KSS versions
Andi wrote: On Jan 20, 2008, at 2:04 AM, Balazs Ree wrote: Since we are after the first day of the sprint, I succeeded to build and test the version that contains our all merged code, but still I have to pull back the above mentioned functionality. Which means, I will only be able to submit the review buildout by tomorrow (20th) lunchtime. I hope that this delay will be accepted. while the delay would have been fine with me as well (for the record), we didn't receive any updates on this from you, and i don't seem to be able to find a review bundle either. therefore i'd assume this will (have to) be deferred until 3.2, right? I am very sorry for the delay that was caused on my part, and let me describe the situation a bit further, telling a bit more about the content of the new kss version we are about to roll out. First of all, it contains some important stuff developed and finished already before last August. This includes the usage of base2 which causes a 4-5 times clean speedup of page load according to our benchmarks because of faster css selection. My intention was to get these in to the first 3.0 bugfix release, but I got into minority with my opinion against Godefroid at that time and as a consequence those improvements are parking on kss.core trunk (and Plone trunk) since then. The other part of the improvements we also decided and blueprinted in August with the kss team. It was my task to implement these and I completely finished this task by the first week of January. However it could not be merged to trunk until Godefroid could review it, and in addition Godefroid made a major refactoring of the codebase which was only merged to trunk during January. As a consequence, I had no other choice than to spend almost the whole snowsprint on merging my work on top of Godefroid's changes, practically redoing everything manually. Hence the delay. The reasons why I still suggest Plone 3.1 to ship with the new kss version are the following: - Big part of the code we ship is not last minute but quite old (in fact, at the moment we even retargeted so many features to the _next_ kss version that we will be able to prerelease it during March, which means we hopefully won't get into the same situation again.) - The new code brings some new features, is somewhat faster, but most importantly, it is more clean and much better tested then the previous version. So it is actually more stable then the one currently included. - It has little or no impact to the application part of Plone, other then speedups and fixing some issues. Which means it's pretty easy to swap it around even in the last moment, in case that becomes necessary. I will give a preview buildout today together with the changelog. However I understand that this may not give enough time for the Framework Team to review, and that missing the deadline in itself qualifies for a rejection. I also did not want a special procedure for kss, and I really wanted to comply to the deadlines very hard. As mentioned above, the reasons to fail this were mostly organizational. So I would leave it to the best consideration of the Framework Team to decide about the inclusion. In case of any decision made, the new kss version will be released together with Plone 3.1. Best wishes, -- Balazs Ree ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: PLIP #215: Include new KSS versions
Andi wrote: On Jan 20, 2008, at 2:04 AM, Balazs Ree wrote: Since we are after the first day of the sprint, I succeeded to build and test the version that contains our all merged code, but still I have to pull back the above mentioned functionality. Which means, I will only be able to submit the review buildout by tomorrow (20th) lunchtime. I hope that this delay will be accepted. while the delay would have been fine with me as well (for the record), we didn't receive any updates on this from you, and i don't seem to be able to find a review bundle either. therefore i'd assume this will (have to) be deferred until 3.2, right? I am very sorry for the delay that was caused on my part, and let me describe the situation a bit further, telling a bit more about the content of the new kss version we are about to roll out. First of all, it contains some important stuff developed and finished already before last August. This includes the usage of base2 which causes a 4-5 times clean speedup of page load according to our benchmarks because of faster css selection. My intention was to get these in to the first 3.0 bugfix release, but I got into minority with my opinion against Godefroid at that time and as a consequence those improvements are parking on kss.core trunk (and Plone trunk) since then. The other part of the improvements we also decided and blueprinted in August with the kss team. It was my task to implement these and I completely finished this task by the first week of January. However it could not be merged to trunk until Godefroid could review it, and in addition Godefroid made a major refactoring of the codebase which was only merged to trunk during January. As a consequence, I had no other choice than to spend almost the whole snowsprint on merging my work on top of Godefroid's changes, practically redoing everything manually. Hence the delay. The reasons why I still suggest Plone 3.1 to ship with the new kss version are the following: - Big part of the code we ship is not last minute but quite old (in fact, at the moment we even retargeted so many features to the _next_ kss version that we will be able to prerelease it during March, which means we hopefully won't get into the same situation again.) - The new code brings some new features, is somewhat faster, but most importantly, it is more clean and much better tested then the previous version. So it is actually more stable then the one currently included. - It has little or no impact to the application part of Plone, other then speedups and fixing some issues. Which means it's pretty easy to swap it around even in the last moment, in case that becomes necessary. I will give a preview buildout today together with the changelog. However I understand that this may not give enough time for the Framework Team to review, and that missing the deadline in itself qualifies for a rejection. I also did not want a special procedure for kss, and I really wanted to comply to the deadlines very hard. As mentioned above, the reasons to fail this were mostly organizational. So I would leave it to the best consideration of the Framework Team to decide about the inclusion. In case of any decision made, the new kss version will be released together with Plone 3.1. Best wishes, -- Balazs Ree ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] review deadline coming up
Andreas Zeidler wrote: [..] answer the second part we first need to distribute those 16 review. however, as i don't think anyone would be too happy to go ahead and do this for you, you should initially each grab at least three of them yourselves: * raphael, you've offered to look at martin's plips — is that still valid? Yes; and I've look somewhat more closely at two already but didn't check in any comments yet I've also spend quite some time on the WebDAV PLIP and that turns out to be non-trivial to test (for me at least) as I never seriously used WebDAV myself (except for demo purposes). Would be great if someone else could give that one a more thorough analysis. Regarding my schedule: as I'm leaving for the States Friday morning I'm hoping to be able to much of the flight time on this as well as Saturday morning (I'm sure the 9 hour time shift will affect my sleeping schedule ;-) On the other hand I also want to prepare a bit for the sprint so we'll see Stay tuned, Raphael i know they're probably a more substantial ones, so i suppose you could leave one or two for someone else * martijn, when will you be able to work on this again? and do you have any preferences about what plips you'd like to review? * tom, i know you were still planning to do the reviews this week, so how much time will you have for this? * danny, could you perhaps go through to see what you think would be okay for you, i.e. not too technical, and grab those? in case there are tickets left unassigned by tomorrow afternoon, say 2pm, i'll try to come up with some suggestions for assigning them, in which case you'll have to take care of finding good reasons to pass those reviews on yourselves... ;) cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] Re: PLIP #215: Include new KSS versions
Finally... (drum roll):
https://svn.plone.org/svn/plone/review/plip215-new-kss-version
Changed packages:
kss.core, now points to the 1.4 prerelease branch.
kss.demo, Products.Zelenium: these are only needed for testing. Not
needed for production.
Products.CMFPlone: this only changed to contain the base2 javascript
resource in the GS. I have not added a migration profile, so please
create a new portal. (If you run it on an old portal, it will run the
same with the original cssQuery, slower.)
The changes are in kss.core changelog, but I try to summarize the most
important ones:
- Major code refactoring, for better readibility and speedups.
- Lots and lots of ecma unittests and selenium tests that test kss.core
and the core plugin, are added. All are checkable from a single click
from any browser.
- Base2 is used for css selection, instead of the original cssQuery (if
present). Significantly faster page load.
- multiple selectors in the same rule are allowed, ie.:
selector1:click selector2:click { ... } , or even:
selector1:keyup selector2:keydown { ... }
- Value providers can be recursive, ie.
nodeAttr(kssAttr(blah)) is allowed.
- added url() special value provider, the first is alternate syntax for:
action-server: blah;
blah-kssUrl: http://foo.bar/blahblah;;
you can now say in one line:
action-server: blah url(http://foo.bar/blahblah)
This may be handy if you want to call @@ url-s.
- added alias() special value provider, this enables using more client
actions on the same node:
action-client: setAttribute;
setAttribute-key: foo;
setAttribute-value: bar;
action-client: setAttribute alias(other);
other-key: foo2;
other-value: bar2;
- enable node selection in the same line as the action specification, ie.
instead of
action-client: foo;
foo-kssSelector: css(div.klass);
you can also say:
action-client: foo css(div.klass);
- enable full form submits in the same line as the action specification,
ie. instead of
action-server: foo;
foo-kssSubmitForm: currentForm();
you can also say:
action-server: foo currentForm();
- Value providers can be used also in the event binder id, eg.
instead of the static binder id:
x:click(blah) { ... }
a dynamic binder id can also be used:
x:click(kssAttr(blah)) { ... }
This feature is needed for upcoming use cases like drag and drop. We
don't use this in Plone yet.
- Remove previously deprecated form() and
currentForm() value providers from normal
action parameters (remark: they should now
be used with xxx-kssSelector or directly on the action-client line as
described above, and they properly support Zope multiform
fields like :list, :record, :records.)
- Demos and selenium tests are removed from kss.demo and are now placed
together with the plugin in kss.core. This means, all 3rdparty plugins
should now have a zope-only demo page with a selenium test, if the
plugin is loaded the demo appears in the index and the test is run
together with all tests. (Demos can be viewed and tested by kss.demo.)
We also have kss.template that creates a skeleton kss plugin with
all bells and whistles.
- Implement loglevels based on cookies (also backported to 3.0.)
- Other fixes (also backported to 3.0):
- Fix error fallback handling
- Fix multiple selection form fields marshalling on Safari and IE
That's basically all.
Everything in Plone should run the same.
Some explanation on running demos and selenium tests:
Demos serve to test certain features and can be used as a starting point.
They also enable automated testing if these features work.
To use them you must create in the Zope root:
- a KssDemo SimpleContent object with the id demo
- a Zuite object with the id zuite.
The first one is a bit funky, due to a CMF issue. The KssDemo
SimpleContent object can only be created inside a Plone portal. Then you
must cut-and-paste it out to the Zope root.
If this is done, visit the demo object. The demo index page appears.
Visit the demo you like, _OR_ go to Run all Selenium tests. The
testrunner appears, press on the play button, this will run all tests
and you should get GREEN in every line.
This is currently Zope-level tests, but in a similar way, we will soon be
able to test all the AJAX in Plone, kss and non kss alike.
Good luck for testing.
--
Balazs Ree
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
