Re: GET problem tracked down (patch included)
On Sat, 26 Aug 2000 [EMAIL PROTECTED] wrote: Sound fair? Sounds bad. Going to a broken version of the standard just because other programs are broken is a bad idea. It is "\r\n". Changing it to anything else will cause lots of problems in the future. ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
* shren [EMAIL PROTECTED] [000827 03:24]: On Sat, 26 Aug 2000 [EMAIL PROTECTED] wrote: Sound fair? Sounds bad. Going to a broken version of the standard just because other programs are broken is a bad idea. It is "\r\n". Changing it to anything else will cause lots of problems in the future. "Be strict in what you produce, and liberal in what you accept." I would accept either "\r", "\n", or "\r\n" as an end of line. Macs use one, Unixen use another, Windows uses the third. Yeah, I know it's a pain. I wrote an HTTP proxy, and it was a pain when I had to do it. But it's simple code to write, and it works with any client. Later, Blake. -- 12:56pm up 43 days, 12:23, 1 user, load average: 0.08, 0.02, 0.01 ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
I agree with this... "be strict in what you produce, lenient in what you accept" right? elrod shren wrote: On Sat, 26 Aug 2000 [EMAIL PROTECTED] wrote: Sound fair? Sounds bad. Going to a broken version of the standard just because other programs are broken is a bad idea. It is "\r\n". Changing it to anything else will cause lots of problems in the future. ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
Hi all. I have been chasing down a little bug that was keeping me from using freeamp to pull mp3 files off a web server. The odd part was that it worked just fine with winamp but when I connected with freeamp the webserver puked saying the GET line was invalid. At any rate, I was able to get the GET method sent out by freeamp to work with the sever by adding a \r before the \n in the GET line. I think the RFC says that you need both \r and \n, but there are at least some web servers that are really picky about this. This patch was enough to get things working. It would really be better to add a \r to all the header bits that just use \n now, but I will leave that up to you developers. Mo DeJong Red Hat Inc Lol. I believe that the \r's were recently removed from http lines, due to it breaking proxy support in some cases. Rob, do you want to comment beyond bug report 893? Also, looking into the linux crashes with http streams, I have been able to reproduce a seg fault on a stream once, although it tends to be stream specific. None of the streams in the my streams listing cause a crash, so I have been using http://166.90.143.147:13582/ as my test stream for crash reproduction. If anyone has a stream which causes freeamp to crash with a higher frequency than ~ once every 10 sessions, can you pass that on to me? And, FYI, the test.txt file is a debug log for the Relatable recommended streams feature, and has no relationship to the actual streaming process. This could be a result of a frame alignment issue feeding the decoder, but it doesn't exhibit the same sideband/header corruption that happens in bug #905. -Sean Ward Relatable ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
Groan. Yep :(. The real solution will probably be to add a new check box to toggle between using the extra \r or not, as a fix for bad proxies. That is the part I don't get. When freeamp crashes on me, it is before the stream gets downloaded. I have a little network monitor applet that tells me how much data is moving over the network interface, and it shows 0 Kbits. Freeamp just hoses around for a bit and then core dumps. Hmm. Does this happen with every stream, or only particular ones? Also, how are you accessing the stream? Are you selecting one of the streams from the My Streams listing, or are you selecting file and typing in the stream name there? This only seems to happen when I try to stream something from the GUI. If I just pass a URL as the first command line argument, then everything works as you would expect. That is why I think this has nothing to do with the stream. Very possibly. -Sean Ward Relatable ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
On 26 Aug, Mo DeJong wrote: Hi all. I have been chasing down a little bug that was keeping me from using freeamp to pull mp3 files off a web server. The odd part was that it worked just fine with winamp but when I connected with freeamp the webserver puked saying the GET line was invalid. At any rate, I was able to get the GET method sent out by freeamp to work with the sever by adding a \r before the \n in the GET line. I think the RFC says that you need both \r and \n, but there are at least some web servers that are really picky about this. This patch was enough to get things working. It would really be better to add a \r to all the header bits that just use \n now, but I will leave that up to you developers. Groan is right. At first I had everything with just \n. Then someone pointed out that the HTTP spec calls for \r\n. I checked it out and agreed and applied the change. Then people started reporting that it was not working with proxies anymore. Not having had any bad feedback with just the \n (other than not being compliant) I went back to that. Sigh. However, your solution with just the first line having the \r\n is not something I've tried. What made you decide to do just the first line? What I will do when I get back from Burning Man is to build a version with your fix and then send it to the people that were having problems. If they are happy, then I will apply your patch. If they are not happy, I will go with Sean's suggestion and add a checkbox to the options dialog. Sound fair? --ruaok Freezerburn! All else is only icing. -- Soul Coughing Robert Kaye -- [EMAIL PROTECTED] http://moon.eorbit.net/~robert ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
Re: GET problem tracked down (patch included)
On Sat, 26 Aug 2000, Sean Ward wrote: That is the part I don't get. When freeamp crashes on me, it is before the stream gets downloaded. I have a little network monitor applet that tells me how much data is moving over the network interface, and it shows 0 Kbits. Freeamp just hoses around for a bit and then core dumps. Hmm. Does this happen with every stream, or only particular ones? Also, how are you accessing the stream? Are you selecting one of the streams from the My Streams listing, or are you selecting file and typing in the stream name there? Every one. I have yet to be able to play a HTTP stream that I opened in the GUI. If I pass a URL on the command line it works just fine, which is the really strange part. Mo DeJong Red Hat Inc ___ [EMAIL PROTECTED] http://www.freeamp.org/mailman/listinfo/freeamp-dev
