Chris Costello wrote:
On Saturday, September 08, 2001, Maxim Sobolev wrote:
I don't like idea to hardcode the same string (procfs), with the
same meaning in several places across kernel. As for your proposition
to use f_fstypename to set v_tag, it is even more bogus because
value of the
On Tuesday, September 18, 2001, Maxim Sobolev wrote:
Oh, yes, you are correct obviously (don't know what I was thinking about). In this
case, it looks like v_tag is redundant, because f_fstypename could be used instead
in a few places where v_tag is abused (the same applies to the
In message [EMAIL PROTECTED], Maxim Sobolev writes:
How do you figure? The contents if `f_fstypename' must match
a configured file system exactly, so it could _not_ be anything.
To quote sys/kern/vfs_syscalls.c:mount():
Oh, yes, you are correct obviously (don't know what I was thinking
On Tue, Sep 18, 2001 at 03:09:33PM +0300, Maxim Sobolev wrote:
The patch looks ok. There's a slight functional change that an ext2fs
filesystem is now correctly returned as such. I don't expect Linux
binaries to break, but it may be remotely possible that certain tools,
now that they detect
On Sat, 8 Sep 2001, Chris Costello wrote:
On Saturday, September 08, 2001, Poul-Henning Kamp wrote:
No actually not, I want something short and predictable like
VT_CODA.
How about my second suggestion: making v_tag point to
mp-mnt_stat.f_fstypename, or a copy thereof?
Good, but I as
On Saturday, September 08, 2001, Maxim Sobolev wrote:
No, it should be pre-defined, because otherwise we will be
unable to use strcmp() in a few places when v_tag is abused.
So in these cases (which ideally would be eliminated rather
than considered for support), why can't you do:
if
On Saturday, September 08, 2001, Maxim Sobolev wrote:
I don't like idea to hardcode the same string (procfs), with the
same meaning in several places across kernel. As for your proposition
to use f_fstypename to set v_tag, it is even more bogus because
value of the f_fstypename is supplied
On Tuesday, September 04, 2001, Maxim Sobolev wrote:
Content-Description: ASCII C program text
Index: coda/coda.h
===
RCS file: /home/ncvs/src/sys/coda/coda.h,v
retrieving revision 1.9
diff -d -u -r1.9 coda.h
--- coda/coda.h
On Friday, September 07, 2001, Chris Costello wrote:
But is it necessary that you really use those defines? The
idea is not to use them globally. Perhaps getnewvnode() should
get the string from `mp-mnt_stat.f_mntfromname', instead...
^
In message [EMAIL PROTECTED], Chris Costello writes:
On Tuesday, September 04, 2001, Maxim Sobolev wrote:
Content-Description: ASCII C program text
Index: coda/coda.h
===
RCS file: /home/ncvs/src/sys/coda/coda.h,v
retrieving
On Saturday, September 08, 2001, Poul-Henning Kamp wrote:
No actually not, I want something short and predictable like
VT_CODA.
How about my second suggestion: making v_tag point to
mp-mnt_stat.f_fstypename, or a copy thereof?
--
While on the subject of VFS locking...
Accessing devfs through a nullfs redirection causes a panic() due to
locking issues. I haven't had time to look at this in detail yet, if
somebody wants to jump up and fix the problem, feel free...
-Jon
To Unsubscribe: send mail to [EMAIL PROTECTED]
Assignment:
The v_tag element in struct vnode is a debugging aid, but unfortunately
it is implemented in a way which means that adding a filesystem means
modifying the definition in sys/vnode.h.
Convert the v_tag to an const char * and have the filesystems put
their name in there instead.
The
On 04 Sep 2001 at 10:36 (+0200), Poul-Henning Kamp wrote:
|
| Assignment:
|
| The v_tag element in struct vnode is a debugging aid, but unfortunately
| it is implemented in a way which means that adding a filesystem means
| modifying the definition in sys/vnode.h.
|
| Convert the v_tag to an
In message [EMAIL PROTECTED], Brent Verner writes:
On 04 Sep 2001 at 10:36 (+0200), Poul-Henning Kamp wrote:
|
| Assignment:
|
| The v_tag element in struct vnode is a debugging aid, but unfortunately
| it is implemented in a way which means that adding a filesystem means
| modifying the
On Tue, Sep 04, 2001 at 02:27:00PM +0200, Poul-Henning Kamp wrote:
I've done a /cursory/ look over how this v_tag is used. I'm not sure
this is a simple/clean as you propose, since this is used in the
IS_LOCKING_VFS macro, as well as in union_subr.c...
Well, that is just too bad, because
In message [EMAIL PROTECTED], Maxim Sobolev writes:
In message [EMAIL PROTECTED], Brent Verner writes:
I've done a /cursory/ look over how this v_tag is used. I'm not sure
this is a simple/clean as you propose, since this is used in the
IS_LOCKING_VFS macro, as well as in
Hi Maxim,
Perhaps you meant:
diff -d -u -r1.154 vnode.h
--- sys/vnode.h 2001/08/27 06:09:55 1.154
+++ sys/vnode.h 2001/09/04 15:21:25
@@ -175,6 +175,7 @@
/* open for business 0x10 */
#defineVONWORKLST 0x20 /* On syncer work-list */
#defineVMOUNT
apart from the numerical value, yes, looks good.
Poul-Henning
In message [EMAIL PROTECTED], Maxim Sobolev writes:
--%--multipart-mixed-boundary-1.97537.999617732--%
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
In message [EMAIL PROTECTED], Maxim Sobolev writes:
Hi Maxim,
Perhaps you meant:
diff -d -u -r1.154 vnode.h
--- sys/vnode.h 2001/08/27 06:09:55 1.154
+++ sys/vnode.h 2001/09/04 15:21:25
@@ -175,6 +175,7 @@
/* open for business 0x10 */
#defineVONWORKLST 0x20 /* On syncer work-list */
#defineVMOUNT
On Tue, 4 Sep 2001, Maxim Sobolev wrote:
The places which inspect v_tag will have to be changed to use
strcmp() then...
I think that we can add a new vnode flag, say VCANLOCK, so that each
particular VFS can set it if it supports locking, which should allow
to remove pre-defined VFS
In message [EMAIL PROTECTED], Brent Verner writes:
On 04 Sep 2001 at 10:36 (+0200), Poul-Henning Kamp wrote:
|
| Assignment:
|
| The v_tag element in struct vnode is a debugging aid, but unfortunately
| it is implemented in a way which means that adding a filesystem means
| modifying
In message [EMAIL PROTECTED], Maxim Sobolev writes:
In message [EMAIL PROTECTED], Brent Verner writes:
On 04 Sep 2001 at 10:36 (+0200), Poul-Henning Kamp wrote:
|
| Assignment:
|
| The v_tag element in struct vnode is a debugging aid, but unfortunately
| it is implemented in a way
On Tue, 4 Sep 2001, Maxim Sobolev wrote:
[neither Maxim Sobolev nor Brent Verner wrote]
In message [EMAIL PROTECTED], Brent Verner writes:
#include newbie_kernel_hacker_warning.h
I've done a /cursory/ look over how this v_tag is used. I'm not sure
this is a simple/clean as you
apart from the numerical value, yes, looks good.
Ok, please find the final patch attached. Dare I say that it looks really
ugly?
I'm looking forward for your comments.
-Maxim
Poul-Henning
In message [EMAIL PROTECTED], Maxim Sobolev writes:
25 matches
Mail list logo
