Re: 1131 unneeded includes in the kernel...

2000-09-21 Thread Greg Lehey
On Wednesday, 20 September 2000 at 3:10:21 -0400, Brandon D. Valentine wrote: > On Tue, 19 Sep 2000, Matthew Jacob wrote: > >> >> Oh- don't get me wrong. Valuable info. Thanks. > > What would be very cool is to feed this into another script which strips > these unnecesary includes out. Then do a

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Mark Murray
> UNNEEDED #includes in the FreeBSD kernel : : > dev/randomdev/harvest.c > > > > > dev/randomdev/hash.c > > > > dev/randomdev/randomdev.c > > > > dev/randomdev/yarrow.c > >

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Warner Losh
In message <98558.969478759@critter> Poul-Henning Kamp writes: : In message <[EMAIL PROTECTED]>, Warner Losh writes: : >In message <94952.969433843@critter> Poul-Henning Kamp writes: : >: Oh, forgot to say: it could also be indicative of options not : >: excercised by NOTES/LINT... : > : >There ar

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Warner Losh writes: >In message <94952.969433843@critter> Poul-Henning Kamp writes: >: Oh, forgot to say: it could also be indicative of options not >: excercised by NOTES/LINT... > >There are a few NEWCARD/OLDCARD issues that you catch here I'll >fix the rest.

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Warner Losh
In message <94952.969433843@critter> Poul-Henning Kamp writes: : Oh, forgot to say: it could also be indicative of options not : excercised by NOTES/LINT... There are a few NEWCARD/OLDCARD issues that you catch here I'll fix the rest. Thanks! Warner To Unsubscribe: send mail to [EMAIL PR

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Alfred Perlstein
* Poul-Henning Kamp <[EMAIL PROTECTED]> [000919 23:51] wrote: > > UNNEEDED #includes in the FreeBSD kernel > > agp_if.c > > [snip] These reports would be a lot more useful if you included the last person to touch these files along with the first line of the Copyright. -Alfred

RE: 1131 unneeded includes in the kernel...

2000-09-20 Thread John Baldwin
On 20-Sep-00 Poul-Henning Kamp wrote: > > UNNEEDED #includes in the FreeBSD kernel Err, how exactly are you generating these? > i386/i386/db_interface.c > If you compile a kernel with KTR and DDB. *bewm* If you are using LINT for these tests, then it probably means that the KTR

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Matthew Jacob
On Wed, 20 Sep 2000, Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, Matthew J > acob writes: > > > >How did you manage to generate this list. You're smoking > >crack on this one > > > >> dev/isp/isp_target.c > >> > >> > > > >as the isp_OS_PLATFORM.h includes is the only

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Matthew Jacob
On Wed, 20 Sep 2000, Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, Matthew J > acob writes: > > > >How did you manage to generate this list. You're smoking > >crack on this one > > > >> dev/isp/isp_target.c > >> > >> > > > >as the isp_OS_PLATFORM.h includes is the only

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, "Br andon D. Valentine" writes: >On Tue, 19 Sep 2000, Matthew Jacob wrote: > >> >>Oh- don't get me wrong. Valuable info. Thanks. > >What would be very cool is to feed this into another script which strips >these unnecesary includes out. Then do a test build of LINT

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Matthew Jacob
Yes, but no. Let the MAINTAINERS shoot their own lines. A script with nag mail is good though. On Wed, 20 Sep 2000, Brandon D. Valentine wrote: > On Tue, 19 Sep 2000, Matthew Jacob wrote: > > > > >Oh- don't get me wrong. Valuable info. Thanks. > > What would be very cool is to feed this int

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Matthew J acob writes: > >How did you manage to generate this list. You're smoking >crack on this one > >> dev/isp/isp_target.c >> >> > >as the isp_OS_PLATFORM.h includes is the only include this file has. Oh, forgot to say: it could also be indicati

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Kris Kennaway
On Wed, 20 Sep 2000, Brandon D. Valentine wrote: > On Tue, 19 Sep 2000, Matthew Jacob wrote: > > > > >Oh- don't get me wrong. Valuable info. Thanks. > > What would be very cool is to feed this into another script which strips > these unnecesary includes out. Then do a test build of LINT in you

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Matthew J acob writes: > >How did you manage to generate this list. You're smoking >crack on this one > >> dev/isp/isp_target.c >> >> > >as the isp_OS_PLATFORM.h includes is the only include this file has. Well, According to src/tools/tools/kernincl

Re: 1131 unneeded includes in the kernel...

2000-09-20 Thread Brandon D. Valentine
On Tue, 19 Sep 2000, Matthew Jacob wrote: > >Oh- don't get me wrong. Valuable info. Thanks. What would be very cool is to feed this into another script which strips these unnecesary includes out. Then do a test build of LINT in your local tree and if it succeeds commit a mass removal of them.

Re: 1131 unneeded includes in the kernel...

2000-09-19 Thread Matthew Jacob
Oh- don't get me wrong. Valuable info. Thanks. To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message

Re: 1131 unneeded includes in the kernel...

2000-09-19 Thread Matthew Jacob
How did you manage to generate this list. You're smoking crack on this one > dev/isp/isp_target.c > > as the isp_OS_PLATFORM.h includes is the only include this file has. -matt To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of