Re: [libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-28 Thread Michal Privoznik
On 23.10.2014 21:58, Conrad Meyer wrote: Also, flip Bhyve /domain/os/type support from HVM to Xen. Bhyve only supports paravirtualized guests, and 'xen' is closest to that. We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the

Re: [libvirt] [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-28 Thread Michal Privoznik
On 29.10.2014 02:01, Conrad Meyer wrote: I don't think it's safe to pass arbitrary arguments from XML. I find this too critical to ACK the patch, buy maybe further discussion can change my mind. Michal, You're reviewing a 4-revision old version of this patch, see v5 for the most recent set.

[PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Conrad Meyer
Also, flip Bhyve /domain/os/type support from HVM to Xen. Bhyve only supports paravirtualized guests, and 'xen' is closest to that. We still default to bhyveloader(1) if no explicit bootloader configuration is supplied in the domain. If the /domain/bootloader looks like grub-bhyve and the user

Re: [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Peter Grehan
Hi Conrad, Also, flip Bhyve /domain/os/type support from HVM to Xen. Bhyve only supports paravirtualized guests, and 'xen' is closest to that. That's not true: bhyve has enough h/w emulation required to run unmodified guests - there are register-level emulations of the local APIC, I/O

Re: [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Conrad Rad
On Thu, Oct 23, 2014 at 7:16 PM, Conrad Rad cse@gmail.com wrote: I'll need to change the domain parsing code to allow hvm domains to set bootloader options — currently it only allows xen domains to do so. My bad, I read that wrong. It defaults to xen if no OS type is otherwise specified

Re: [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Peter Grehan
Hi Conrad, Unless I'm mistaken, the userspace loaders are still needed to boot VMs for now. That's correct. Will the Bhyve UEFI work be complete before MeetBSD? Most likely not. And is it going into the FreeBSD 10 release branch, or only in 11? It will be MFCable. Until that code

Re: [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Cory Smelosky
On Thu, 23 Oct 2014, Peter Grehan wrote: Will the Bhyve UEFI work be complete before MeetBSD? Most likely not. Will there be a legacy BIOS compat layer to go along with that? I have some legacy stuff I'd love to move to bhyve that'll never work under UEFI. -- Cory Smelosky

Re: [PATCH 1/2] bhyve: Support /domain/bootloader configuration for non-FreeBSD guests.

2014-10-23 Thread Cory Smelosky
On Thu, 23 Oct 2014, Peter Grehan wrote: Hi Cory, Will there be a legacy BIOS compat layer to go along with that? I have some legacy stuff I'd love to move to bhyve that'll never work under UEFI. Yes - the UEFI image will include a CSM module. I will eagerly await this feature and will