[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-09 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 [book - Mar. Avr. 08 21:55:07 2008]: So I would propose that mystrncasequotecmp (and possibly similarly misguided functions if there are any) be removed and the handling of quoted strings be rechecked for consistency according to

Re: [Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-09 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 On 09/04/2008, Madeline Book wrote: As far as I can see the mystrncasequotecmp function is only used by find_player_by_name_prefix. Why would the player names in the internal server/client data structures (i.e. in game.players[])

Re: [Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 On 07/04/2008, Pepeto _ wrote: Try with this patch. Bugs I reported cannot be reproduced when this patch is applied. Still, I don't think patch is correct. At the very least changes you make should not be required (if other parts

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 [EMAIL PROTECTED] - Mar. Avr. 08 19:55:49 2008]: On 07/04/2008, Pepeto _ wrote: Try with this patch. Bugs I reported cannot be reproduced when this patch is applied. Still, I don't think patch is correct. At the very least

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 As far as I can see the mystrncasequotecmp function is only used by find_player_by_name_prefix. Why would the player names in the internal server/client data structures (i.e. in game.players[]) have meaningless (i.e. not significant for

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-07 Thread Pepeto _
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 Try with this patch. I also noticed a long time ago that the client sends lot of wrong commands to the server, confusing player names and connection names, the commands names and adding '' characters that the server doesn't remove when

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-06 Thread Marko Lindqvist
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40196 S2_2 1. Start server 2. Connect client A with username 'cazfi' - There will be users 'cazfi' and 4 * easy AI 3. Connect client B with username 'cazfi2' - Related to #40189, new user is under AI control and shown by name