[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #11, patch #3620 (project freeciv): Could something in this patch explain bug #20541? ___ Reply to this item at: ___ Message sent via/by Gna!

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #10, patch #3620 (project freeciv): In my testing, this patch does look to fix bug #18040, and also gets rid of the gold_upkeep_style-dependent tax collectors of bug #18767 / #17542. ___ Reply to this item at:

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Update of patch #3620 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Update of patch #3620 (project freeciv): Planned Release:2.4.0, 2.5.0 => 2.4.0-beta2, 2.5.0 ___ Follow-up Comment #7: Will be running more autogames with this before committing (even if patch itself is correct, ol

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #6, patch #3620 (project freeciv): > I do not know about the developing process here. Am I supposed > to change the style issues? I was hoping so. More the original authors do to get their patches to acceptable state, less work for us maintainers. > Anyway, I attached a new pat

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #5, patch #3620 (project freeciv): - I believe it is not necessary to initialize production[] (bug #20482). It is either copied from soln->production or solnplus.production (in compute_max_stats_heuristic) - You are right, city production should be restored. There are some othe

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #4, patch #3620 (project freeciv): > - Not new with the patch, but it seems that production[] is > never initialized, but assumed to be zero-filled in the > beginning This raised separately as bug #20482 as it can have quite a nasty effects with high compiler optimization level

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #3, patch #3620 (project freeciv): - So it mpodifies actual city state, for example by calling set_city_production(), instead of just calculating the best solution. I don't see it restoring city to the original state, so city can end in a weird state if caller decides not to appl

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Update of patch #3620 (project freeciv): Status:None => Ready For Test Assigned to:None => cazfi Planned Release: => 2.4.0, 2.5.0

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #2, patch #3620 (project freeciv): Good point, I just had the civ2 ruleset in mind. I have revised the patch and added a new version. The hardcoded twos had to be replaced. Everything is now as in city.c. (file #17079) ___

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

Follow-up Comment #1, patch #3620 (project freeciv): Quick question before I read this more carefully: have you considered different rulesets, i.e., do the hardcoded twos in the code really means always to double value, or should current rules be consulted? ___

[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

URL: Summary: Governor (cma) branch pruning heuristic fix Project: Freeciv Submitted by: stlth Submitted on: Fr 25 Jan 2013 14:16:10 GMT Category: agents Priority: 5 - Normal