[Freeciv-Dev] [bug #15807] assert in player_invention_state() [tech.c::129]
Update of bug #15807 (project freeciv): Status: Need Info = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #6: The old code special-cases the A_UNSET case. The new code unconditionally calls total_bulbs_required, before checking A_UNSET. Very right, I could now reproduce finding advance in a hut without tech goal set. Fix attached. Additionally, use _client_player()_ instead of _client.conn.playing_, and correct the strange spacing issues. (file #8955) ___ Additional Item Attachment: File name: trunk_science_dialog_text.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?15807 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13599] [RFC; patch] pollution on lakes / ocean
Update of bug #13599 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Follow-up Comment #4: Before implementing this, shouldn't we make the tile special a part of the ruleset? ___ Reply to this item at: http://gna.org/bugs/?13599 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension
Update of bug #13803 (project freeciv): Depends on: = bugs #13793 ___ Reply to this item at: http://gna.org/bugs/?13803 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security
Follow-up Comment #1, bug #15725 (project freeciv): Here is a plan: No unsafe functions (should be done) No NULL pointers and no wild pointers (in progress): 1. We check arguments everywhere. Script functions should try to assure success or raise a script error. 2. Debug module hidden to disallow access to stuff that we hide (below) No NULL pointers and no wild pointers (planned): 3. Limit access to the 'tolua' module (tolua.cast etc) 4. Remove access to all the API types' metatables (The table .get contains unprotected C function calls to look up object fields (.id, .name, .owner etc). Remove access to .set (all fields should be read-only, objects will be mutable by adding methods/setters instead) Are these goals too ambitious? In particular, item 1 is much more ambitious than it sounds like. (Depending on the API function of course). ___ Reply to this item at: http://gna.org/bugs/?15725 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension
Update of bug #13803 (project freeciv): Status: Postponed = In Progress Assigned to: mbook = None Planned Release: = 2.3.0 ___ Follow-up Comment #4: - Added a 'TILE' packet field (SINT32) used to send tile indexes, as an alternative to sending COORD x, y. This has already been implemented in patch #1363. ___ Reply to this item at: http://gna.org/bugs/?13803 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13803] [Patch] Start position cleanup and extension
Update of bug #13803 (project freeciv): Priority: 5 - Normal = 3 - Low ___ Reply to this item at: http://gna.org/bugs/?13803 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13812] Two bug trackers?
Update of bug #13812 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?13812 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15725] [Metaticket] Lua script security
Follow-up Comment #2, bug #15725 (project freeciv): To clarify the last comment: We hide '.get', but the tolua runtime will use it to look up object fields. This will be type safe, unlike direct access to the .get table. We remove '.set', so the tolua runtime will not allow writing back object fields (see bug #15696). ___ Reply to this item at: http://gna.org/bugs/?15725 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14095] GTK-gui goes under taskbar
Update of bug #14095 (project freeciv): Status:None = Confirmed ___ Follow-up Comment #2: I have the same problem since I bought a new monitor. There is a client option to arrange widgets for a small display. It is enough for me. Maybe it should be the default, as long have a smaller window is not as critical that having a window bigger than the screen... ___ Reply to this item at: http://gna.org/bugs/?14095 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14236] bases claiming territory
Update of bug #14236 (project freeciv): Severity: 2 - Minor = 1 - Wish Priority: 5 - Normal = 1 - Later ___ Reply to this item at: http://gna.org/bugs/?14236 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15876] API: Lua part of runtime to be shipped in Freeciv data directory
URL: http://gna.org/bugs/?15876 Summary: API: Lua part of runtime to be shipped in Freeciv data directory Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 13:23 Category: general Severity: 1 - Wish Priority: 1 - Later Status: In Progress Assigned to: englabenny Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The Lua API (for ruleset and scenarios) has a structure as follows: * Tolua-generated bindings to C functions * Lua implementation layer of higher-level methods and some functions The lua implementation part will probably only grow. It is much easier if we only export a minimum from C, upon which we can build higher-level functionality (See current Tile:circle_iterate(..)) Tolua is very optimistic: if there is any Lua parse error, or error when our embedded lua files are executed, the errors are silently ignored. Because of this, it might be better in the long run to execute the lua files ourself after loading the tolua-generated bindings. (And then we can properly do error checking and reporting ourselves). That means we ship the .lua files in the data directory, and in turn that users and developers can modify or add to the lua layer without recompiling Freeciv. In fact, the changes would probably take effect with the next started/loaded game. ___ Reply to this item at: http://gna.org/bugs/?15876 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1617] Release script objects for removed units and cities
Follow-up Comment #6, patch #1617 (project freeciv): Yet another version. To be consistent across save/load we have to restore even 'Nonexistent' values. Also removing the script_is_exported_object_valid function. It is mostly for debugging. Patches for trunk and 2.2 (file #8956, file #8957) ___ Additional Item Attachment: File name: 2010041401-Remove-script-objects-for-removed-units-cities.patch Size:9 KB File name: 2010041401-S2_2_Remove-script-objects-for-removed-units-cities.patch Size:7 KB ___ Reply to this item at: http://gna.org/patch/?1617 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'
Update of patch #1611 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?1611 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15860] Fix compiler warning in tolua-5.1
Update of bug #15860 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15860 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15857] Fix buggy find_transport_from_tile
Update of bug #15857 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Follow-up Comment #3: This fixes some things that used find_transport_from_tile. It could never have worked. Now this works: Disbanding a boat when there is another boat, units will flee to the other boat. Did not work before. ___ Reply to this item at: http://gna.org/bugs/?15857 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1611] Scripting: Hide Lua module 'debug'
Follow-up Comment #2, patch #1611 (project freeciv): Committed to SVN revs r17341 (trunk) and r17342 (S2_2) ___ Reply to this item at: http://gna.org/patch/?1611 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15878] freeciv-server.desktop freeciv.desktop
URL: http://gna.org/bugs/?15878 Summary: freeciv-server.desktop freeciv.desktop Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 16:07 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.1.12, 2.2.1, 2.3 ___ Details: I wanted to fix the Swedish comments in the .desktop files (one word cut off). It seems freeciv-server.desktop still points at 'civserver' in 2.2 and trunk, so the patch(es) fix that as well. Patch for 2.2 and trunk, then patch for 2.1 attached. ___ File Attachments: --- Date: onsdag 2010-04-14 den 16:07 Name: 2010041401-freeciv-server.desktop-freeciv.desktop.patch Size: 2 kB By: englabenny http://gna.org/bugs/download.php?file_id=8958 --- Date: onsdag 2010-04-14 den 16:07 Name: 2010041401-S2_1-sv-freeciv.desktop-freeciv-server.desktop.patch Size: 2 kB By: englabenny http://gna.org/bugs/download.php?file_id=8959 ___ Reply to this item at: http://gna.org/bugs/?15878 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15586] Scripting: Can not save Player value into savegame (Failed to dump variables)
Update of bug #15586 (project freeciv): Status: Fixed = In Progress Open/Closed: Closed = Open ___ Follow-up Comment #5: A month wiser, I would like to solve this like this instead (patch for trunk and 2.2 attached). Basically we use a field .id that calls the number method when accessed. Using properties we can keep the old API even if fields are totally removed from the exported struct (which was what happened with struct player to cause this bug). I would like to backport this to 2.2.1, player:number() is not in any released version yet so we have chance to get rid of it still. Since I'm taking the whole special methods block of code from trunk, the change to make equalities work for all api types kind of rides in on this change. That could be avoided of course, but I don't see any point in that.. (file #8961, file #8962) ___ Additional Item Attachment: File name: 2010041401-API-Restore-Player.id-field-using-properties.patch Size:5 KB File name: 2010041401-S2_2-API-Restore-Player.id-field-using-properties.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?15586 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1601] [Metaticket] Scripting/API extension towards iteration and querying for newcomers
Update of patch #1601 (project freeciv): Summary: [Metaticket] Scripting/API extension towards iteration and querying = [Metaticket] Scripting/API extension towards iteration and querying for newcomers ___ Reply to this item at: http://gna.org/patch/?1601 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1626] API: Player:knows_tech(..) and Unit_Type:can_exists_at_tile(..)
URL: http://gna.org/patch/?1626 Summary: API: Player:knows_tech(..) and Unit_Type:can_exists_at_tile(..) Project: Freeciv Submitted by: englabenny Submitted on: onsdag 2010-04-14 den 21:00 Category: None Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: englabenny Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: Two simple query methods for the Lua API. ___ File Attachments: --- Date: onsdag 2010-04-14 den 21:00 Name: 2010041401-API-Player-knows_tech-.-and-Unit_Type-can_exis.patch Size: 4 kB By: englabenny http://gna.org/patch/download.php?file_id=8966 ___ Reply to this item at: http://gna.org/patch/?1626 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1601] [Metaticket] Scripting/API extension towards iteration and querying for newcomers
Update of patch #1601 (project freeciv): Depends on: = patch #1626 ___ Reply to this item at: http://gna.org/patch/?1601 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #1, patch #1616 (project freeciv): add the possibility to select a nation (file #8969) ___ Additional Item Attachment: File name: 20100414-06-trunk-add-create_player-lua-function.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?1616 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15881] Can't read the number of settings in the save file
URL: http://gna.org/bugs/?15881 Summary: Can't read the number of settings in the save file Project: Freeciv Submitted by: pepeto Submitted on: mercredi 14.04.2010 à 22:11 Category: general Severity: 2 - Minor Priority: 3 - Low Status: Confirmed Assigned to: None Originator Email: Open/Closed: Open Release: trunk Discussion Lock: Any Operating System: None Planned Release: 2.3.0 ___ Details: From knotwork on the IRC channel: 1: in settings_game_load() [settings.c::2181]: Can't read the number of settings in the save file. I can reproduce with loading a scenario. ___ Reply to this item at: http://gna.org/bugs/?15881 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1574] add a player to a running game
Follow-up Comment #13, patch #1574 (project freeciv): I have not had success in applying the latest patch to try it :-( I added the current version of the patch. The order of applying the patches is: * patch #1613: cleanup stdinhand.c:handle_stdin_input() * patch #1615: cleanup player name check * (this patch) * patch #1616: add create_player lua function patch #1616 seems to work but I'm not sure if it is correct as trying to add a new player results in an error using the newcomer.sav file (file #8970) ___ Additional Item Attachment: File name: 20100414-05-trunk-add-a-player-to-a-running-game.patch Size:16 KB ___ Reply to this item at: http://gna.org/patch/?1574 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15881] Can't read the number of settings in the save file
Update of bug #15881 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = pepeto ___ Follow-up Comment #1: Fix attached. (file #8973) ___ Additional Item Attachment: File name: trunk_settings_game_load.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?15881 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1630] cleanup struct player
Follow-up Comment #1, patch #1630 (project freeciv): About _enum player_status_: * You should comment the values where the enumeration is defined, if someone adds a value, not sure he will find where this is commented. * Are you sure those values handle correctly all player possible states? Is it impossible to cumulate many of them? ___ Reply to this item at: http://gna.org/patch/?1630 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1629] cleanup struct unit
Follow-up Comment #1, patch #1629 (project freeciv): Using FC_FREE() is quite useless when you don't use the pointer after (e.g. at the end of a scope). FC_FREE() is not really a freeciv wrapper for free(), it's almost a macro of the client SDL to set the pointer to NULL. I personally doesn't like it so much. ___ Reply to this item at: http://gna.org/patch/?1629 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1574] add a player to a running game
Follow-up Comment #14, patch #1574 (project freeciv): create_player returns NULL, because the player-creating commands (newcomer and pregame) only take struct player *, not struct player ** arguments that are needed to be able to write the pointer back to the caller. ___ Reply to this item at: http://gna.org/patch/?1574 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1616] add create_player lua function
Follow-up Comment #2, patch #1616 (project freeciv): It works well on testing (except not returning the player, but you can get the player variable back from other places of course). A comment on a very small thing: in the api_actions.[ch] files, all type names use the API typedefs, Nation_Type instead of struct nation_type. ___ Reply to this item at: http://gna.org/patch/?1616 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1574] add a player to a running game
Follow-up Comment #15, patch #1574 (project freeciv): This version of newcomers.sav works anyway. This version tries to create settlers and attack units to match the currently alive nations.. something similar to the newcomers code. (file #8974) ___ Additional Item Attachment: File name: newcomers.sav Size:8 KB ___ Reply to this item at: http://gna.org/patch/?1574 ___ Meddelandet skickades via/av Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [bug #13599] [RFC; patch] pollution on lakes / ocean
I've started working on generalizing tile specials before school started, but now I hardly find time to sleep. Hopefully, when semester will end I'll get back into it. On Wed, Apr 14, 2010 at 4:05 PM, pepeto no-reply.invalid-addr...@gna.org wrote: Update of bug #13599 (project freeciv): Priority: 5 - Normal = 1 - Later ___ Follow-up Comment #4: Before implementing this, shouldn't we make the tile special a part of the ruleset? ___ Reply to this item at: http://gna.org/bugs/?13599 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
