[Freeciv-Dev] [bug #19913] Unit veteran level can exceed new type's maximum on upgrade

2012-07-12 Thread Jacob Nevins
Follow-up Comment #6, bug #19913 (project freeciv):

Rebased version for trunk, same behaviour as before.

I intend to commit this soon, unless anyone objects to my not scaling the
veteran level?

(file #16068)
___

Additional Item Attachment:

File name: trunk-upgrade-veteran-levels-bis.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19913

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19926] WORDS_BIGENDIAN MacOS X universal binaries

2012-07-12 Thread David Lowe
Follow-up Comment #1, bug #19926 (project freeciv):

While this is something that we might want to straighten out anyway, universal
binaries are probably not an issue anymore.  Our current Mac binaries only run
on OSX 10.7, and 10.7 doesn't support PPC processors.  The last version of OSX
that ran on PPC was 10.5, and Apple no longer releases security updates for
it.  Other than a few diehards, i suspect most PPC users to have reloaded with
Debian or similar.

___

Reply to this item at:

  http://gna.org/bugs/?19926

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19253] unit_bribe_cost veteran contribution looks wrong

2012-07-12 Thread Jacob Nevins
Update of bug #19253 (project freeciv):

  Depends on: = bugs #19931


___

Reply to this item at:

  http://gna.org/bugs/?19253

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

2012-07-12 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?19932

 Summary: Attempting to set a goto path with the end tile also
being a waypoint does nothing
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu Jul 12 23:42:54 2012
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r21520
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Noticed in passing on trunk.
* Start a goto path for a unit (G).
* Move to a tile and set a waypoint (G).
* Immediately left-click on the same tile to finish the path.
Expected: unit starts goto.
Actual: nothing happens, goto path lost.

Haven't checked other branches yet.




___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

2012-07-12 Thread Jacob Nevins
Update of bug #19932 (project freeciv):

  Status:None = Confirmed  

___

Follow-up Comment #1:

Confirmed on S2_4 and S2_3 too.

___

Reply to this item at:

  http://gna.org/bugs/?19932

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19931] Veteran move_bonus not correctly interpreted by client

2012-07-12 Thread Jacob Nevins
Update of bug #19931 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-veteran-move-bonus-client.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19931

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19253] unit_bribe_cost veteran contribution looks wrong

2012-07-12 Thread Jacob Nevins
Update of bug #19253 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #5:

How about this patch? It has the simple power_fact based behaviour, and also
takes into account move_bonus, as a fraction of the unit's base move rate
(with a special case if that is zero). So a veteran unit with a base move rate
of 3 and a move_bonus of 1 costs ~1.33x what the non-veteran unit would.

Will commit soon for 2.4.0 if no-one objects.

(file #16070)
___

Additional Item Attachment:

File name: trunk-S2_4-veteran-bribe-costs.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19253

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19925] 'ai-settler-tdc_hash != ((void *)0)' failed.

2012-07-12 Thread David Fernandez
Follow-up Comment #2, bug #19925 (project freeciv):

Ok, this is really weird, but I'm pretty sure I tested it properly... (with
trunk r21520)

When I copy the files from Civ2Civ3 folder into Classic folder (replacing
them), then I can play civ2civ3 rules without the assertion error, no matter
if I use the default.serv or the civ2civ3.serv.

I would thank confirmation of this error:
1- Compile trunk r21520
2- run server: ./fcser -r data/civ2civ3.serv
3- run client: ./fcgui
4- Connect to network game and end turn
-- assertion error here --

5- Copy files from Civ2Civ3 folder to Classic
6- Repeat 1 to 4 to verify there is no assertion error this time

___

Reply to this item at:

  http://gna.org/bugs/?19925

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19899] AI builds unneeded settlers in late game

2012-07-12 Thread David Fernandez
Follow-up Comment #13, bug #19899 (project freeciv):

I confirm this patch fixes the wrong AI behavior that I reported.
Thank you very much.

___

Reply to this item at:

  http://gna.org/bugs/?19899

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19933] civ2civ3 ruleset missing irrigation

2012-07-12 Thread David Fernandez
URL:
  http://gna.org/bugs/?19933

 Summary: civ2civ3 ruleset missing irrigation
 Project: Freeciv
Submitted by: bardo
Submitted on: vie 13 jul 2012 03:44:43 GMT
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

I forgot to add to effects.ruleset the effects Irrig_Possible and
City_Image. 

I used to send to cazfi my changes to this ruleset. Since civ2civ3 was added
to the repository, I'll try to upload here the fixes for the bugs I find.
This is the first time I upload a patch here, I hope it is ok.

Note this patch does not fix the bug reported here: bug #19925
https://gna.org/bugs/?19925




___

File Attachments:


---
Date: vie 13 jul 2012 03:44:43 GMT  Name:
civ2civ3-Irrigation-CityImage_21520.diff  Size: 1kB   By: bardo

http://gna.org/bugs/download.php?file_id=16071

___

Reply to this item at:

  http://gna.org/bugs/?19933

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev