[Freeciv-Dev] [bug #21404] i can't get selected cities to celebrate

2014-01-08 Thread anonymous 
Follow-up Comment #4, bug #21404 (project freeciv):

I see. Thanks for clearing that up.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20842] unit still in focus after put in sentry mode in batch

2014-01-08 Thread pepeto 
Follow-up Comment #10, bug #20842 (project freeciv):

> Anyway, I started testing your patch on 2.4-beta-2, and it
> seems to work without problem.

I encountered some problems to reproduce with version >= 2.4, I didn't find
the reason. But this bug is still reproducible when an enemy unit moves near
your unit stack (you also can simulate it with adding a unit near your owns
with editor). So I am attaching the version for these branches.

> I think I am still missing something with ACTIVITY_IDLE. Is the
> comment in "packand.c" you mentioned still up to date? I doubt
> about it, because for normal actions such as you described,
> units should be put into the urgent focus queue.

I have tried to investigate. As far as I saw, since revision 8870 for
PR#10695, the client doesn't set ACTIVITY_IDLE directly anymore. I propose to
remove this obsolete comment (patch attached).


(file #19707, file #19708)
___

Additional Item Attachment:

File name: 0001-Remove-units-which-aren-t-IDLE-from-the-urgent-focus.patch
Size:3 KB
File name: 0002-Removed-obsolete-comment-r8870.patch Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19932] Attempting to set a goto path with the end tile also being a waypoint does nothing

2014-01-08 Thread pepeto 
Update of bug #19932 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Planned Release: => 2.3.5,2.4.2,2.5.0,2.6.0

___

Follow-up Comment #4:

> end==start looks like it might be a special internal signal
> from pathfinding. If so, we should presumably filter out "real"
> end==start segments before they get this far.

Actually, this signal is not pathfinding related, but a logic only used in
"client/goto.c". The pathfinding signal is that the returned path are NULL.
The patch I am attaching use this logic.


(file #19709)
___

Additional Item Attachment:

File name: 0001-Fix-for-bug-19932.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4418] Allow the usage of waypoints for units comming from different tiles

2014-01-08 Thread pepeto 
URL:
  

 Summary: Allow the usage of waypoints for units comming from
different tiles
 Project: Freeciv
Submitted by: pepeto
Submitted on: mer. 08 janv. 2014 11:42:57 CET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0,2.6.0

___

Details:

I don't see why it has been disabled...




___

File Attachments:


---
Date: mer. 08 janv. 2014 11:42:57 CET  Name:
0002-Allow-common-waypoint-for-units-comming-from-differe.patch  Size: 1 ko  
By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21359] Fighter movement

2014-01-08 Thread Jacob Nevins 
Follow-up Comment #6, bug #21359 (project freeciv):

Hi pepeto, good to see you again. Thanks for looking into this and the other
pathfinding patches.

If you have a moment, can you check that my patch for bug #21369 doesn't
contain any obvious breakage?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21369] Pathfinding for fueled units can waste time looking too far for refuel point

2014-01-08 Thread pepeto 
Follow-up Comment #5, bug #21369 (project freeciv):

I think you were right. The old operation looks very suspect and would return
a result in square moves.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3897] Respect slow_invasions in pathfinding

2014-01-08 Thread pepeto 
Update of patch #3897 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.0,2.6.0

___

Follow-up Comment #2:

I have read your patch very closely. There were some parts I couldn't
understand, now I got it!

Ready for test.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3900] Consolidate UTYF_IGTER logic

2014-01-08 Thread pepeto 
Update of patch #3900 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3901] Rewrite get_MC callbacks for complex nativity

2014-01-08 Thread pepeto 
Update of patch #3901 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3903] Don't use UMT_SEA to assign unknown_MC cost

2014-01-08 Thread pepeto 
Update of patch #3903 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4374] Avoid accidentally using Qt 4's moc

2014-01-08 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #4, patch #4374 (project freeciv):

New version. If MOCCMD isn't set it will first try moc. If moc fails it will
try qtchooser. If qtchooser fails as well it will print a warning.

(file #19711)
___

Additional Item Attachment:

File name: use_qtchooser_if_moc_is_wrong.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4412] Save player colours from freeciv-ruledit

2014-01-08 Thread Marko Lindqvist 
Update of patch #4412 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4414] hp_loss_pct documentation: "airbase" -> "native base"

2014-01-08 Thread Marko Lindqvist 
Update of patch #4414 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21453] packets.def listed as source file to compile

2014-01-08 Thread Marko Lindqvist 
Update of bug #21453 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4383] Render SDL2-client main menu

2014-01-08 Thread Marko Lindqvist 
Update of patch #4383 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4419] Allocate sdl2-client Main.gui

2014-01-08 Thread Marko Lindqvist 
URL:
  

 Summary: Allocate sdl2-client Main.gui
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 09 Jan 2014 06:46:57 AM EET
Category: client-sdl2
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Create Main.gui so using it's not NULL.




___

File Attachments:


---
Date: Thu 09 Jan 2014 06:46:57 AM EET  Name: SDL2MainGui.patch  Size: 4kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4374] Avoid accidentally using Qt 4's moc

2014-01-08 Thread Marko Lindqvist 
Follow-up Comment #5, patch #4374 (project freeciv):

- FC_QT_TRY_MOC should be defined in qt5.m4. Maybe name as FC_QT5_TRY_MOC to
match naming of other Qt-macros - unless the idea is that the macro will be
parametrized to handle other Qt-versions as needed (If we end back supporting
both Qt4 and Qt5 in S2_5, will there be separate macros for callers to call,
or is it the same macro with different parameter?)

- At least the warning about missing MOCCMD should be inside FC_QT5 so it's
emitted only when building some Qt-program. And in that case it should
probably be hard error rather than just warning



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21462] aiferry: assertion '((void *)0) != pgenlist' failed.

2014-01-08 Thread Marko Lindqvist 
URL:
  

 Summary: aiferry: assertion '((void *)0) != pgenlist' failed.
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 09 Jan 2014 07:12:28 AM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_5: r24072
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:


Attached civ1 autogame fails assert in aiferry code. I suspect that ferry has
somehow died and garbage structures are being used.


(gdb) bt
#0  0x7640e0eb in raise (sig=6)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:38
#1  0x00676562 in fc_assert_fail (file=0x7552b0 "utility/genlist.c", 
function=0x755303 <__FUNCTION__.5791> "genlist_size", line=233, 
assertion=0x7552d6 "((void *)0) != pgenlist", message=0x7554b4
"nologmsg:%s")
at utility/log.c:520
#2  0x006745dc in genlist_size (pgenlist=0x0) at
utility/genlist.c:233
#3  0x00546b35 in unit_list_size (tthis=0x0)
at utility/speclist.h:383
#4  0x005485a7 in dai_activate_passengers (ait=0xa35d80 , 
ferry=0x1d90ba0) at ai/default/aiferry.c:554
#5  0x00548cf8 in dai_amphibious_goto_constrained (ait=0xa35d80
, 
ferry=0x1d90ba0, passenger=0x22ac790, ptile=0xc012e0,
parameter=0x7fffd760)
at ../../../ai/default/aiferry.c:630
#6  0x00548ec2 in aiferry_goto_amphibious (ait=0xa35d80 , 
ferry=0x1d90ba0, passenger=0x22ac790, ptile=0xc012e0)
at ../../../ai/default/aiferry.c:673
#7  0x00549cfe in aiferry_gobyboat (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x22ac790, dest_tile=0xc012e0,
with_bodyguard=false)
at ../../../ai/default/aiferry.c:800
#8  0x005660d3 in dai_military_attack (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x22ac790) at ai/default/aiunit.c:1695
#9  0x00568e59 in dai_manage_military (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x22ac790) at ai/default/aiunit.c:2334
#10 0x00569c47 in dai_manage_unit (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x22ac790) at ai/default/aiunit.c:2532
#11 0x0054b3af in dai_manage_ferryboat (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x1d90ba0) at ai/default/aiferry.c:1080
#12 0x00569acf in dai_manage_unit (ait=0xa35d80 , 
pplayer=0x24e2920, punit=0x1d90ba0) at ai/default/aiunit.c:2512
#13 0x0056a627 in dai_manage_units (ait=0xa35d80 , 
pplayer=0x24e2920) at ai/default/aiunit.c:2663
#14 0x0054f3a0 in dai_do_first_activities (ait=0xa35d80 , 
pplayer=0x24e2920) at ai/default/aihand.c:725
#15 0x0050a1a5 in cai_do_first_activities (pplayer=0x24e2920)
at ../../../ai/classic/classicai.c:379
#16 0x00437279 in ai_start_phase () at server/srv_main.c:796
#17 0x00437c7d in begin_phase (is_new_phase=true)
at ../../server/srv_main.c:948
#18 0x0043bc29 in srv_running () at server/srv_main.c:2259
#19 0x0043d17f in srv_main () at server/srv_main.c:2787
#20 0x004317a0 in main (argc=6, argv=0x7fffe2b8)
at ../../server/civserver.c:454




___

File Attachments:


---
Date: Thu 09 Jan 2014 07:12:28 AM EET  Name: civ1crash.serv  Size: 205B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4398] Make "Show All" to toggle between player's tree and all techs

2014-01-08 Thread Marko Lindqvist 
Update of patch #4398 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21403] Pillaging EF_ALWAYS_ON_CITY_CENTER extras from city centers

2014-01-08 Thread Marko Lindqvist 
Update of bug #21403 (project freeciv):

 Planned Release:2.5.0, 2.6.0 => 2.5.0-beta1, 2.6.0 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4420] [Metaticket] Art required for 2.5

2014-01-08 Thread Marko Lindqvist 
URL:
  

 Summary: [Metaticket] Art required for 2.5
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 09 Jan 2014 07:45:00 AM EET
Category: art
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7668] Tracking release 2.5.0

2014-01-08 Thread Marko Lindqvist 
Update of task #7668 (project freeciv):

  Depends on: => patch #4420


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4420] [Metaticket] Art required for 2.5

2014-01-08 Thread Marko Lindqvist 
Update of patch #4420 (project freeciv):

  Depends on: => patch #4160


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev