Follow-up Comment #5, patch #4374 (project freeciv):

- FC_QT_TRY_MOC should be defined in qt5.m4. Maybe name as FC_QT5_TRY_MOC to
match naming of other Qt-macros - unless the idea is that the macro will be
parametrized to handle other Qt-versions as needed (If we end back supporting
both Qt4 and Qt5 in S2_5, will there be separate macros for callers to call,
or is it the same macro with different parameter?)

- At least the warning about missing MOCCMD should be inside FC_QT5 so it's
emitted only when building some Qt-program. And in that case it should
probably be hard error rather than just warning


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to