[Freeciv-Dev] [bug #22054] Arrival of a caravan/freight by sea does not trigger traderoute dialog

2014-05-19 Thread pepeto
Update of bug #22054 (project freeciv): Severity: 4 - Important = 2 - Minor Status:None = Confirmed Operating System: GNU/Linux = Any

[Freeciv-Dev] [bug #22054] Arrival of a caravan/freight by sea does not trigger traderoute dialog

2014-05-19 Thread pepeto
Update of bug #22054 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = pepeto Planned Release: = 2.4.3,2.5.0,2.6.0

[Freeciv-Dev] [bug #21938] ORDER_FULL_MP waits if unit's move rate is reduced after orders laid in

2014-05-19 Thread pepeto
Follow-up Comment #2, bug #21938 (project freeciv): '' looks the correct thing. I don't think we should cancel path or recalculate path if the move rate was changed. Or at least not at server side (anyway the AI recalculates path every turns). And I think this is a separated issue. Not that

[Freeciv-Dev] [bug #22053] Impossible to attack cities with pathfinding

2014-05-19 Thread Emmet Hikory
Follow-up Comment #1, bug #22053 (project freeciv): Only units with UCF_CAN_OCCUPY should be permitted to attack cities that do not contain units, so conditional becomes something like the following (untested): if ((is_non_allied_unit_tile(target, param-owner) ||

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-05-19 Thread David Lowe
Follow-up Comment #3, bug #22050 (project freeciv): On question 3, i would agree that the volume taken up by a transported unit shouldn't change if it has something else inside it. This is not true for the case of something being transported *outside*, but those cases are so few we can probably

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated Connect to network game / Cancel

2014-05-19 Thread Jacob Nevins
Follow-up Comment #2, bug #22048 (project freeciv): With this patch, in sessions which survived bug #22047, I was still able to reproduce symptoms (1) and (3) but didn't see (2). Which suggests those are unrelated and probably need new ticket(s).

[Freeciv-Dev] [patch #4689] CodingStyle update

2014-05-19 Thread Jacob Nevins
Update of patch #4689 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22048] Crashes and other trouble with repeated Connect to network game / Cancel

2014-05-19 Thread Jacob Nevins
Update of bug #22048 (project freeciv): Planned Release: 2.6.0 = 2.5.0, 2.6.0 ___ Follow-up Comment #3: Seen symptoms (1) and (3) with unpatched S2_5 as well. Not seen (2) in my testing. Not

[Freeciv-Dev] [bug #22047] Crash in gtk_text_layout_get_cursor_locations() on Connect to network game

2014-05-19 Thread Jacob Nevins
Update of bug #22047 (project freeciv): Planned Release: 2.6.0 = 2.5.0, 2.6.0 ___ Follow-up Comment #2: Also seen with S2_5 r24899 (at least the first symptom). Not reproduced any trouble with S2_4.

[Freeciv-Dev] [bug #22040] AI creates too many triremes

2014-05-19 Thread Marko Lindqvist
Follow-up Comment #5, bug #22040 (project freeciv): There actually was handling of passenger death in unit_free -callback. Attached version of the patch removes it. So now the patch moves the check from unit_free to unit_lost, since latter gets called for any reason control to unit is lost,