[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40196 > As far as I can see the mystrncasequotecmp function is only used by find_player_by_name_prefix. Why would the player names in the internal server/client data structures (i.e. in game.players[]) have meaningless (i.e. not significant for compa

[Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-08 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39614 > > [EMAIL PROTECTED] - Mar. Avr. 08 20:14:47 2008]: > > On 12/10/2007, Pepeto _ wrote: > > First step: clean up in stdinhand. /aitoggle, /remove, /cmdlevel and > > /cut support the arguments between quote marks. > > I believe this is red

[Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=40196 > > [EMAIL PROTECTED] - Mar. Avr. 08 19:55:49 2008]: > > On 07/04/2008, Pepeto _ wrote: > > > > Try with this patch. > > Bugs I reported cannot be reproduced when this patch is applied. > Still, I don't think patch is correct. At the very

Re: [Freeciv-Dev] (PR#39614) client connection list in start page

2008-04-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39614 > On 12/10/2007, Pepeto _ wrote: > First step: clean up in stdinhand. /aitoggle, /remove, /cmdlevel and > /cut support the arguments between quote marks. I believe this is redundant after #40196 patch. #40196 fixes lowlevel quoted string h

Re: [Freeciv-Dev] (PR#40196) String comparison preoblems

2008-04-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40196 > On 07/04/2008, Pepeto _ wrote: > > Try with this patch. Bugs I reported cannot be reproduced when this patch is applied. Still, I don't think patch is correct. At the very least changes you make should not be required (if other parts of t

[Freeciv-Dev] (PR#40200) Helpdata.c needs unhardcoding

2008-04-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40200 > helpdata.c has never reached totally modpack/ruleset independent state. At very least, 2.2 should not be farther from that goal than 2.1. Information provided by #39831 should be read/generated from rulesets. Another problem with #39831

[Freeciv-Dev] (PR#40199) [Patch] Do not include libintl.h when nls disabled

2008-04-08 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40199 > Some versions of libintl.h break --disable-nls compile (maybe also: when it compiles, nls is not really disabled) Fix attached. - ML diff -Nurd -X.diff_ignore freeciv/utility/fcintl.h freeciv/utility/fcintl.h --- freeciv/utility/fcintl