[Freeciv-Dev] [patch #2933] net_lookup_service() returns list of addresses

2011-10-25 Thread Marko Lindqvist

Update of patch #2933 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2933

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2873] [lua108] client lua script console (gtk3)

2011-10-25 Thread Jacob Nevins

Update of patch #2873 (project freeciv):

 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2873

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18641] allow remove command for access level = ADMIN in running games

2011-10-25 Thread Jacob Nevins

Follow-up Comment #8, bug #18641 (project freeciv):

Committed error message fix. Leaving ticket open pending decision whether to
port feature to S2_3.

___

Reply to this item at:

  http://gna.org/bugs/?18641

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

2011-10-25 Thread anonymous

Follow-up Comment #17, patch #2715 (project freeciv):

Due to your comment following patches are a bit rushed - among other, I
haven't checked it it still builds against gtk3.
Patches are against trunk, r20326.

I'm the guy from bug #18243 and bug #18607 (on that note: pretty please about
the later ?) Submission is anonymous only cause I don't like creating new
accounts that I'm nearly certain I'll forget about. The first bug has my info
on the referenced gnome and gentoo bugs. Just email me.

Somewhat in regard of the later bug: one of the blocks in those patches makes
the Close button quite large on the tabs, but without it, in vanilla freeciv
2.3.0 the icons in that button were noticeably cropped.

I've noticed something, that might have been bug #18844 so I've change
gtk_main_quit to client_quit in one place - I haven't checked, if it's still
needed after the patch in that bug.

Again, why is supported units pixcomm 3/2 times as high as present units ?

Obviously, there's still much cleanup to do, i.e. it seems
pixmap_put_overlay_tile_draw should always call pixmap_put_sprite and just
paint it again with CAIRO_OPERATOR_HSL_COLOR on 'if (fog)'.

Also, the only result of choosing Lua console in the menu is Gtk-CRITICAL
**: IA__gtk_widget_realize: assertion `GTK_WIDGET_ANCHORED (widget) ||
GTK_IS_INVISIBLE (widget)' failed, but that's regardless of my patches.


(file #14248, file #14249)
___

Additional Item Attachment:

File name: api-cleanup-svn.patch  Size:46 KB
File name: cairo-drawing-svn.patchSize:109 KB


___

Reply to this item at:

  http://gna.org/patch/?2715

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18816] When you lose a technology, cities check doesn't count on upgradable productions

2011-10-25 Thread Jacob Nevins

Follow-up Comment #1, bug #18816 (project freeciv):

Can you explain the scenario in your screenshots more?

I can see that you stole Genetic Engineering from the Spanish, but you lost
it during the transfer (Too bad! You made a mistake transferring the tech %s
and lost it. -- presumably you had a non-zero techlost_recv) -- which,
looking at the code, I think means that you never got it at all (despite what
the messages imply).[*]

But that tech doesn't enable or obsolete any units, and doesn't obsolete any
buildings (I see you're playing what looks like the experimental ruleset, so
it enables Genetic Lab).

So I'm not quite sure I follow what behaviour you're seeing that you don't
expect.

Also, what version was this? 2.3.0?

[*] I notice that forget_tech_transfered() is called in the techlost_recv
case, and enacts all the consequences of removing a tech from a player that
doesn't have it. I haven't worked out if that's safe.

___

Reply to this item at:

  http://gna.org/bugs/?18816

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2477] [transport09] use pointer for transported units (server/common)

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2477 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #3:

rebased patch

changes 20111020:

* fix comment
* fix allied units on transporters


(file #14250)
___

Additional Item Attachment:

File name: 0001-use-pointer-for-transported-units-server-common.patch Size:52
KB


___

Reply to this item at:

  http://gna.org/patch/?2477

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18816] When you lose a technology, cities check doesn't count on upgradable productions

2011-10-25 Thread Jacob Nevins

Follow-up Comment #2, bug #18816 (project freeciv):

(This sounds a bit similar to bug #18736.)

___

Reply to this item at:

  http://gna.org/bugs/?18816

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2547] [transport19] cleanup unit_move()

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2547 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #2:

rebased patch

changes 20110924:

- wakup units before we move (now autogames differ only in saved vision)
- must also add the compatibility patch; it moves the transported units
_before_ the transported; this is only a helper patch - the patch does it the
right way: move the transporter and if it survive, move the transported units

(file #14251, file #14252)
___

Additional Item Attachment:

File name: 0002-cleanup-unit_move.patch   Size:18 KB
File name: 0011-autogame-compatibility.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/patch/?2547

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2478] [transport10] use pointer for transported units (client)

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2478 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #2:

rebased patch

changes 20110819:

* add unit_transported() function as simplified unit_transport_get()

changes 20111025:
* fix client - set unit-client.transported_by to -1 on unload


(file #14253)
___

Additional Item Attachment:

File name: 0003-use-pointer-for-transported-units-client.patch Size:19 KB


___

Reply to this item at:

  http://gna.org/patch/?2478

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18710] fix error if future tech is researched

2011-10-25 Thread Jacob Nevins

Follow-up Comment #1, bug #18710 (project freeciv):

Do you plan to commit this for 2.3.1?

___

Reply to this item at:

  http://gna.org/bugs/?18710

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2479] [transport11] clean up network (occupied information of transporters)

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2479 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #2:

rebased patch

(file #14254)
___

Additional Item Attachment:

File name: 0004-clean-up-network-occupied-information-of-transporter.patch
Size:5 KB


___

Reply to this item at:

  http://gna.org/patch/?2479

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2482] [transport14] redo location selection

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2482 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #2:

rebased patch

(file #14255)
___

Additional Item Attachment:

File name: 0005-redo-location-selection.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/patch/?2482

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18687] Server timeouts 60 hours do not cause client update

2011-10-25 Thread Jacob Nevins

Update of bug #18687 (project freeciv):

 Planned Release: = 2.4.0  


___

Reply to this item at:

  http://gna.org/bugs/?18687

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2483] [transport15] add function to create unit type sprite

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2483 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #3:

redone patch

(file #14256)
___

Additional Item Attachment:

File name: 0006-add-function-to-create-unit-type-sprite.patch Size:13 KB


___

Reply to this item at:

  http://gna.org/patch/?2483

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2975] Tuareg nation

2011-10-25 Thread J.M. Maalderink

Update of patch #2975 (project freeciv):

 Assigned to:None = mixcoatl   

___

Follow-up Comment #1:

resized the flag you linked to

original version by Escondites, Wikimedia Commons

(file #14257)
___

Additional Item Attachment:

File name: tuareg.svg Size:2 KB


___

Reply to this item at:

  http://gna.org/patch/?2975

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18633] set timeout - seconds are slightly shorter than in real life

2011-10-25 Thread Jacob Nevins

Follow-up Comment #4, bug #18633 (project freeciv):

So... the current behaviour is understood. Is it a problem, or shall we close
this ticket?

___

Reply to this item at:

  http://gna.org/bugs/?18633

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17236] [transport18] unit selection dialog

2011-10-25 Thread Matthias Pfafferodt

Follow-up Comment #16, bug #17236 (project freeciv):

rebased patch; no changes compared to comment #12

(file #14258)
___

Additional Item Attachment:

File name: 0007-unit-selection-dialog.patch Size:70 KB


___

Reply to this item at:

  http://gna.org/bugs/?17236

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2480] [transport12] allow recursive transports

2011-10-25 Thread Matthias Pfafferodt

Update of patch #2480 (project freeciv):

 Assigned to:None = syntron

___

Follow-up Comment #2:

rebased patch

(file #14259)
___

Additional Item Attachment:

File name: 0008-allow-recursive-transports.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?2480

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2270] [metaticket] allow recursive transports

2011-10-25 Thread Matthias Pfafferodt

Follow-up Comment #13, patch #2270 (project freeciv):

found the bug - units on the client there not marked as unloaded; rebased 
fixed patches are added to all tickets

___

Reply to this item at:

  http://gna.org/patch/?2270

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2976] Marathi nation

2011-10-25 Thread J.M. Maalderink

Update of patch #2976 (project freeciv):

  Status:None = In Progress
 Assigned to:None = mixcoatl   

___

Follow-up Comment #1:

The original flag was swallow tailed; unfortunately the game can only display
rectangular flags. How do you want the flag to look like in-game? Just all
orange? Or leave a white triangle to represent the swallow tail?
Alternatively, we can base it on this one:
http://commons.wikimedia.org/wiki/File:Marathi_Flag.svg

___

Reply to this item at:

  http://gna.org/patch/?2976

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2962] Antiguan and Barbudan nation

2011-10-25 Thread J.M. Maalderink

Update of patch #2962 (project freeciv):

  Status: In Progress = Ready For Test 


___

Reply to this item at:

  http://gna.org/patch/?2962

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18710] fix error if future tech is researched

2011-10-25 Thread Matthias Pfafferodt

Follow-up Comment #2, bug #18710 (project freeciv):

yes; I will have to check a lot of (bugfix) patches tomorrow

___

Reply to this item at:

  http://gna.org/bugs/?18710

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18816] When you lose a technology, cities check doesn't count on upgradable productions

2011-10-25 Thread Jordi Negrevernis i Font

Follow-up Comment #3, bug #18816 (project freeciv):

This is the experimental ruleset on S2_3.

I conquered a Spanish city, so i gained the Genetic Engineering.
But in the same turn, previously I also conquered another Spanish city and
this give me The Corporation.
So i did have cities producing caravans instead of freights...
So when forget_tech_transfered() was called it encountered cities producing
caravans which now it can't build...
So, instead of upgrading those caravan units to freights, it just removed and
begin building airports

And, yes, it seams similar to bug #18736.


___

Reply to this item at:

  http://gna.org/bugs/?18816

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] compile issues

2011-10-25 Thread Jason Dorje Short
On Mon, Oct 24, 2011 at 4:33 PM, Marko Lindqvist cazf...@gmail.com wrote:
 On 24 October 2011 22:20, Jason Dorje Short jdo...@gmail.com wrote:
 For the first time in some time, I have time for freeciv work.  But on
 compiling, --enable-debug=checks (--enable-debug=yes in older
 branches) doesn't compile in trunk or in most branches anymore.

 One issue does seem to be in the GTK header files, both not under our
 control and commented in the headers as being deprecated in C99 but
 needed for backwards compatibility.  That particular check (-W flag
 given to gcc) will have to be removed for it to compile.

  What distribution are you using? Are you using distribution's
 versions of both gcc and gtk+ (one would assume that those are
 compatible with each other)? I have no such problems with Debian
 Wheezy; gcc  4.6.1, gtk2 2.24.6

Ubuntu oneiric.

$ gcc --version
gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1

$ dpkg -l | grep libgtk2.0-dev
ii  libgtk2.0-dev  2.24.6-0ubuntu5
   Development files for the GTK+ library



In file included from /usr/include/gtk-2.0/gtk/gtk.h:236:0,
 from colors.h:16,
 from chatline.c:44:
/usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: error: function
declaration isn't a prototype [-Werror=strict-prototypes]
cc1: all warnings being treated as errors

-jason

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18850] changing only cma will not be saved

2011-10-25 Thread Echter Name

URL:
  http://gna.org/bugs/?18850

 Summary: changing only cma will not be saved
 Project: Freeciv
Submitted by: gaymmaster
Submitted on: Mi 26 Okt 2011 00:32:04 GMT
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.3.0
 Discussion Lock: Any
Operating System: Microsoft Windows
 Planned Release: 

___

Details:

Freeciv-2.3.0-gtk2 

load a savegame(1)
change only cma in f4
save the game(2)
leave the game
load savegame(2)
cma is like in savegame(1)




___

Reply to this item at:

  http://gna.org/bugs/?18850

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18217] GCC 4.6: variable 'xxx' set but not used

2011-10-25 Thread Jason Dorje Short

Follow-up Comment #9, bug #18217 (project freeciv):

Attached patch fixes trunk for me.  I had to disable one warning, which
conflicts with gtkitemfactory.h:

/* We use () here to mean unspecified arguments. This is deprecated
 * as of C99, but we can't change it without breaking compatibility.
 * (Note that if we are included from a C++ program () will mean
 * (void) so an explicit cast will be needed.)
 */
typedef void(*GtkItemFactoryCallback)  ();


I also added a macro for marking unused variables within iterate macros.  For
instance:

  adjc_dir_iterate(tile0, tile1, dir) {
array[dir] = 1;
  } adjc_dir_iterate_end;

the tile1 variable is unused, and really can't be used nor is it worthwhile
to write a new iterator for this case.  (This was mentioned earlier in the bug
as well.)  Adding UNUSED_VAR(tile1) marks it as unused for both the compiler
and should be good for coders reading it as well.

#define UNUSED_VAR(x) (void)(x)

There is probably a better definition that could be used here however.

Finally there is one location in api_server_edit.c where a return value looks
to me like it should be checked, but since it wasn't it triggered the warning.
 I added a FIXME there but am not familiar enough with the code to know if
it's actually a problem.



(file #14260)
___

Additional Item Attachment:

File name: fix_compile_warnings_trunk.diff Size:13 KB


___

Reply to this item at:

  http://gna.org/bugs/?18217

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev