[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

[anonymous]

Follow-up Comment #27, patch #2715 (project freeciv):

As I said in comment #17, patches apply *cleanly* against r20326 trunk -
first apply api patch, then cairo.

As for variable names, if I had to come up with new names, writing those
patches would likely take up to three times as long - I prefer to just reuse
those I already have.

The blocks were for my convenience - they made patch size smaller and till
comment #16 I was working against 2.3.0 tarball.

See https://bugs.gentoo.org/show_bug.cgi?id=372087#c1 for my contact info.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

[Matthias Pfafferodt]

Update of bug #18776 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => syntron
 Planned Release: 2.3.2,2.4.0 => 2.3.1,2.4.0

___

Follow-up Comment #10:

quite hard to find ... on player remove not only the players map data has to
be deleted but also the knwoledge of all other players about the removed one!

fix attached; also to be used for 2.3.1

please test!

(file #14318)
___

Additional Item Attachment:

File name: 0034-fix-bug-in-player_map_free.patch Size:1 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2962] Antiguan and Barbudan nation

[J.M. Maalderink]

Update of patch #2962 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2993] Frankish nation

[J.M. Maalderink]

Update of patch #2993 (project freeciv):

  Status:None => In Progress
 Assigned to:None => mixcoatl   

___

Follow-up Comment #1:

Whoah, I was just working on a Frankish nation myself too, I've attached it,
we should combine both.

(file #14317)
___

Additional Item Attachment:

File name: frankish.ruleset   Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18513] Bases removed because changing terrain remain as border source, vision source

[Marko Lindqvist]

Update of bug #18513 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #7:

> Is this the way to go if different functionallity is needed in
> common code for server and client?

Libfreeciv (utility + common) should be as self-contained as possible, with
utility being self-contained even in relation to common, but when libfreeciv
user (executable) specific functionality is deemed necessary, this seems like
best way to do it. 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2859] gtk3-client require gtk 2.24

[Marko Lindqvist]

Update of patch #2859 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

[Marko Lindqvist]

Follow-up Comment #26, patch #2715 (project freeciv):

> Also, I wouldn't mind being CCed to this bug, so I wouldn't need
> to recheck it manually.

I don't know if gna tracker even makes it possible to setup that for single
ticket (I don't see such field) and you have given no address to cc to; you're
just Anonymous. All comments from this tracker are cc:d to freeciv-dev mailing
list. Maybe you should join there if you plan to do more freeciv hacking.

I've had no chance to check your latest patch, but comments about previous:
- It didn't apply to trunk. Are you sure you are creating patches against
clean freeciv tree?
- Blocks commented out by "#if 0 ... #endif" should be removed completely as
soon as they are not needed for reference when developing patch - once patch
is considered ready for commit, they should be gone
- Compared to latest version of the patch I did, you have renamed some
variables containing cairo surfaces as "pixmap" - isn't that highly confusing
name for object that is not pixmap?

About increasing minimum required gtk2 version: there's no reason to try to
avoid it. Soon we have to start building against gtk-2.24 anyway and to fix
anything that's deprecated in our codebase by those standards. I actually have
separate patch just for increasing minimum requirement to 2.24. That separate
patch was created when it seemed that this one would take forever to get
finished, and I still probably am going to commit it before this one (like
committing it tonight and only checking latest version of this one)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

[anonymous]

Follow-up Comment #25, patch #2715 (project freeciv):

OK, few things of note:
- gtk_combo_box_text_new used in my patch means it requires gtk+-2.24 (well,
the eventual aim of this patch is gtk+-3 and there's no gtk_combo_box_new_text
there)

- r20328 solves the problem with "Lua console" dialog: now it's gets shown in
the chat notebook

Also, I wouldn't mind being CCed to this bug, so I wouldn't need to recheck
it manually.

I've reintroduced the minor change in gtkpixcomm.c that was present in the
patches before comment #17, but was missed in the later.

Retested if it builds with gtk3 - it does, but still crashes without showing
anything.

(file #14315)
___

Additional Item Attachment:

File name: cairo-drawing-svn2.patch   Size:109 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18880] assertion 'adv->phase_is_initialized' failed.

[Matthias Pfafferodt]

Update of bug #18880 (project freeciv):

 Planned Release:   2.4.0 => 2.4.0, 2.3.1?  


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18880] assertion 'adv->phase_is_initialized' failed.

[Matthias Pfafferodt]

Update of bug #18880 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => syntron

___

Follow-up Comment #1:

add patch - advisor and ai phases must be started for contacts at this point

(file #14314)
___

Additional Item Attachment:

File name: 0005-fix-missing-advisor-if-contact-on-placing-the-first-.patch
Size:1 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] please support vertical tabs

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

 Planned Release:   2.4.0 => 2.4.0, 2.3.1?  

___

Follow-up Comment #12:

Updated patch:

- part 1: file #14294
- part 2: file #14295
- part 3: new file
(0003-gtk2-add-a-new-option-to-activate-the-diplomatic-tab.patch)
- part 4: updated file
(0004-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch)

- all-in-one-patch: dipl_metting.patch

screenshoot: dipl_dialog_new_20111029.jpg

> By the way, do you expect the patches would apply cleaning to
> 2.3.0? if so i might do a test rebuild and try it out. 
Save of the changes to 'client/gui-gtk-2.0/luaconsole.c' the all-in-one-patch
does apply to 2.3. I did not compile it but if you are successful this could
be included in 2.3.1.

Please also check differen screen layouts as part 4 changes the rrangement of
the elements. Does it is OK for small screens, widescreens, etc.

(file #14310, file #14311, file #14312, file #14313)
___

Additional Item Attachment:

File name: 0003-gtk2-add-a-new-option-to-activate-the-diplomatic-tab.patch
Size:2 KB
File name: 0004-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:8 KB
File name: dipl_metting.patch Size:24 KB
File name: dipl_dialog_new_20111029.jpg   Size:106 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18880] assertion 'adv->phase_is_initialized' failed.

[Matthias Pfafferodt]

URL:
  

 Summary: assertion 'adv->phase_is_initialized' failed.
 Project: Freeciv
Submitted by: syntron
Submitted on: Sa 29 Okt 2011 13:56:47 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: svn20352
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0

___

Details:

If you make contact to another nation on your start position the following
assert fails:

1: in adv_data_get() [advdata.c::590]: assertion 'adv->phase_is_initialized'
failed.
2: Backtrace:
2: 0:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(+0xf2e7d)
[0x7f9f1f45ee7d]
2: 1:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(vdo_log+0xad)
[0x7f9f1f4654ad]
2: 2:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(do_log+0x7f)
[0x7f9f1f46559f]
2: 3:
/mnt/data/sdc6/matthias/git/freeciv.git/common/.libs/libfreeciv.so.0(fc_assert_fail+0x9b)
[0x7f9f1f4657db]
2: 4:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(adv_data_get+0x9e)
[0x7f9f1fdeb63e]
2: 5:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(dai_data_phase_begin+0x40)
[0x7f9f1fdc4790]
2: 6:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(ai_plr_data_get+0x47)
[0x7f9f1fdc5497]
2: 7:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(+0xef60b)
[0x7f9f1fdb860b]
2: 8:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(dai_treaty_evaluate+0xe1)
[0x7f9f1fdb9b11]
2: 9:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(handle_diplomacy_create_clause_req+0x102)
[0x7f9f1fd18312]
2:10:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(make_contact+0x28e)
[0x7f9f1fd329de]
2:11:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(maybe_make_contact+0x2fd)
[0x7f9f1fd32e1d]
2:12:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(create_unit_full+0x12e)
[0x7f9f1fdab8ce]
2:13:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(create_unit+0x19)
[0x7f9f1fdaba39]
2:14:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(+0x58a42)
[0x7f9f1fd21a42]
2:15:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(init_new_game+0xae9)
[0x7f9f1fd225a9]
2:16:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/libfreeciv-srv.so.0(srv_main+0x297f)
[0x7f9f1fd8e69f]
2:17:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/freeciv-server()
[0x4053c8]
2:18: /lib64/libc.so.6(__libc_start_main+0xfd) [0x7f9f1afa5b7d]
2:19:
/mnt/data/sdc6/matthias/git/freeciv.git/server/.libs/freeciv-server()
[0x404979]

Steps to reproduce:

set size 2
set aifill 120
start

Possible solution:
- on creation of a nation initialise the advisor - adv_data_phase_init()
- after _all_ nations are created deinitialise it - adv_data_phase_done()




___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev