[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client
Update of patch #2715 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #59: - Removed parts handled in bug #18952 - fixed compilation errors and warnings when building against gtk3 (file #14491) ___ Additional Item Attachment: File name: Gtk3Cairo_2715-2.diff.bz2 Size:22 KB ___ Reply to this item at: http://gna.org/patch/?2715 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3026] Drop support for saving old style savegames
Update of patch #3026 (project freeciv): Status:None = Ready For Test Summary: Drop support for saving version 1 savegames = Drop support for saving old style savegames ___ Follow-up Comment #1: Attached patch drops support for saving in legacy savefile style. It was internally known as version -1, not 1 like I claimed in earlier comment. (file #14492) ___ Additional Item Attachment: File name: LegacySavegames_3026.diff.bz2 Size:13 KB ___ Reply to this item at: http://gna.org/patch/?3026 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18922] Server address binding fails
Follow-up Comment #11, bug #18922 (project freeciv): I've retested things and came to conclusion that it's indeed malloc-calloc change that's essential for making things work. On the other hand, doing memcpy with a different length than ai_addrlen doesn't seem to make sense - after all, that parameter is for this purpose exactly. ___ Reply to this item at: http://gna.org/bugs/?18922 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18957] /wall not persistent
URL: http://gna.org/bugs/?18957 Summary: /wall not persistent Project: Freeciv Submitted by: akfaew Submitted on: Wed Nov 9 17:41:32 2011 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2.3 Discussion Lock: Any Operating System: None Planned Release: ___ Details: Right now /wall sends a message only to connected players, not all players connecting during the current turn. Was this behaviour changed? If so, can it be reverted? In it's current form /wall is rather useless. ___ Reply to this item at: http://gna.org/bugs/?18957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3041] Make gtk3-client really gtk3-program
URL: http://gna.org/patch/?3041 Summary: Make gtk3-client really gtk3-program Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 08:34:52 PM EET Category: client-gtk-3.0 Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 ___ Details: This patch makes gtk3-client to be built against gtk3 and no longer gtk2. We have no gtk3-compatible freeciv theme yet, so client starts without any theme by default. I want to commit this to S2_4 regardless, as we have default gtk2-client with theme - most people who have gtk2 will use it anyway. gtk3-client is for those people only who have no gtk2 installed at all, or explicitly request for gtk3-client. ___ File Attachments: --- Date: Wed 09 Nov 2011 08:34:53 PM EET Name: Gtk3Gtk3Client.diff Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=14493 --- Date: Wed 09 Nov 2011 08:34:53 PM EET Name: Gtk3Gtk3Client-S2_4.diff Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=14494 ___ Reply to this item at: http://gna.org/patch/?3041 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3041] Make gtk3-client really gtk3-program
Update of patch #3041 (project freeciv): Depends on: = patch #2715 ___ Reply to this item at: http://gna.org/patch/?3041 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3042] Automatically select gtk3-client as one to build
URL: http://gna.org/patch/?3042 Summary: Automatically select gtk3-client as one to build Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 09:03:35 PM EET Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0, 2.5.0 ___ Details: This enables automatic selection of gtk3-client configure time if client selection is not explicitly given. S2_4 version prefers gtk2-client over gtk3-client, i.e., if both gtk2 and gtk3 development files are present, gtk2-client will be selected. TRUNK version makes gtk3-client prefered one. ___ File Attachments: --- Date: Wed 09 Nov 2011 09:03:35 PM EET Name: AutoselectGtk3.diff Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=14495 --- Date: Wed 09 Nov 2011 09:03:35 PM EET Name: AutoselectGtk3-S2_4.diff Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=14496 ___ Reply to this item at: http://gna.org/patch/?3042 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18960] Setting nation specific values for traits broken
URL: http://gna.org/bugs/?18960 Summary: Setting nation specific values for traits broken Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 10:40:21 PM EET Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0 ___ Details: Server tries to read nation specific trait value from section named %s, not from nation's section. Fix attached ___ File Attachments: --- Date: Wed 09 Nov 2011 10:40:21 PM EET Name: TraitNatSpecific.diff Size: 589B By: cazfi http://gna.org/bugs/download.php?file_id=14497 ___ Reply to this item at: http://gna.org/bugs/?18960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3043] Comparisons trait_end() - != trait_end()
URL: http://gna.org/patch/?3043 Summary: Comparisons trait_end() - != trait_end() Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 11:05:28 PM EET Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: After initial patch #3001 commit it was crashing for some people partly because critical loop comparison was trait_end() and not != trait_end() After fixing that fatal one, other similar loops remain. Attached patch takes care of those. ___ File Attachments: --- Date: Wed 09 Nov 2011 11:05:28 PM EET Name: TraitEndIter.diff Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=14498 ___ Reply to this item at: http://gna.org/patch/?3043 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3044] Get nation specific trait value directly from nation
URL: http://gna.org/patch/?3044 Summary: Get nation specific trait value directly from nation Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 11:12:10 PM EET Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Currently trait values are stored to nations, and should then be copied to player's trait struct (which copy operation is missing, btw) This makes things over-complicated (subject to initialization order of nations and players) compared to simply looking trait value from nation directly. Attached patch implements just that. ___ File Attachments: --- Date: Wed 09 Nov 2011 11:12:10 PM EET Name: TraitFromNation.diff Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=14499 ___ Reply to this item at: http://gna.org/patch/?3044 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3023] Define some road type stuff
Update of patch #3023 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3023 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3037] can_build_road()
Follow-up Comment #1, patch #3037 (project freeciv): - Updated against svn (file #14500) ___ Additional Item Attachment: File name: CanBuildRoad_3037-2.diff Size:6 KB ___ Reply to this item at: http://gna.org/patch/?3037 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3045] Road requirement type
URL: http://gna.org/patch/?3045 Summary: Road requirement type Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 11:32:49 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: This patch introduces new requirement type Road. Existing Special based road requirements in all rulesets are updated to use this new type. ___ File Attachments: --- Date: Wed 09 Nov 2011 11:32:49 PM EET Name: RoadReq.diff Size: 15kB By: cazfi http://gna.org/patch/download.php?file_id=14502 ___ Reply to this item at: http://gna.org/patch/?3045 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18963] Namespace conflict between min() callback in options.c and macro with same name
URL: http://gna.org/bugs/?18963 Summary: Namespace conflict between min() callback in options.c and macro with same name Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 11:54:07 PM EET Category: client Severity: 3 - Normal Priority: 9 - Immediate Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Microsoft Windows Planned Release: 2.3.1, 2.4.0, 2.5.0 ___ Details: Windows compilation fails because it tries to expand min() -callback from options.c as macro (complaining that it should take two arguments) Attached fix avoids namespace conflict by renaming callbacks minimum() and maximum() As a compilation fix will be committed immediately. ___ File Attachments: --- Date: Wed 09 Nov 2011 11:54:07 PM EET Name: MinNamespace.diff Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=14503 ___ Reply to this item at: http://gna.org/bugs/?18963 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18963] Namespace conflict between min() callback in options.c and macro with same name
Update of bug #18963 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?18963 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?
Follow-up Comment #3, bug #18930 (project freeciv): Sounds like bug #17616? Embarrassing. Seems like I were in the middle of writing another patch at the time and it was not convenient to switch to writing fix for the bug, and then I managed to forgot fixing it when I had time. Sine this ticket now has fix, I'll mark #17616 as duplicate, even though it's older one of the two. ___ Reply to this item at: http://gna.org/bugs/?18930 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17616] Bases not saved to (or loaded from) playerless scenario
Update of bug #17616 (project freeciv): Status:None = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #1: See bug #18930 ___ Reply to this item at: http://gna.org/bugs/?17616 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?
Update of bug #18930 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?18930 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3028] Macro to uppercase first letter of string
Follow-up Comment #4, patch #3028 (project freeciv): Ah so this isn't so much about forcing an uppercase but rather forcing a lowercase in the middle of a sentence? So that something like Mountains becomes Your engineers have converted this terrain to mountains Is that it? That way round, it shouldn't be a problem for Gaelic, we use lowercase throughout anyway except for names. ___ Reply to this item at: http://gna.org/patch/?3028 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3031] Ruleset default government
Update of patch #3031 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3031 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3028] Macro to uppercase first letter of string
Follow-up Comment #5, patch #3028 (project freeciv): Ah so this isn't so much about forcing an uppercase but rather forcing a lowercase in the middle of a sentence? Turning it that way around works in logic, but unfortunately I don't think it's technically feasible to implement that way. Oh, and I think it would cause problems with *all* western languages if there ever happens to be units with names of individuals (such as Leader units named after leader of the nation) THose should not be lowercased even in the middle of the sentence. Anyway, as you see in comment #3, I improved the patch so that now capitalization is not forced to all translations, but you (translators) can opt your translation in. Obviously Gaelic should not be opted in. Well see if this code exist for Finnish translation only. ;-) ___ Reply to this item at: http://gna.org/patch/?3028 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2380] Client - metaserver communication with curl
Update of patch #2380 (project freeciv): Category: general = client Status: In Progress = Ready For Test ___ Follow-up Comment #3: Doesn't work yet. Seems like a bug in secfile line endings handling. Turned out to be bug in this patch after all. This version works. (file #14504) ___ Additional Item Attachment: File name: ClientMetaCurl_2380-2.diff Size:10 KB ___ Reply to this item at: http://gna.org/patch/?2380 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3043] Comparisons trait_end() - != trait_end()
Follow-up Comment #1, patch #3043 (project freeciv): Could we add the usual iterator pattern to specenums? ___ Reply to this item at: http://gna.org/patch/?3043 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3036] specenum _size()
Follow-up Comment #1, patch #3036 (project freeciv): _size() might be a bit ambiguous -- it could be mistaken for the number of enumeration items, which could be different since specenums can be sparse. (I'm not sure we can easily provide the number of items.) Perhaps _array_size()? ___ Reply to this item at: http://gna.org/patch/?3036 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] State of secfile /n /r/n compatibility
Marko Lindqvist writes: [...] Only hex-editor tells me that it's different from what was received with working setup - line endings used to be '\r\n', now they are just \'n'. Code paths after we've got temporary file written are not changed, so it seems that this change in line endings is breaking things. but later in patch #2380 you write: Doesn't work yet. Seems like a bug in secfile line endings handling. Turned out to be bug in this patch after all. This version works. I was a bit worried I'd broken something when I'd messed with line endings in patch #2843. Is that patch now exonerated, or do I need to look deeper into your symptom? ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)
Follow-up Comment #36, bug #18835 (project freeciv): I've tested the latest patches on trunk r20527. Results: * Closing individual meeting tab with ESC trouble (comment #26) is fixed * Detaching individual meeting tab trouble (comment #30) is fixed * Detaching overall Diplomacy [N] tab from main notebook (comment #25) still has same trouble as before, I'm afraid, including the segfault. * New bug (may have existed in previous patch): clicking the x button on the overall Diplomacy [N] tab has no effect. About comment #25: from your comment #31, I think perhaps I didn't explain the steps to reproduce clearly enough. They are: * Meet with nation A (via Nations Diplomacy Meet), bringing up a Diplomacy [1] tab containing a A sub-tab. * Detach the Diplomacy [1] tab from the main notebook by double-clicking on the Diplomacy [1] label. This gives a separate window with a Cancel all meetings button (like file #14446, only with a slightly different layout, of course). * Close this new window with the window manager's X button. There is now no Diplomacy [1] window or tab, and no A window or tab. * Try again to meet with nation A: nothing happens. * Try to meet with nation B: segfault. ___ Reply to this item at: http://gna.org/bugs/?18835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3033] Send more messages to threaded ai threads
Update of patch #3033 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3033 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] State of secfile /n /r/n compatibility
On 10 November 2011 03:25, Jacob Nevins 0jacobnk.fc...@chiark.greenend.org.uk wrote: Marko Lindqvist writes: Turned out to be bug in this patch after all. This version works. I was a bit worried I'd broken something when I'd messed with line endings in patch #2843. Is that patch now exonerated, or do I need to look deeper into your symptom? Symptoms were entirely explained by my own error; not rewinding the stream - line endings (or any contents of file) do not matter when you try to read only locations after eof. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3034] Rename current registry.[ch] as registry_ini.[ch]
Update of patch #3034 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3034 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
