[Freeciv-Dev] [bug #20447] 'trade_routes_color' may be used uninitialized

2013-01-23 Thread Marko Lindqvist
Update of bug #20447 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20447

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3607] Suggested soundset dialog for gtk2-client

2013-01-23 Thread Marko Lindqvist
Update of patch #3607 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3607

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20446] fixes for debian build system [PATCH]

2013-01-23 Thread Marko Lindqvist
Update of bug #20446 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20446

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20383] No city_style for Novgorodian

2013-01-23 Thread Marko Lindqvist
Update of bug #20383 (project freeciv):

  Status:None = Duplicate  
 Assigned to:mixcoatl = cazfi  
 Open/Closed:Open = Closed 

___

Follow-up Comment #1:

This was fixed in patch #2014

___

Reply to this item at:

  http://gna.org/bugs/?20383

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20428] 'g_thread_init' is deprecated

2013-01-23 Thread Marko Lindqvist
Update of bug #20428 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 

___

Follow-up Comment #4:

 Does attached patch help?

I assume so and close this ticket now that patch has been committed. Reopen if
needed.

___

Reply to this item at:

  http://gna.org/bugs/?20428

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20451] civ2civ3 and Horse Pikemen flags

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20451

 Summary: civ2civ3 and Horse  Pikemen flags
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 23 Jan 2013 04:01:30 PM EET
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Current TRUNK civ2civ3 gives warning about Pikemen flag of Destroyer. This
is simply because when combat bonuses framework was introduced, I didn't
notice that civ2civ3 used Horse/Pikemen flags for Submarine/Destroyer, and
didn't reimplement it as combat bonus.

But I think this was not quite right to begin with (affecting S2_3  S2_4
rulesets). Horse flag is given, in addition to Submarine, to actual horse
units. This means that Destroyer with Pikemen flag will get double bonus
against horses (battle between them can take place if destoryer is in a city).




___

Reply to this item at:

  http://gna.org/bugs/?20451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3613] Killcitizen not move_type dependant

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3613

 Summary: Killcitizen not move_type dependant
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 23 Jan 2013 04:11:49 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Killcitizen is one of the remaining places for which unit move_type is needed
outside ai code.

Attached patch makes killcitizen setting boolean instead of list of
move_types. New unit class flag KillCitizen in ruleset determines which
units do kill citizens if setting is enabled. For all of the supplied rulesets
this flag is given to unit classes so that there's no gameplay change if
default rules are being used (land moving units have the flag)

It would make sense to make some adjustments to alien ruleset in future
tickets taking advantage of the new ruleset power of determining killcitizen
units (Amphibious units at least could kill, Burrowing on the other hand might
not)




___

File Attachments:


---
Date: Wed 23 Jan 2013 04:11:49 PM EET  Name: KillCitizeinNotMoveType.patch 
Size: 17kB   By: cazfi

http://gna.org/patch/download.php?file_id=17002

___

Reply to this item at:

  http://gna.org/patch/?3613

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20451] civ2civ3 and Horse Pikemen flags

2013-01-23 Thread Marko Lindqvist
Update of bug #20451 (project freeciv):

  Status: In Progress = Ready For Test 
 Planned Release: = 2.5.0  

___

Follow-up Comment #1:

Patch for TRUNK.

(file #17003)
___

Additional Item Attachment:

File name: DestroyerCombatBonus.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?20451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20451] civ2civ3 and Horse Pikemen flags

2013-01-23 Thread Marko Lindqvist
Follow-up Comment #2, bug #20451 (project freeciv):

I've now made versions with Horse flag removed from all units but Destroyer
for 2.3 and 2.4 available with freeciv-modpack.

For my own versions, I've added letter to the end of version number reserving
bumps to numerical part to upstream (bardo)

___

Reply to this item at:

  http://gna.org/bugs/?20451

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19922] Too easy to lose boats when city lost to migration?

2013-01-23 Thread Marko Lindqvist
Follow-up Comment #2, bug #19922 (project freeciv):

 previously, I think the only time a city could disappear with
 units still in it would be build-settler-at-size-1

I've seen AI city to starve to death, but that's rather special case of
AI-class-stupidity city placement (middle of arctic mountain range)

___

Reply to this item at:

  http://gna.org/bugs/?19922

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1449] Don't exit the server on ruleset loading failure

2013-01-23 Thread Marko Lindqvist
Update of patch #1449 (project freeciv):

Category:rulesets = general
Priority:   1 - Later = 5 - Normal 

___

Follow-up Comment #1:

Making this metaticket of recovering from ruleset loading failures.

Some arrangement work for this has already gone in. Notably main ruleset
loading functions return boolean telling if loading succeeded and always
return with sane ruleset data (they revert to loading default ruleset)

___

Reply to this item at:

  http://gna.org/patch/?1449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1449] Don't exit the server on ruleset loading failure

2013-01-23 Thread Marko Lindqvist
Update of patch #1449 (project freeciv):

  Depends on: = patch #3612


___

Reply to this item at:

  http://gna.org/patch/?1449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1449] Don't exit the server on ruleset loading failure

2013-01-23 Thread Marko Lindqvist
Update of patch #1449 (project freeciv):

  Depends on: = patch #3363


___

Reply to this item at:

  http://gna.org/patch/?1449

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [patch #3596] Network packet type field to 16 bit value in HACKING

2013-01-23 Thread Marko Lindqvist
On 20 January 2013 09:43, Marko Lindqvist cazf...@gmail.com wrote:

  You still have not told me which kind of supercomputers / crap
 network connection combo you are using so that network is the
 bottleneck and not all the processing.

See pepeto's comment to patch #1446 about how small amount of actually
transmitted data can lead to huge processing on client end:
http://gna.org/patch/?1446#comment2


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2265] [metaticket] citizen nationality

2013-01-23 Thread Marko Lindqvist
Follow-up Comment #11, patch #2265 (project freeciv):

 If so, would need some way of asking permission from the
 receiver, which would be tricky UI-wise as pop-ups are already
 problematic, and we don't want donors abusing such pop-ups
 maliciously during a time-critical situation.

What about just sending an event (chatline/messagebox) to receiver at the time
when donor tries to add settler. Then the receiver can go to city dialog when
ever it suits him/her for accepting new citizens with a button added there.
Problem is what happens to settler meanwhile. Should donor lose it
immediately? Permanently (even if receiver declines)?

___

Reply to this item at:

  http://gna.org/patch/?2265

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2829] Text data files with native line endings

2013-01-23 Thread Marko Lindqvist
Update of patch #2829 (project freeciv):

  Status:  Ready For Test = None   
 Planned Release:   2.5.0 =


___

Reply to this item at:

  http://gna.org/patch/?2829

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2844] Two boolean player_is_at_war functions for 2.4 r 20006.

2013-01-23 Thread Marko Lindqvist
Follow-up Comment #4, patch #2844 (project freeciv):

 What kind of helper functions not used by freeciv itself at all,
 but benefiting some custom ai module, we add? Any opinions?

Ok, I've now thought this a bit, and if such ai module utility functions are
to be added, they should not be part of common source files. Instead we could
add directory ai/support/ to which to collect such stuff. Then we could
compile those parts only when configured for custom ai module support.

___

Reply to this item at:

  http://gna.org/patch/?2844

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3614] Minimum native start area

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3614

 Summary: Minimum native start area
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 23 Jan 2013 11:46:47 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add terrain.ruleset setting for minimum native area reachable by initial
startunit. Setting is 0 (not used) for all the rulesets except for alien where
it is 15. For other rulesets always present checks for island size work
better, but in alien ruleset initial units are limited to certain land
terrains only. Until this patch player has occasionally started alien ruleset
with unplayable small reachable area, including extreme cases of just the one
tile where initial units stand.



___

File Attachments:


---
Date: Wed 23 Jan 2013 11:46:47 PM EET  Name: MinNativeArea.patch  Size: 8kB  
By: cazfi

http://gna.org/patch/download.php?file_id=17004

___

Reply to this item at:

  http://gna.org/patch/?3614

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3606] Configure check for intptr_t

2013-01-23 Thread Marko Lindqvist
Update of patch #3606 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3606

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3615] Autoconf requirement to 2.61

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3615

 Summary: Autoconf requirement to 2.61
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 24 Jan 2013 12:13:34 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Bump minimum autoconf version requirement to 2.61 and remove support code for
older versions from configure.ac.



___

File Attachments:


---
Date: Thu 24 Jan 2013 12:13:34 AM EET  Name: MinAC2_61.patch  Size: 4kB   By:
cazfi

http://gna.org/patch/download.php?file_id=17005

___

Reply to this item at:

  http://gna.org/patch/?3615

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3616] Give ransom from multiple barbarian leaders

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3616

 Summary: Give ransom from multiple barbarian leaders
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 24 Jan 2013 12:43:10 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Quite a corner case, but I had leaders from two barbarian groups stacked.
There was no other units in the tile, but neither of them was alone in the
tile, so killing them gave no ransom.

I've not listed this as bug as this is exactly how it's defined. Only leader
alone in the tile will give the ransom.

Attached patch is a rule change that as long as tile has no other units than
barbarian leaders, even if there is several of them, ransom is paid, and for
each leader.



___

File Attachments:


---
Date: Thu 24 Jan 2013 12:43:10 AM EET  Name: MultiLeaderRansom.patch  Size:
3kB   By: cazfi

http://gna.org/patch/download.php?file_id=17006

___

Reply to this item at:

  http://gna.org/patch/?3616

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20452] Unit can convert in bad circumstances

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20452

 Summary: Unit can convert in bad circumstances
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 24 Jan 2013 01:39:46 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.4, 2.4.0, 2.5.0

___

Details:

Unit can be converted to another type even when
1) target unit cannot exist in the tile
2) target unit has not enough space for the cargo

Fix for these attached.


This makes cargo space check equivalent to what's being done in case of unit
upgrade. But this is still buggy for both upgrade and convert case; there's no
check for cargo type. If there's space for 2 infantry units, that pass as
transport capacity for 2 aircraft.



___

File Attachments:


---
Date: Thu 24 Jan 2013 01:39:46 AM EET  Name: ConvertTerrainCheck.patch  Size:
776B   By: cazfi

http://gna.org/bugs/download.php?file_id=17007

___

Reply to this item at:

  http://gna.org/bugs/?20452

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3617] Rename fc_svnrev_gen.h.in as fc_svnrev_gen.h.tmpl

2013-01-23 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3617

 Summary: Rename fc_svnrev_gen.h.in as fc_svnrev_gen.h.tmpl
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 24 Jan 2013 02:02:11 AM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Suffix .in usually means input file for configure substitutions.
fc_svnrev_gen.h.in is not such a file. Rename it as fc_svnrev_gen.h.tmpl to
avoid confusion.

Actual rename of the file should be made prior to applying attached patch.



___

File Attachments:


---
Date: Thu 24 Jan 2013 02:02:11 AM EET  Name: SvnrevTmpl.patch  Size: 2kB   By:
cazfi

http://gna.org/patch/download.php?file_id=17008

___

Reply to this item at:

  http://gna.org/patch/?3617

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20392] cast from pointer to integer of different size

2013-01-23 Thread Jacob Nevins
Update of bug #20392 (project freeciv):

 Planned Release: = 2.4.0-beta2, 2.5.0 


___

Reply to this item at:

  http://gna.org/bugs/?20392

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev