[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #5, patch #3815 (project freeciv): The attached files provide one possible adjustment to the static helptexts for S2_4 and trunk. In trunk, I did not remove the phrases Planet's radiation makes it impossible for Earthly organisms to survive here., Burrowing units are unable to burrow through these mountains., or No ship without special equipment can enter. for the alien ruleset as they were phrased in the negative, and I thought they added a nice flavour and sense of environment beyond their value as indicators of nativity. Similarly, one could add Trireme captains fear swamping by the heavy seas, and will not enter. or so to the Deep Ocean texts for classic/experimental/multiplayer, enriching the storyline of the ruleset without overloading the nativity data provided by this patch. (file #17723, file #17724) ___ Additional Item Attachment: File name: quick-terrain-nativity-static-help-changes.S2_4.patch Size:4 KB File name: quick-terrain-nativity-static-help-changes.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3740] Support City range requirements for tile properties
Follow-up Comment #2, patch #3740 (project freeciv): See also patch #3323. ___ Reply to this item at: http://gna.org/patch/?3740 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Can I un-static function?
I made scalable minimap for qt-client ( default is integer only, that one is fully scalable), but I had to draw viewport manually. For that I had to convert gui to overview position, but that function is static ( in overview_common.c), so I used gui to map conversion and then map to overview ( but I added gui to map conversion to mapview.cpp in qt ) But now I think it would be much easier if I could just make gui_to_overview_pos non-static. So should I do it or not ? -- mir3x ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3843] Donate citizens of own nationality to allies' cities
URL: http://gna.org/patch/?3843 Summary: Donate citizens of own nationality to allies' cities Project: Freeciv Submitted by: jtn Submitted on: Tue Apr 9 21:50:01 2013 Category: general Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Idea split out from patch #2265. Original text from me: Currently you can't add to someone else's city with Settlers etc, even if you're allies. But what if you could, and the nationality of the new citizen was that of the unit? Could be an interesting peacetime dynamic -- receiver immediately gets the benefit of an extra citizen, but donor gets reduced incite cost, increased migration chance (etc) should relations between the nations change. (See comments in patch #2265 for further elaboration.) ___ Reply to this item at: http://gna.org/patch/?3843 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2265] [metaticket] citizen nationality
Update of patch #2265 (project freeciv): Status: In Progress = Done Open/Closed:Open = Closed ___ Follow-up Comment #13: OK, it seems this idea has legs, so I've split it out into its own ticket (patch #3843). Back to this one: the basic nationality mechanism is complete for 2.4.x, and open tickets that remain are about doing more things with it, which will not be in 2.4.x. So I don't see any point keeping this ticket open. (If your favourite idea in the comments doesn't have its own ticket, do raise a new one.) ___ Reply to this item at: http://gna.org/patch/?2265 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2265] [metaticket] citizen nationality
Update of patch #2265 (project freeciv): Dependency Removed: = patch #2366 ___ Reply to this item at: http://gna.org/patch/?2265 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2265] [metaticket] citizen nationality
Update of patch #2265 (project freeciv): Dependency Removed: = patch #2367 ___ Reply to this item at: http://gna.org/patch/?2265 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2367] [citizens13] poison citizens of the city owner
Update of patch #2367 (project freeciv): Planned Release: 2.4.0 = 2.5.0 ___ Follow-up Comment #6: Don't think this is going to make 2.4.0. ___ Reply to this item at: http://gna.org/patch/?2367 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2367] [citizens13] poison citizens of the city owner
Follow-up Comment #7, patch #2367 (project freeciv): (in that from discussion I think it's going to want to be optional and need effects and what have you, so will break ruleset format freeze) ___ Reply to this item at: http://gna.org/patch/?2367 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17680] assertion 'vsystem-levels level' failed
Update of bug #17680 (project freeciv): Status:None = Works For Me Open/Closed:Open = Closed ___ Follow-up Comment #6: Well, we didn't have any leads, it seems to have gone away, and we've made fixes in this area. Doesn't seem any point keeping this ticket open (closing it will doubtless provoke the error in new code). ___ Reply to this item at: http://gna.org/bugs/?17680 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #8, patch #3815 (project freeciv): I committed the helptext generation part, but would really like more opinions of the changes to static texts. Old description is redundant, but is it still something that makes people to realize the difference between Ocean and Deep Ocean while they are less likely to spot that unit class lists differ? ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20731] startpos_iter_init(): warning: type-punning to incomplete type might break strict-aliasing rules
URL: http://gna.org/bugs/?20731 Summary: startpos_iter_init(): warning: type-punning to incomplete type might break strict-aliasing rules Project: Freeciv Submitted by: jtn Submitted on: Tue Apr 9 22:23:00 2013 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: In passing in bug #20057, David Fernandez observed (2012 Aug 28): --- [...] now I get a different error: trunk: cc1: warnings being treated as errors map.c: In function ‘startpos_iter_init’: map.c:1608: warning: type-punning to incomplete type might break strict-aliasing rules make[4]: *** [map.lo] Error 1 S2_4: cc1: warnings being treated as errors map.c: In function ‘startpos_iter_init’: map.c:1558: warning: type-punning to incomplete type might break strict-aliasing rules make[4]: *** [map.lo] Error 1 (He said I'm using ubuntu 9.04 that I can no longer update, so presumably the GCC version was whatever was current in that release.) The line pointed to on trunk at the time was (void) nation_iter_init((struct nation_iter *) iter-nation_iter); Just raising this so we don't lose it. I've not tried to reproduce the warning -- maybe it's been resolved in the months since, in which case close the ticket. (But there do seem to be shenanigans in this area; see startpos_iter_sizeof() for instance.) ___ Reply to this item at: http://gna.org/bugs/?20731 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3805] Allow paratroopers to land on transport
Update of patch #3805 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3805 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20666] Disaster flood requires river special
Update of bug #20666 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20666 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3836] Documentation update for requirements
Update of patch #3836 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3836 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3835] Negated requirements sanity checking improvements
Follow-up Comment #9, patch #3835 (project freeciv): Reading the patch once more, I noticed that for requirements to be considered opposites they should have same 'survives'. I'm 95% sure 'survives' shouldn't matter here. Of course, 5% is still a big uncertainty. ___ Reply to this item at: http://gna.org/patch/?3835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20507] Barbarian nations in unknown group in civ2 ruleset
Update of bug #20507 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #3: Attached patch copies relevant bits of barbarians/pirates.ruleset bodily into civ2/nations.ruleset to quell the warnings. (civ2 nations seem to have only two leaders each, but I wasn't sure what the right thing was for barbarian nations, so I kept all the leaders.) (file #17732) ___ Additional Item Attachment: File name: trunk-S2_4-civ2-barbarians.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?20507 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20626] Client crashes with GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
Follow-up Comment #2, bug #20626 (project freeciv): When I run with -d 3 the server's last words are ... 3: sending packet type=PACKET_UNIT_SHORT_INFO(64) len=8 to jtn 3: attack:20, defense:112, attack firepower:1, defense firepower:1 3: Teleported Pirate Barbarian Leader from (209,103) to Garbów 3: attack:70, defense:0, attack firepower:1, defense firepower:1 Segmentation fault (core dumped) (I vaguely wondered if this could be an instance of bug #20728, but it appears not -- applying the patch doesn't stop the segfault.) ___ Reply to this item at: http://gna.org/bugs/?20626 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20626] Client crashes with GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
Follow-up Comment #3, bug #20626 (project freeciv): Being about transport destruction and Barbarian Leader teleporting away, this sounds exactly like bug #20699 - except that that was introduced to S2_4 / TRUNK only and never existed in S2_3. Maybe there is something a bit alike in S2_3 implementation of wipe_unit()? ___ Reply to this item at: http://gna.org/bugs/?20626 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20626] Client crashes with GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
Follow-up Comment #4, bug #20626 (project freeciv):
Here's a backtrace with head-of-S2_3 (r22707) compiled with -O0 -g.
#0 0x00427532 in server_remove_unit (punit=0x3764af0)
at unittools.c:1434
pcargo_iter = 0x1f
pcargo = 0x6c657661726143
ptile = 0x7f2add0cf028
pcity = 0x0
phomecity = 0x0
ptrans = 0x259d480
__FUNCTION__ = server_remove_unit
#1 0x004279c3 in unit_lost_with_transport (pplayer=0x35eb010,
pcargo=0x3764af0, ptransport=0xab36f0, killer=0x3588550)
at unittools.c:1537
No locals.
#2 0x00427f1a in wipe_unit (punit=0x3765030, count_lost=true,
killer=0x3588550) at unittools.c:1618
ptransport = 0x0
pcargo = 0x3764af0
pcargo_numbers = 0x7fffb9190bd0
pcargo_index = 0
pcargo_size = 3
pcity = 0x3763070
ptile = 0x329e758
pplayer = 0x35eb010
putype_save = 0xab36f0
drowning = 3
homecity_id = 0
__FUNCTION__ = wipe_unit
#3 0x004ea490 in unit_attack_handling (punit=0x3765030,
pdefender=0x3755bb0) at unithand.c:1131
loser_link = [l tgt=tile x=209
y=103]Caravel[/l] 00 00 00321363_ 00 00 00 00 00 01 00 00 00 30 00 00 00220]u
03 00 00 00 00p 16 31271377177 00 00260347) 03 00 00 00 00240 16 31271377177 00
00ЧR 00 00 00 00 00260347) 03 00 00 00 00 60Pv 03 00 00 00 00260347) 03 16 00
00 00220]u 03 00 00 00
winner_link = [l tgt=unit id=1696 name=Alpine Troops
/] 00 00 00p 00 00 00 01 00 00 00n 00 00 00 24 00 00 00225
33350a240230333=+I(320Ma375=d223M6331d303?'233l262311353? 34 00 00 00n 00 00
00 24 00 00 00n 00 00 00@ 16 31271377177 00 00357235R 00 00 00 00
ploser = 0x3765030
pwinner = 0x3755bb0
pcity = 0x3cb355c4e8ff0e2f
moves_used = 6
def_moves_used = 0
old_unit_vet = 0
old_defender_vet = 1
vet = 1
winner_id = 1696
def_tile = 0x329e7b0
pplayer = 0x35eb010
__FUNCTION__ = unit_attack_handling
#4 0x004eb591 in unit_move_handling (punit=0x3765030,
pdesttile=0x329e7b0, igzoc=false, move_diplomat_city=false)
at unithand.c:1461
victim = 0x3755bb0
pplayer = 0x35eb010
pcity = 0x371e160
__FUNCTION__ = unit_move_handling
#5 0x0045b92d in ai_unit_attack (punit=0x3765030, ptile=0x329e7b0)
at aitools.c:1018
bodyguard = 0x0
sanity = 1784
alive = false
__FUNCTION__ = ai_unit_attack
#6 0x0045b9eb in ai_unit_move_or_attack (punit=0x3765030,
ptile=0x329e7b0, path=0x2f4ad20, step=3) at aitools.c:1038
No locals.
#7 0x0045f10e in adv_unit_execute_path (punit=0x3765030,
path=0x2f4ad20) at advgoto.c:100
_plr_ = 0x35eb010
ptile = 0x329e7b0
id = 1784
is_ai = true
i = 3
__FUNCTION__ = adv_unit_execute_path
#8 0x0045ef03 in adv_follow_path (punit=0x3765030, path=0x2f4ad20,
ptile=0x329e7b0) at advgoto.c:57
old_tile = 0x329e7b0
activity = ACTIVITY_IDLE
alive = false
#9 0x00443b99 in ai_amphibious_goto_constrained (ferry=0x3765030,
passenger=0x3764cb0, ptile=0x329e7b0, parameter=0x7fffb9191220)
at aiferry.c:584
alive = true
pplayer = 0x35eb010
pfm = 0x3560cd0
path = 0x2f4ad20
__FUNCTION__ = ai_amphibious_goto_constrained
#10 0x00444095 in aiferry_goto_amphibious (ferry=0x3765030,
passenger=0x3764cb0, ptile=0x329e7b0) at aiferry.c:653
parameter = {land = {start_tile = 0x329a4a8, moves_left_initially = 3,
fuel_left_initially = 1, move_rate = 3, fuel = 1,
owner = 0x35eb010, uclass = 0xafcbf0, unit_flags = {
vec = 00b 00 00 00 00 00}, omniscience = true,
get_MC = 0x61f0ef normal_move_unit, unknown_MC = 6,
get_TB = 0x61fa1f no_intermediate_fights, get_EC = 0,
can_invade_tile = 0x5ed342 player_can_invade_tile,
get_zoc = 0x5fd504 is_my_zoc, is_pos_dangerous = 0,
get_moves_left_req = 0, get_costs = 0, data = 0x0}, sea = {
start_tile = 0x329a4a8, moves_left_initially = 9,
fuel_left_initially = 1, move_rate = 9, fuel = 1,
owner = 0x35eb010, uclass = 0xafcc80, unit_flags = {
vec = 00 00 00 00b 00 00}, omniscience = true,
get_MC = 0x61ef3e sea_overlap_move, unknown_MC = 6,
get_TB = 0x61f9c6 no_fights, get_EC = 0,
can_invade_tile = 0x5ed342 player_can_invade_tile, get_zoc = 0,
is_pos_dangerous = 0, get_moves_left_req = 0, get_costs = 0,
data = 0x3765030}, land_scale = 9, sea_scale = 3, combined = {
start_tile = 0x329a4a8, moves_left_initially = 27,
fuel_left_initially = 1, move_rate = 27, fuel = 1,
owner = 0x35eb010, uclass = 0xafcc80, unit_flags = {
vec = 00 00 00 00 00 00 00},
[Freeciv-Dev] [patch #3835] Negated requirements sanity checking improvements
Follow-up Comment #10, patch #3835 (project freeciv): I'm inclined to agree that survives shouldn't matter (the code was written to compare the code structures, rather than with careful semantic analysis). That said, I can think of a couple cases where one might use this: a) Creating a condition that applies only if some Wonder (Great or Small) has been both built and subsequently destroyed (e.g. nobody can build National Libraries until someone destroys the Library of Alexandria). b) Creating a condition that applies only if some nation has been in the game and then subsequently been destroyed (e.g. nobody can build Janissaries until the Byzantines have been thoroughly conquered (but still have remaining citizens in cities (nationality condition)). [Note: this depends on someone addressing patch #1339 ] I don't know if either of these are at all likely, or if there are other future semantics where opposing survives may be semantically meaningful. Even if preserved, I imagine this class of requirement would be much more useful for specific scenarios than for a general ruleset intended to be played with random maps and nations. In the event that survives is not compared in are_requirements_opposites(), should it not also be removed from are_requirements_equal()? (Anyone contemplating this should investigate the callers: it may be that the packets_gen stuff complicates this and requires different semantics than the rssanity stuff.) ___ Reply to this item at: http://gna.org/patch/?3835 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3804] Enabling restricted air transport
Follow-up Comment #20, patch #3804 (project freeciv): Update to the experimental ruleset patch to take into account changes in README.ruleset_experimental after revision 22705. (file #17733) ___ Additional Item Attachment: File name: experimental-air-transport+post22705.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?3804 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20626] Client crashes with GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed
Follow-up Comment #5, bug #20626 (project freeciv): Still not sure what's going on, but some facts * Sunk boat is a Caravel belonging to Blackbeard (Pirate) ** Was sunk by Dravya Shah (Nepali) * At [l tgt=tile x=209 y=103 /] * Three ex-cargo at time of crash (IDs 1785, 1786, 1787 -- looking at pre-crash state, probably Barbarian Leader, Marines, and Dragoons) Oddly, pcargo seems corrupted (first few entries, e.g. utype, seem garbage) ___ Reply to this item at: http://gna.org/bugs/?20626 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
