[Freeciv-Dev] [patch #4584] Qt client: Add mnemonic support to the spy action chooser dialog.
Update of patch #4584 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4584 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4585] Gtk clients: Display an action's UI name
Update of patch #4585 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4585 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4586] Make the UI name of Industrial Espionage capitalized like the rest
Update of patch #4586 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21766] Spy action button label text isn't transaltor friendly
URL: http://gna.org/bugs/?21766 Summary: Spy action button label text isn't transaltor friendly Project: Freeciv Submitted by: sveinung Submitted on: Fri 07 Mar 2014 04:54:08 PM UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: sveinung Originator Email: Open/Closed: Open Release: 2.6.0 Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: The spy action button label text of the Qt and the Gtk clients include the probability of success. This is added by appending it to the right of the label. Languages like Arabic and Hebrew read right to left. They would therefore probably want the chance of success on the left side of the string. Attached patch changes the insertion of the probability to use a %s in stead of hard coding the location. It can then be set by translators using positional specifiers. ___ File Attachments: --- Date: Fri 07 Mar 2014 04:54:08 PM UTC Name: 0001-Let-translators-specify-where-in-the-label-on-a-spy-.patch Size: 14kB By: sveinung http://gna.org/bugs/download.php?file_id=20274 ___ Reply to this item at: http://gna.org/bugs/?21766 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21766] Spy action button label text isn't translator friendly
Update of bug #21766 (project freeciv): Summary: Spy action button label text isn't transaltor friendly = Spy action button label text isn't translator friendly ___ Reply to this item at: http://gna.org/bugs/?21766 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
URL: http://gna.org/bugs/?21767 Summary: server crash while testing s2_5 alpha Project: Freeciv Submitted by: bardo Submitted on: vie 07 mar 2014 17:52:33 UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: To reproduce, load this savegame where timeout is enabled, and it always crashes for me at end of turn 89. The log shows: 3: in resolve_city_emergency() [aicity.c::839]: Emergency in Barcelona (content, angry0, unhap0 food-5, prod-2) 3: in resolve_city_emergency() [aicity.c::846]: Barcelona taking over Bilbao square in (53, 59) 3: in resolve_city_emergency() [aicity.c::846]: Barcelona taking over Madrid square in (50, 57) 3: in resolve_city_emergency() [aicity.c::883]: Emergency in Barcelona remains unresolved Then Violación de segmento (`core' generado) I'd like to play a game in order to test this ruleset with v2.5 before it is released. Please, tell me which revision would be good for such test. ___ File Attachments: --- Date: vie 07 mar 2014 17:52:33 UTC Name: S2_5-rev24626-civ2civ3-T0089-Y-0275-auto.sav.bz2 Size: 78kB By: bardo http://gna.org/bugs/download.php?file_id=20275 ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4568] sdl2-client theme
Update of patch #4568 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4568 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
Follow-up Comment #1, bug #21767 (project freeciv): Which revision you have been using? Bug #21733, fixed in revision 24620 for S2_5, has been causing a lot of AI crashes. ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
Update of bug #21767 (project freeciv): Category:None = ai Status:None = Confirmed ___ Follow-up Comment #2: I can reproduce the crash with latest revision. Investigating. ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
Update of bug #21767 (project freeciv): Status: Confirmed = Ready For Test Planned Release: = 2.4.3, 2.5.0, 2.6.0 ___ Follow-up Comment #3: - Fix. This time I checked all the can_unit_attack_tile() callers, to completely resolve what is the biggest blunder I've made in my 17 years of freeciv development. (file #20276) ___ Additional Item Attachment: File name: BoolCanAttack.patchSize:2 KB ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
Follow-up Comment #4, bug #21767 (project freeciv): Another savegame (from different game) with similar crash, if it helps. I'm using S2_5-rev24626. I added it to savegame name. Log: 3: in resolve_city_emergency() [aicity.c::839]: Emergency in Onondaga (content, angry0, unhap1 food-4, prod9) 3: in resolve_city_emergency() [aicity.c::846]: Onondaga taking over Teyagon square in (70, 33) 3: in resolve_city_emergency() [aicity.c::846]: Onondaga taking over Teyagon square in (71, 33) 3: in resolve_city_emergency() [aicity.c::866]: Emergency in Onondaga resolved 3: in map_calculate_borders() [maphand.c::2021]: map_calculate_borders() 3: in map_calculate_borders() [maphand.c::2029]: map_calculate_borders() workers 3: in unit_versus_unit() [unittools.c::248]: attack:60, defense:33, attack firepower:1, defense firepower:1 (file #20277) ___ Additional Item Attachment: File name: S2_5-rev24626-civ2civ3-T0088-Y-0300-auto.sav.bz2 Size:83 KB ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21767] server crash while testing s2_5 alpha
Follow-up Comment #5, bug #21767 (project freeciv): hehe, you were faster to fix it than me to upload the 2nd savegame. I'll play my test game with this patch. ___ Reply to this item at: http://gna.org/bugs/?21767 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
Hi! Freeciv-Web is now build on Travis CI upon every commit to git. I hope that Travis CI will make it easy to detect bugs early, and make it easier to keep Freeciv and Freeciv-web in sync. https://travis-ci.org/freeciv/freeciv-web Travis CI could be something to consider for Freeciv as well, as this is a free service for open source projects. Regards, Andreas ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
I'm trying to add patch BoolCanAttack patch from bug #21767 to freeciv-web, but any attempt to run it causes this in the server side: 1: ERROR: Unable to parse packet: {type:4,usern:cazfi,capability:+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b,version_label:-devjor_versionminominor_versio,pa,patch_veh_vers:99,:99,port:5556} - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
On 7 March 2014 22:06, Marko Lindqvist cazf...@gmail.com wrote: I'm trying to add patch BoolCanAttack patch from bug #21767 to freeciv-web, but any attempt to run it causes this in the server side: 1: ERROR: Unable to parse packet: {type:4,usern:cazfi,capability:+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b,version_label:-devjor_versionminominor_versio,pa,patch_veh_vers:99,:99,port:5556} - ML It also seems that freeciv revision has been updated without updating the ruleset (at least not in every respect). I should document the procedure of freeciv server updates. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
On Fri, 7 Mar 2014, Marko Lindqvist wrote: I'm trying to add patch BoolCanAttack patch from bug #21767 to freeciv-web, but any attempt to run it causes this in the server side: 1: ERROR: Unable to parse packet: {type:4,usern:cazfi,capability:+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b,version_label:-devjor_versionminominor_versio,pa,patch_veh_vers:99,:99,port:5556} It seems like the packet PACKET_SERVER_JOIN_REQ is sent incorrectly. This is the first network packet sent from Freeciv-web from Javascript in the browser as a WebSocket message to nginx. Nginx will then proxy this packet to freeciv-proxy, which will then send it to the Freeciv C server, which is reporting that it isn't able to parse the packet. So somewhere on this path the packet becomes broken, as you see that several characters are missing in the packet. I haven't seen this problem before. It doesn't seem to be related to the BoolCanAttack patch. As there are missing characters from the packet, I think that it is network related. Has Freeciv-web worked correctly at some point previously, then suddenly you got this packet problem? I would think that the easiest way to setup a clean Freeciv-web environment is to setup a virtual image using Vagrant. It should be quite fast and work in a consistent way every time. I would be happy to help you set up Freeciv-web with Vagrant, as I don't think you will have this problem there. The Vagrant setup is described here: https://github.com/freeciv/freeciv-web Regards, Andreas ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
On Fri, 7 Mar 2014, Marko Lindqvist wrote: On 7 March 2014 22:06, Marko Lindqvist cazf...@gmail.com wrote: I'm trying to add patch BoolCanAttack patch from bug #21767 to freeciv-web, but any attempt to run it causes this in the server side: 1: ERROR: Unable to parse packet: {type:4,usern:cazfi,capability:+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b,version_label:-devjor_versionminominor_versio,pa,patch_veh_vers:99,:99,port:5556} - ML It also seems that freeciv revision has been updated without updating the ruleset (at least not in every respect). I should document the procedure of freeciv server updates. Yes, please document the procedure. Any things we can do to make this process easier I would appreciate. I have probably forgotten some things when doing the latest svn update. Thanks! Regards, Andreas ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] Continuous integration for Freeciv-Web on Travis CI
On 7 March 2014 22:26, Andreas Røsdal andre...@pvv.ntnu.no wrote: On Fri, 7 Mar 2014, Marko Lindqvist wrote: I'm trying to add patch BoolCanAttack patch from bug #21767 to freeciv-web, but any attempt to run it causes this in the server side: 1: ERROR: Unable to parse packet: {type:4,usern:cazfi,capability:+Freeciv.Web.Devel-2.l-2.6-2014.Mar.05b,version_label:-devjor_versionminominor_versio,pa,patch_veh_vers:99,:99,port:5556} It seems like the packet PACKET_SERVER_JOIN_REQ is sent incorrectly. This is the first network packet sent from Freeciv-web from Javascript in the browser as a WebSocket message to nginx. Nginx will then proxy this packet to freeciv-proxy, which will then send it to the Freeciv C server, which is reporting that it isn't able to parse the packet. So somewhere on this path the packet becomes broken, as you see that several characters are missing in the packet. I haven't seen this problem before. It doesn't seem to be related to the BoolCanAttack patch. As there are missing characters from the packet, I think that it is network related. Has Freeciv-web worked correctly at some point previously, then suddenly you got this packet problem? Even reverting back to the previous commit I've done myself does not help, so this seems like something that's changed in my system rather than in freeciv-web. It's not missing characters, but more like parts of the string get written second time over the correct string. For example Devel-2. + l-2.6-2014 Anyway, I recommend not going to production with current version without BoolCanAttack.patch as the AI is crashing very often in current HEAD. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4574] Modpack type Musicset
Update of patch #4574 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4574 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4560] Change order of Worker and Migrant in civ2civ3
Update of patch #4560 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4560 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21738] Updated information not sent to clients when lua adds base or road
Update of bug #21738 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21738 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4562] Soundtrack 0.1
Follow-up Comment #6, patch #4562 (project freeciv): I've created mqtx musicset as external modpack at first. First version is now available with freeciv modpack installer. It requires current freeciv trunk HEAD + patch #4545 to set tags in ruleset side to those it uses. ___ Reply to this item at: http://gna.org/patch/?4562 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] Fullmoon build results
This is build report automatically generated by Fullmoon Ilmarinen (0.5.50.0) Fullmoon operated by Marko Lindqvist cazf...@gmail.com This build is from TRUNK. Component svn, Host build.cazfi.net, Phase Source update(1): Succeeded Component autogen.sh, Host build.cazfi.net, Phase Other command(0): Succeeded Component server, Host build.cazfi.net, Phase Build(2): Succeeded Component gtk2, Host build.cazfi.net, Phase Build(2): Succeeded Component sdl, Host build.cazfi.net, Phase Build(2): Succeeded Component sdl2, Host build.cazfi.net, Phase Build(2): Succeeded Component xaw, Host build.cazfi.net, Phase Build(2): Succeeded Component stub, Host build.cazfi.net, Phase Build(2): Succeeded Component QualityCheck, Host build.cazfi.net, Phase Check(4): FAILED ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4589] City styles to depend on Styles
URL: http://gna.org/patch/?4589 Summary: City styles to depend on Styles Project: Freeciv Submitted by: cazfi Submitted on: Sat 08 Mar 2014 04:30:26 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Make initial city styles to require certain national styles. User selects nation style, not city style. ___ File Attachments: --- Date: Sat 08 Mar 2014 04:30:26 AM EET Name: CityStyles.patch.bz2 Size: 12kB By: cazfi http://gna.org/patch/download.php?file_id=20278 ___ Reply to this item at: http://gna.org/patch/?4589 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21773] C++ warning about TYPED_VECTOR_ITERATE
URL: http://gna.org/bugs/?21773 Summary: C++ warning about TYPED_VECTOR_ITERATE Project: Freeciv Submitted by: cazfi Submitted on: Sat 08 Mar 2014 08:43:07 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.3, 2.5.0, 2.6.0 ___ Details: When TYPED_VECTOR_ITERATE is used in C++ code, g++ gives warning about comparison between signed (myiter) and unsigned (vector size). Attached fix makes myiter unsigned. ___ File Attachments: --- Date: Sat 08 Mar 2014 08:43:07 AM EET Name: TypedVectorIterUnsigned.patch Size: 544B By: cazfi http://gna.org/bugs/download.php?file_id=20279 ___ Reply to this item at: http://gna.org/bugs/?21773 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev