Follow-up Comment #9, patch #4636 (project freeciv):
ok, I'll do it.
___
Reply to this item at:
http://gna.org/patch/?4636
___
Mensaje enviado vía/por Gna!
http://gna.org/
Follow-up Comment #1, patch #4668 (project freeciv):
Noticed some typos in helpdata.c: ...minimum culture if %d ..., rather than
...of %d... in the second entry of several PL_() calls (the first entries
use of).
___
Reply to this item
Follow-up Comment #2, patch #4668 (project freeciv):
More detailed review:
1) if/of typo (see comment #2)
2) Uses minsize, rather than minculture in !preq-present (else)
conditions in helpdata.c
3) cityturn.c:: notification worklist_change_build_target(): text implies
REQ_RANGE_CITY (although
Follow-up Comment #1, patch #4459 (project freeciv):
I thought I'd try this, but ran into some uncertainties for some requirement
types.
For Extra, BaseFlag, RoadFlag, Terrain, Resource, TerrainCass, TerrainFlag,
and MinSize should whether the current player knows and/or sees the qualifying
Follow-up Comment #9, bug #21901 (project freeciv):
I can't now remember why I didn't make is_playable entirely a server-side
thing when doing the nationsets rework (patch #3448 etc). I certainly
considered but, but ended up with it being the clients' responsibility to
check is_playable; I wonder
Update of bug #21913 (project freeciv):
Assigned to: pepeto = persia
___
Follow-up Comment #5:
I've attached better patches for this for S2_4, S2_5, and
trunk, which address the most
Thanks for the feedback by testing on a Chromebook. As Freeciv-web is the
only way to play Freeciv on a Chromebook, since it's only web-based, so I
really want to improve Freeciv-web so that it works better on a
Chromebook. The challenge is that the Chromebooks usually have slow CPUs
and no
Follow-up Comment #3, bug #21972 (project freeciv):
Should the default section of the case statement be included as a fallback if
all if conditions do not match? I'm not sure if this would never be possible
...
___
Reply to this item at:
Follow-up Comment #10, patch #4636 (project freeciv):
Updated patch with conflicts between bases, instead of requirements.
(file #20595, file #20596)
___
Additional Item Attachment:
File name: civ2civ3-bases-2.patch Size:6 KB
File
Update of patch #4558 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #4, bug #21972 (project freeciv):
Should the default section of the case statement be included as
a fallback if all if conditions do not match?
Bug part of the optimization there is that there's no branching (if (xxx))
when there's only one *possible* case. We don't want to
Follow-up Comment #6, bug #21913 (project freeciv):
Thanks for the catch. These updated patches should ideally leak less memory.
(file #20597, file #20598, file #20599)
___
Additional Item Attachment:
File name:
Update of patch #3871 (project freeciv):
Status:None = Ready For Test
Assigned to:None = persia
Planned Release: = 2.6.0
Update of patch #4651 (project freeciv):
Category:None = ai
Status:None = Ready For Test
Assigned to:None = persia
Planned Release:
Update of patch #4665 (project freeciv):
Status: Ready For Test = Done
Assigned to:None = cazfi
Open/Closed:Open = Closed
URL:
http://gna.org/bugs/?21979
Summary: worklist_change_build_target() messages imply
REQ_RANGE_CITY regardless of real range
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 28 Apr 2014 12:32:30 AM EEST
Category:
Follow-up Comment #3, patch #4668 (project freeciv):
1 2 fixed, 3 raised as bug #21979
(file #20600)
___
Additional Item Attachment:
File name: MinCulture-2.patch Size:14 KB
Follow-up Comment #2, patch #4663 (project freeciv):
- Compare suggested musicset name against current musicset name, not soundset
name
(file #20601)
___
Additional Item Attachment:
File name: PreferredMusicset-3.patch Size:14 KB
Update of bug #21897 (project freeciv):
Severity: 3 - Normal = 5 - Blocker
Planned Release: 2.4.3, 2.5.0, 2.6.0 = 2.4.3, 2.5.0-beta1, 2.6.0
___
Follow-up Comment #11:
I'm adding a new
Follow-up Comment #2, patch #4671 (project freeciv):
Thanks for your feed back, Emmet.
Your suggestions looks like two alternatives I had considered. I may have
considered them enough that anything even remotely similar looks like one of
them. Please let me know if I'm talking about something
Additional Item Attachment, bug #21897 (project freeciv):
File name: LuasqlBase-4.patch Size:5 KB
File name: LuasqlBase-S2_4-4.patchSize:5 KB
___
Reply to this item at:
http://gna.org/bugs/?21897
URL:
http://gna.org/bugs/?21980
Summary: --disable-nls build broken
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 28 Apr 2014 02:04:50 AM EEST
Category: client
Severity: 3 - Normal
URL:
http://gna.org/patch/?4673
Summary: Remove unused progtest.m4
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 28 Apr 2014 02:21:12 AM EEST
Category: bootstrap
Priority: 5 - Normal
Follow-up Comment #3, patch #4671 (project freeciv):
On Alternative 1:
My fear here is that the logical conclusion to a patch series along that
line ends up causing the ruleset to need to duplicate the entirety of the
nativity rules that are in the engine (unless move also ends up using this
URL:
http://gna.org/patch/?4674
Summary: Rename PO_DOMAINS as PODOMAINS
Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 28 Apr 2014 03:08:05 AM EEST
Category: bootstrap
Priority: 5 - Normal
URL:
http://gna.org/bugs/?21982
Summary: present=FALSE improvement requirements can cause
incorrect server messages
Project: Freeciv
Submitted by: persia
Submitted on: Mon 28 Apr 2014 01:29:07 PM JST
Category: general
Update of bug #21115 (project freeciv):
Depends on: = bugs #21982
___
Reply to this item at:
http://gna.org/bugs/?21115
___
Message sent
27 matches
Mail list logo