[Freeciv-Dev] [patch #3926] Make it easier for users to locally add a custom nation to the default set

2014-06-02 Thread Marko Lindqvist
Update of patch #3926 (project freeciv): Status: Need Info => Ready For Test Planned Release: 2.5.0,2.6.0 => 2.6.0 ___ Follow-up Comment #5: I remember being s

[Freeciv-Dev] [patch #4771] Projectinfo -file

2014-06-02 Thread Marko Lindqvist
URL: Summary: Projectinfo -file Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Jun 2014 04:15:50 AM EEST Category: bootstrap Priority: 5 - Normal St

[Freeciv-Dev] [patch #4770] Consider effect requiremens to be "universals in use"

2014-06-02 Thread Marko Lindqvist
URL: Summary: Consider effect requiremens to be "universals in use" Project: Freeciv Submitted by: cazfi Submitted on: Tue 03 Jun 2014 03:49:08 AM EEST Category: freeciv-ruledit

[Freeciv-Dev] [patch #4743] Don't allow removal of advances in use

2014-06-02 Thread Marko Lindqvist
Update of patch #4743 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #3793] [metaticket] Help updates for 2.5.0

2014-06-02 Thread Jacob Nevins
Follow-up Comment #3, patch #3793 (project freeciv): Help on "Combat" needs an overhaul in light of the combat bonuses framework (patch #3548). Various references in helpdata.txt to 'default ruleset'. Should probably now refer to 'classic ruleset'. ___

[Freeciv-Dev] [bug #22106] Netfile dummy_write() return value assumes size unit to be single byte

2014-06-02 Thread Marko Lindqvist
Update of bug #22106 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #22076] Breakage with "--as-needed" linker flag

2014-06-02 Thread Jacob Nevins
Follow-up Comment #6, bug #22076 (project freeciv): (For the record, I found I had to "make clean" after updating my checkout with this change. Built fine after that.) ___ Reply to this item at:

[Freeciv-Dev] [patch #4746] Lua function to get terrain class of terrain

2014-06-02 Thread Marko Lindqvist
Update of patch #4746 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-02 Thread Jacob Nevins
Update of bug #21992 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-02 Thread Jacob Nevins
Follow-up Comment #5, bug #21992 (project freeciv): Oh! Of course, I forgot to think about the effects of moving to reqs outside my change. Thanks. My other test indicates that I've caused no obvious regressions, and review time's up, so in it goes. > What about making "present" tri-state

[Freeciv-Dev] [patch #4752] Remove unused imlib.m4

2014-06-02 Thread Marko Lindqvist
Update of patch #4752 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-02 Thread Marko Lindqvist
Follow-up Comment #4, bug #21992 (project freeciv): AI *is* handling nreqs and present=FALSE differently when evaluating effects provided by building to build. Evaluation of present=FALSE should be improvement over nreqs. nreqs are not evaluated at all, as they are never included to the cache. pr

[Freeciv-Dev] [bug #19859] Server fails to find rl_attempted_completion_function

2014-06-02 Thread Marko Lindqvist
Update of bug #19859 (project freeciv): Status:None => Duplicate Assigned to:None => cazfi Open/Closed:Open => Closed __

[Freeciv-Dev] [bug #22076] Breakage with "--as-needed" linker flag

2014-06-02 Thread Marko Lindqvist
Update of bug #22076 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-02 Thread Jacob Nevins
Follow-up Comment #3, bug #21992 (project freeciv): > (I suspect this isn't amenable to autogame testing, since the > AI is expected to improve. Probably the correct test is against > unmodified code and nreqs-based ruleset.) Tested unmodified code with patch #4411 reverted (i.e. with nreqs) ag

[Freeciv-Dev] [bug #22129] sdl- and qt-client compile fails

2014-06-02 Thread pepeto
Follow-up Comment #7, bug #22129 (project freeciv): I'm sorry for the noise, I didn't notice I didn't build all clients... ___ Reply to this item at: ___ Messag

[Freeciv-Dev] [bug #21992] Useless but non-obsolete city improvements not redundant with present==FALSE effects requirements

2014-06-02 Thread Marko Lindqvist
Follow-up Comment #2, bug #21992 (project freeciv): This is something that I worried about already when we switched to effects system in 2.0. Freeciv-1.14 and earlier had separate "replaced_by" -field for buildings. I don't think keeping nreqs for such an use that would be very hard to explain to

[Freeciv-Dev] [bug #22126] AI traits valgrind errors

2014-06-02 Thread pepeto
Update of bug #22126 (project freeciv): Planned Release: 2.6.0 => 2.5.0,2.6.0 ___ Follow-up Comment #3: Ok, going to commit to S2_5 too (same patch applies there too). __

[Freeciv-Dev] [bug #22083] apply_disaster() can reference city after it's freed

2014-06-02 Thread Jacob Nevins
Update of bug #22083 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22080] Non-cumulative Barracks effects not right wrt building redundancy

2014-06-02 Thread Jacob Nevins
Update of bug #22080 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3137] Cumulative Barracks and Sun Tzu documentation

2014-06-02 Thread Jacob Nevins
Update of patch #3137 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22085] civ2: reduce max trade routes from 4 to 3

2014-06-02 Thread Jacob Nevins
Update of bug #22085 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #22129] sdl- and qt-client compile fails

2014-06-02 Thread Jacob Nevins
Update of bug #22129 (project freeciv): Category: client-sdl => client Status: In Progress => Fixed Open/Closed:Open => Closed Planned Release:

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Jacob Nevins
Follow-up Comment #5, bug #22129 (project freeciv): Qt fix. (I'm guessing a grep that failed to search *.cpp.) (file #20914) ___ Additional Item Attachment: File name: trunk-qt-research-compile-fix.patch Size:1 KB ___

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Jacob Nevins
Follow-up Comment #3, bug #22129 (project freeciv): (introduced in patch #4727) ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/ _

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Jacob Nevins
Follow-up Comment #2, bug #22129 (project freeciv): SDL/SDL2 fixes attached, will commit immediately. (Can't try compiling SDL2 myself but it looks like it needs an identical fix.) (file #20913) ___ Additional Item Attachment: File name: t

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Jacob Nevins
Update of bug #22129 (project freeciv): Status:None => In Progress Assigned to:None => jtn ___ Reply to this item at:

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Marko Lindqvist
Follow-up Comment #1, bug #22129 (project freeciv): Also Qt-client fails to build: client/gui-qt/plrdlg.cpp: In member function 'void plr_widget::nation_selected(const QItemSelection&, const QItemSelection&)': client/gui-qt/plrdlg.cpp:359:41: error: 'player_research_get' was not declared in this

[Freeciv-Dev] [bug #22129] sdl-client compile fails

2014-06-02 Thread Marko Lindqvist
URL: Summary: sdl-client compile fails Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Jun 2014 11:48:00 PM EEST Category: client-sdl Severity: 3 - Normal

[Freeciv-Dev] [bug #22126] AI traits valgrind errors

2014-06-02 Thread Marko Lindqvist
Follow-up Comment #2, bug #22126 (project freeciv): > Only trunk affected. Though it's not (yet) biting in S2_5, it's a bad idea to have hardcoded assumption that size of the struct is "sizeof(int)". I think this should be fixed in S2_5 too to make sure some later change does not break it (and m

[Freeciv-Dev] [bug #22126] AI traits valgrind errors

2014-06-02 Thread pepeto
Update of bug #22126 (project freeciv): Status:None => Ready For Test Assigned to:None => pepeto Planned Release: => 2.6.0 __

[Freeciv-Dev] [patch #4726] [metaticket] Player research clean up

2014-06-02 Thread pepeto
Update of patch #4726 (project freeciv): Depends on: => patch #4769 ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #4769] PACKET_RESEARCH_INFO

2014-06-02 Thread pepeto
URL: Summary: PACKET_RESEARCH_INFO Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 10:09:53 PM CEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #4760] First commit to S2_6

2014-06-02 Thread Marko Lindqvist
Additional Item Attachment, patch #4760 (project freeciv): File name: S2_6Alpha.patchSize:0 KB ___ Reply to this item at: ___ Message sent via/b

[Freeciv-Dev] [bug #22127] BUGS claim that 2.4 is still in alpha

2014-06-02 Thread Marko Lindqvist
URL: Summary: BUGS claim that 2.4 is still in alpha Project: Freeciv Submitted by: cazfi Submitted on: Mon 02 Jun 2014 09:44:11 PM EEST Category: docs Severity: 3 - Normal

[Freeciv-Dev] [patch #4759] Setting TRUNK for 3.0 development

2014-06-02 Thread Marko Lindqvist
Additional Item Attachment, patch #4759 (project freeciv): File name: 3.0Trunk.patch Size:9 KB ___ Reply to this item at: ___ Message sent via/b

[Freeciv-Dev] [patch #4748] TRUNK windows followtag to "win32-S2_6"

2014-06-02 Thread Marko Lindqvist
Update of patch #4748 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #22110] Border claiming base activity based on tile, not base, ownership

2014-06-02 Thread Marko Lindqvist
Update of bug #22110 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed _

[Freeciv-Dev] [patch #4734] Support versioning of custom rulesets

2014-06-02 Thread Marko Lindqvist
Update of patch #4734 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

Re: [Freeciv-Dev] 2.5 Release Goals

2014-06-02 Thread Marko Lindqvist
On 6 April 2014 23:26, Marko Lindqvist wrote: > On 6 April 2014 17:43, Jacob Nevins > <0jacobnk.fc...@chiark.greenend.org.uk> wrote: >> Months ago (on 3 Jan), Marko Lindqvist wrote: > > > patch #4190: Split translations to multiple po-files > > If we are going to add information ab

[Freeciv-Dev] [bug #22122] trunk autogames not reproducible

2014-06-02 Thread Jacob Nevins
Update of bug #22122 (project freeciv): Status:None => Invalid Open/Closed:Open => Closed ___ Follow-up Comment #8: Haven't thoroughly

[Freeciv-Dev] [patch #4768] Pathfinding: node behavior optimization

2014-06-02 Thread pepeto
URL: Summary: Pathfinding: node behavior optimization Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 11:48:15 AM CEST Category: ai Priority: 5 - Normal

[Freeciv-Dev] [bug #22126] AI traits valgrind errors

2014-06-02 Thread pepeto
URL: Summary: AI traits valgrind errors Project: Freeciv Submitted by: pepeto Submitted on: Mon 02 Jun 2014 11:32:03 AM CEST Category: ai Severity: 3 - Normal Pr

[Freeciv-Dev] [bug #22050] Recursive transport problems

2014-06-02 Thread pepeto
Follow-up Comment #6, bug #22050 (project freeciv): The tests didn't pass. My patch doesn't fix all problems. Attaching new version: * unit_transport_check() also check cargo of the cargo unit (because some transported units also could be incompatible with one of the transport) ; * Check GAME_TRA

[Freeciv-Dev] [bug #22122] trunk autogames not reproducible

2014-06-02 Thread Jacob Nevins
Update of bug #22122 (project freeciv): Assigned to:None => jtn ___ Follow-up Comment #7: > gameseed is too high Sigh. It's right there in my log, too, if only I'd thought to look. I'll

[Freeciv-Dev] [patch #4728] research_players_iterate macro

2014-06-02 Thread pepeto
Update of patch #4728 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4727] Rename 'player_research' to 'research'

2014-06-02 Thread pepeto
Update of patch #4727 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4731] genhash/genlist: remove default functions

2014-06-02 Thread pepeto
Update of patch #4731 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4730] genhash: cache hash values

2014-06-02 Thread pepeto
Update of patch #4730 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4729] genhash: calculate hash values without the number of buckets

2014-06-02 Thread pepeto
Update of patch #4729 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4725] Add error messages when receiving unknown unit id removal info

2014-06-02 Thread pepeto
Update of patch #4725 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4694] Remove game_unit_by_number() usage in unit_transport_get()

2014-06-02 Thread pepeto
Update of patch #4694 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Follow-up Comment #4: About unit_transpo