[Freeciv-Dev] [bug #20032] Many unit activities use same icons (amplio2)

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #5, bug #20032 (project freeciv): - S2_5 version that enables the new fortifying icon too (file #23743) ___ Additional Item Attachment: File name: ActivitiesAmplio2-S2_5-2.patch Size:1 KB

[Freeciv-Dev] [patch #2829] Text data files with native line endings

2015-02-07 Thread Jacob Nevins
Follow-up Comment #8, patch #2829 (project freeciv): That does mean that the typical developer experience (running from source directory) diverges further from the mission mode (install and run), perhaps increasing the possibility of install-only bugs not spotted until too late. If the

[Freeciv-Dev] [patch #5799] Rewrap README.ruleset_civ2civ3

2015-02-07 Thread Jacob Nevins
Follow-up Comment #1, patch #5799 (project freeciv): Unix line endings Wait, no, that's not a problem. File in our svn has DOS line endings = Windows installer version has them too (I've just checked my beta2 installation). ___ Reply to

[Freeciv-Dev] [bug #23069] Public headers depend on value of DEBUG

2015-02-07 Thread Jacob Nevins
Follow-up Comment #5, bug #23069 (project freeciv): My S2_6 build is failing: make[2]: Entering directory `/home/jtn/src/freeciv/git/bS2_6/utility' CC log.lo ../../utility/log.c:300:7: error: no previous prototype for 'log_do_output_for_level_at_location' [-Werror=missing-prototypes]

[Freeciv-Dev] [patch #5798] Retire Fanatics effect, Fanatic unit flag

2015-02-07 Thread Jacob Nevins
Update of patch #5798 (project freeciv): Planned Release:2.6.0, 3.0.0 = ___ Follow-up Comment #2: Both good points... It does feel like an ugly special case that we should generalise though.

[Freeciv-Dev] [patch #5764] civ2civ3: bonus to defense in cities moved to size 9

2015-02-07 Thread Jacob Nevins
Update of patch #5764 (project freeciv): Status:Done = Ready For Test Assigned to:sveinung = jtn Open/Closed: Closed = Open Planned Release:

[Freeciv-Dev] [bug #23248] Settlers potential city outline left on map view

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/bugs/?23248 Summary: Settlers potential city outline left on map view Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 12:10:58 UTC Category: client-gtk-2.0 Severity: 3

[Freeciv-Dev] [patch #2829] Text data files with native line endings

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #9, patch #2829 (project freeciv): One tangential to the ruleset comments adding functionality is that also freeciv-ruledit needs such a thing but it is no way related to freeciv's 'make install'. Don't know if that could be used to solve the issue with supplied rulesets too.

[Freeciv-Dev] [patch #5798] Retire Fanatics effect, Fanatic unit flag

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/patch/?5798 Summary: Retire Fanatics effect, Fanatic unit flag Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 10:14:10 UTC Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #5798] Retire Fanatics effect, Fanatic unit flag

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #1, patch #5798 (project freeciv): Should now possible to implement with a user unit flag + Upkeep_Factor effect? Umh, do we do upkeep_factor on individual unittype level now (instead of a city)? And does also the Upkeep_Factor effect support that resolution? I don't think

[Freeciv-Dev] [patch #5798] Retire Fanatics effect, Fanatic unit flag

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #3, patch #5798 (project freeciv): It does feel like an ugly special case that we should generalise though. Indeed. It's a tiny bit better nowadays, but in the past I wanted to simply kill it off even with the cost of loss of functionality it provides. Getting clean

[Freeciv-Dev] [patch #5691] civ2civ3: help texts for governments

2015-02-07 Thread Jacob Nevins
Follow-up Comment #4, patch #5691 (project freeciv): I intend to commit this at the same time as patch #4936 (which builds on it). ___ Reply to this item at: http://gna.org/patch/?5691 ___

[Freeciv-Dev] [patch #5800] civ2civ3: Increase Fire disaster threshold to city size = 9

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/patch/?5800 Summary: civ2civ3: Increase Fire disaster threshold to city size = 9 Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 11:20:46 UTC Category: rulesets

[Freeciv-Dev] [patch #5800] civ2civ3: Increase Fire disaster threshold to city size = 9

2015-02-07 Thread Jacob Nevins
Update of patch #5800 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-civ2civ3-fire-pop9.patch Size:0 KB

[Freeciv-Dev] [patch #5799] Rewrap README.ruleset_civ2civ3

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/patch/?5799 Summary: Rewrap README.ruleset_civ2civ3 Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 10:46:30 UTC Category: docs Priority: 5 - Normal

[Freeciv-Dev] [bug #23069] Public headers depend on value of DEBUG

2015-02-07 Thread Jacob Nevins
Follow-up Comment #7, bug #23069 (project freeciv): ...and read comment #2? No. Sigh. Sorry. ___ Reply to this item at: http://gna.org/bugs/?23069 ___ Message sent via/by Gna!

[Freeciv-Dev] [bug #23249] Messages at game start not sent to Messages window

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #1, bug #23249 (project freeciv): AFAIK it's sent ok, but then the 'turn start' messages clearance for the first turn kicks in. Some other tickets discuss about the opposite inconsistency - messages from the past turns are displayed on messages tab when they come from the event

[Freeciv-Dev] [bug #22807] civ2civ3: Temple of Zeus / King Richard's Crusade undocumented half effect under Democracy

2015-02-07 Thread Jacob Nevins
Update of bug #22807 (project freeciv): Status: Confirmed = Duplicate Open/Closed:Open = Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #4936] More thorough civ2civ3 help

2015-02-07 Thread Jacob Nevins
Update of patch #4936 (project freeciv): Depends on: = patch #5764 ___ Reply to this item at: http://gna.org/patch/?4936 ___ Message sent

[Freeciv-Dev] [patch #4936] More thorough civ2civ3 help

2015-02-07 Thread Jacob Nevins
Update of patch #4936 (project freeciv): Planned Release:2.5.0, 2.6.0 = 2.5.0, 2.6.0, 3..0.0 Summary: Tart up civ2civ3 help = More thorough civ2civ3 help ___ Follow-up Comment #4: Still working

[Freeciv-Dev] [bug #23069] Public headers depend on value of DEBUG

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #6, bug #23069 (project freeciv): have rerun autogen.sh ...and read comment #2? ___ Reply to this item at: http://gna.org/bugs/?23069 ___ Message sent via/by Gna!

[Freeciv-Dev] [patch #5799] Rewrap README.ruleset_civ2civ3

2015-02-07 Thread Marko Lindqvist
Follow-up Comment #2, patch #5799 (project freeciv): File in our svn has DOS line endings If that's just lucky coincidense with undefined eol-style (can't check svn at the moment) it should be made explicit, so that edits to the file do not accidentally change the fact, by setting eol-style

[Freeciv-Dev] [patch #5801] civ2civ3: allow Internet to have distinct graphic

2015-02-07 Thread Jacob Nevins
Update of patch #5801 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_6-civ2civ3-internet-graphic.patch Size:0 KB File name:

[Freeciv-Dev] [patch #4936] More thorough civ2civ3 help

2015-02-07 Thread Jacob Nevins
Follow-up Comment #5, patch #4936 (project freeciv): Here's my work in progress. I've dealt with every ruleset element except governments. Please review. I'd especially appreciate bardo's scrutiny, in case I've misinterpreted some ruleset effects or slavishly documented an unintended behaviour.

[Freeciv-Dev] [bug #23022] GTK2 Client crash when resize or move dialogs

2015-02-07 Thread Jacob Nevins
Update of bug #23022 (project freeciv): Planned Release: = 2.5.0-RC1, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/bugs/?23022 ___ Message sent

[Freeciv-Dev] [bug #23249] Messages at game start not sent to Messages window

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/bugs/?23249 Summary: Messages at game start not sent to Messages window Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 13:31:59 UTC Category: client-gtk-2.0 Severity:

[Freeciv-Dev] [patch #5801] civ2civ3: allow Internet to have distinct graphic

2015-02-07 Thread Jacob Nevins
URL: http://gna.org/patch/?5801 Summary: civ2civ3: allow Internet to have distinct graphic Project: Freeciv Submitted by: jtn Submitted on: Sat 07 Feb 2015 14:36:11 UTC Category: rulesets Priority: 3 - Low

[Freeciv-Dev] [bug #23246] Windows Installer Makefile not compatible with new gnuwin environment

2015-02-07 Thread Christian Prochaska
Follow-up Comment #2, bug #23246 (project freeciv): The patch was needed to use the GTK+ 3.10.4 bundle, but this bundle caused problems with the GTK+ 2 client (bug #23022). So we probably don't want to use this version of the gnuwin environment for future releases.

[Freeciv-Dev] [patch #5800] civ2civ3: Increase Fire disaster threshold to city size = 9

2015-02-07 Thread David Fernandez
Follow-up Comment #1, patch #5800 (project freeciv): Good catch, I forgot this one. ___ Reply to this item at: http://gna.org/patch/?5800 ___ Mensaje enviado vía/por Gna! http://gna.org/

[Freeciv-Dev] [patch #5764] civ2civ3: bonus to defense in cities moved to size 9

2015-02-07 Thread David Fernandez
Follow-up Comment #6, patch #5764 (project freeciv): This will make the SINCE PREVIOUS VERSION section of README.ruleset_civ2civ3 on S2_6/trunk wrong. But now civ2civ3 is in svn, I'm inclined to delete that section and handle it via the usual release notes process (NEWS-2.6 file). I agree.

[Freeciv-Dev] [bug #23022] GTK2 Client crash when resize or move dialogs

2015-02-07 Thread Christian Prochaska
Follow-up Comment #12, bug #23022 (project freeciv): I've created Freeciv 2.5.0-beta2 installers built with GTK+ 3.8.2 bundle for comparison: GTK2 client: http://download.gna.org/freeciv/packages/windows/testing/Freeciv-2.5.0-beta2-win32-gtk2(GTK+-3.8.2-bundle)-setup.exe GTK3 client:

[Freeciv-Dev] [bug #23246] Windows Installer Makefile not compatible with new gnuwin environment

2015-02-07 Thread Christian Prochaska
Follow-up Comment #3, bug #23246 (project freeciv): The latest gnuwin32 test environment with the GTK+ 3.8.2 bundle (http://download.gna.org/freeciv/packages/windows/gnuwin32/testing/gnuwin32-2015-02-07.7z) requires the attached Freeciv patch, if we want to use it for a future release. (file

[Freeciv-Dev] [bug #23250] improvement_effect_value() has illegal array accesses using continent number 0

2015-02-07 Thread Marko Lindqvist
URL: http://gna.org/bugs/?23250 Summary: improvement_effect_value() has illegal array accesses using continent number 0 Project: Freeciv Submitted by: cazfi Submitted on: Sun 08 Feb 2015 12:38:53 AM EET Category: ai

[Freeciv-Dev] [patch #5784] Unit upkeep icons for upkeep 2 in amplio

2015-02-07 Thread Marko Lindqvist
Update of patch #5784 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #5791] Freight not obsoleting Caravan in Experimental

2015-02-07 Thread Marko Lindqvist
Update of patch #5791 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4936] More thorough civ2civ3 help

2015-02-07 Thread David Fernandez
Follow-up Comment #7, patch #4936 (project freeciv): 2) Units I like all your changes. I think the FIXME in the transport is no longer needed. We fixed it so sea units can not perform other transformations in land. Maybe it is good to keep it as a warning in case there are other transformations

[Freeciv-Dev] [patch #5802] Option to force SW rendering to use

2015-02-07 Thread Marko Lindqvist
URL: http://gna.org/patch/?5802 Summary: Option to force SW rendering to use Project: Freeciv Submitted by: cazfi Submitted on: Sun 08 Feb 2015 09:15:03 AM EET Category: client-sdl2 Priority: 5 - Normal

[Freeciv-Dev] [bug #23230] adjust_improvement_wants_by_effects() has illegal array accesses using continent number 0

2015-02-07 Thread Marko Lindqvist
Update of bug #23230 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #5787] SDL_RegisterEvents() user event

2015-02-07 Thread Marko Lindqvist
Update of patch #5787 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #5785] ruleset_locked scenario property

2015-02-07 Thread Marko Lindqvist
Update of patch #5785 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [patch #4936] More thorough civ2civ3 help

2015-02-07 Thread David Fernandez
Follow-up Comment #6, patch #4936 (project freeciv): I appreciate that you have revised these files. I) README I was expecting more changes to the Readme, because I know mine was a bit rough or homemade. Anyway, let me some comments. - In patch #5764 I introduced some changes to the city

[Freeciv-Dev] [patch #5778] worklist_copy() with smallest copy size

2015-02-07 Thread Marko Lindqvist
Update of patch #5778 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed

[Freeciv-Dev] [bug #21942] Crash when opening city window with gtk3

2015-02-07 Thread Marko Lindqvist
Update of bug #21942 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed