[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold
Follow-up Comment #8, bug #15400 (project freeciv): Nice catch. I'm not quite sure why I didn't get a compile-time error or warning when I removed math.h from map.h. Maybe I did, and I missed it. ___ Reply to this item at: http://gna.org/bugs/?15400 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16008] replace in-tree lua with system lua
URL: http://gna.org/bugs/?16008 Summary: replace in-tree lua with system lua Project: Freeciv Submitted by: jkl Submitted on: Saturday 05/08/2010 at 19:38 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: This patch is a big one, and it may need some revisions to account for various platform quirks. The build documentation probably needs to be revised as well. It does 3 things: 1. delete the in-tree lua and tolua code 2. add autoconf checks for system lua and tolua 3. fix the way the server is linked What is the standard set of platforms on which the build should be tested? I can do some more testing once I have a complete list. Finally, note that the version of tolua in Debian stable isn't recent enough for freeciv. It's missing some functions. You need to get the one from testing (or Ubuntu Lucid), which is based on the 5.1.2 version of tolua. That isn't the most recent version, but I think it's better to let the package maintainers deal with upstream releases than to maintain in-tree copies. ___ File Attachments: --- Date: Saturday 05/08/2010 at 19:38 Name: use_system_lua.patch.gz Size: 283kB By: jkl http://gna.org/bugs/download.php?file_id=9139 ___ Reply to this item at: http://gna.org/bugs/?16008 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16008] replace in-tree lua with system lua
Follow-up Comment #4, bug #16008 (project freeciv): The autoconf macro checks for tolua_getmetatable, which was added sometime after 5.1b, but not later than 5.1.2. So the check fails even though you have tolua. Obviously the error message isn't descriptive enough. I have successfully linked freeciv against tolua 5.1.2 and 5.1.3. I'm not too familiar with the Suse package system, but from your post it appears that Suse (like Debian stable) is too far behind in its tolua packages for this patch to be practical at this time. If people have to custom-build tolua or go searching for packages in nonstandard repositories, it defeats much of the point of trying to link to system libraries. Maybe converting to system lua should wait until the distros catch up. ___ Reply to this item at: http://gna.org/bugs/?16008 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15983] incomplete rename of my_nonblock
URL: http://gna.org/bugs/?15983 Summary: incomplete rename of my_nonblock Project: Freeciv Submitted by: jkl Submitted on: Sunday 05/02/2010 at 16:11 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Back in 2008, a bunch of nework functions with a my_ prefix were renamed using an fc_ prefix. One of those is the my_nonblock function in utility/netintf.c. Unfortunately, not all references were changed. There are still two references to my_nonblock in utility/support.c (one in code, one in a comment). Attached is a patch. How could this have gone undetected for around 18 months? Because the reference in question is inside a nest of #ifdef blocks. In particular, apparently there is system for which: SOCKET_ZERO_ISNT_STDIN is defined WIN32_NATIVE is not defined HAVE_FILENO is defined Does anyone know what system this is? ___ File Attachments: --- Date: Sunday 05/02/2010 at 16:11 Name: rename-my_nonblock.patch Size: 878B By: jkl http://gna.org/bugs/download.php?file_id=9108 ___ Reply to this item at: http://gna.org/bugs/?15983 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15400] FTBFS with binutils-gold
Follow-up Comment #6, bug #15400 (project freeciv): Here is an additional patch which fixes more problems related to math.h and libm. It should be applied in addition to the other patch I submitted here, as well as the patch over on 15973 which sets up COMMON_LIBS and UTILITY_LIBS. Again, the theme is that each executable, library, or convenience library which uses the math library should link to it, and each file which uses math.h functions should directly include math.h. (file #9119) ___ Additional Item Attachment: File name: more-math-lib-fixups.patch Size:5 KB ___ Reply to this item at: http://gna.org/bugs/?15400 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15973] libfreeciv should be linked against libm
Follow-up Comment #3, bug #15973 (project freeciv): Here is a better patch. This one sets up some autoconf variables for the common and utility libs. 1. It sets up a COMMON_LIBS autoconf variable, which is used as an extra LIBADD for libfreeciv. 2. It sets up a UTILTITY_LIBS autoconf variable, which is used as an extra LIBADD for the utility convenience library. 3. -lz and -lbz2 are added to COMMON_LIBS and UTILITY_LIBS as appropriate. The client and server don't need to link to them directly, so they should't be in LIBS. (file #9097) ___ Additional Item Attachment: File name: autoconf_common_and_utility_libs.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?15973 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (no subject)
I think there is no regular maintainer for the Win32 client. I submitted a patch for the Win32 client a while ago -- I believe the tracking number is PR#33445. Marko looked at it and wrote his own patch which improved parts of what I had written. However, he only committed his own patch, and certain fixes from my patch were never committed. Perhaps that's because I did more than just fix what absolutely had to be fixed, opting to the cursor code to a new file and such. Anyway, I'm pretty new around here, but I would say go ahead and send in what you did. Perhaps it will improve upon what I submitted. Hopefully someone will be able to tell you how to get your patch added to the proper place in the tracking system. Regarding the server build, I was able to build everything fine under MinGW/Msys from the SVN sources back when I was working on that patch. I didn't need to do --disable-nls or hack the config.h file. I built the required libraries from source, except for readline. I ended up using the prebuilt readline package from the GNUWin32 project. It looks to me like there is a problem with your build environment. I don't think you should be using the libintl.a that's in freeciv/intl/. Perhaps configure can't find your libintl or can't use it for some reason. You should have gotten libintl from the gettext package. If I were you I would clean up and try the build from autogen on, this time without --disable-nls, looking for any errors or problems related to dcgettext, libintl, libcharset, or libiconv in the configure stage. Hopefully you will see a test of one of these fail and there will be some useful diagnostic information in config.log. JKL On 3/23/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hello. I just joined this list, and I did a quick skim thruogh the last few months archives. Please forgive me if I'm bringing up stuff thats already been dealth with. I've been trying to build freeciv under windows using MinGW/MSys for the past week or so. I had success doing this a couple years ago, but I hadn't played with it since. I ran into problems when it tried to link civserver.exe. If I ran autogen.sh normally, and then make I got this at the link step for civserver: C:/GNU/MinGW/bin/../lib/gcc/mingw32/3.4.2/../../../libiconv.a(ds7.o): multiple definition of `locale_charset' ../intl/libintl.a(localcharset.o):c:/chris/freeciv/intl/localcharset.c:206: first defined here collect2: ld returned 1 exit status make[3]: *** [civserver.exe] Error 1 So, I tried the suggestions in the Install-Windows document and passed --disable-nls into autogen.sh. Then I got this: ./libcivserver.a(stdinhand.o): In function `handle_stdin_input':c:/chris/freeciv/server/stdinhand.c:1064: undefined reference to `_imp__libintl_fprintf' :c:/chris/freeciv/server/stdinhand.c:1071: undefined reference to `_imp__libintl_fprintf' :c:/chris/freeciv/server/stdinhand.c:1074: undefined reference to `_imp__libintl_fprintf' :c:/chris/freeciv/server/stdinhand.c:1077: undefined reference to `_imp__libintl_fprintf' :c:/chris/freeciv/server/stdinhand.c:1082: undefined reference to `_imp__libintl_fprintf' ./libcivserver.a(stdinhand.o):c:/chris/freeciv/server/stdinhand.c:1106: more undefined references to `_imp__libintl_fprintf' follow collect2: ld returned 1 exit I finally figured out that I had to edit config.h and comment out this line: #define HAVE_LIBCHARSET 1 Have I installed something wrong? Do I need to pass more options to autogen? Or is there a problem with autogen/configure? After I made the aforementioned change, the GTK client built just fine. However, the win32 client gave me lots of errors. I set about fixing them, and I have a patch ready. Should I email it to this mailing list? Inline or Attachment? I'm also wondering how the most recent win32 clients were built. Some of the stuff I was fixing has been there for over a year, and prevented compiling the win32 client. I'm confused as to how a new build was released last month. Perhaps I'm doing something else wrong. Chris Nash (aka Homr Zodyssey) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
