[Freeciv-Dev] [bug #16080] The Great Wall affects all units which is staying out of City
Follow-up Comment #3, bug #16080 (project freeciv): Here's the essence of an alternative fix, which adds requirements to the effects rather than changing the semantics of EFT_DEFEND_BONUS in the code. I'm not sure I don't prefer your fix, though. EFT_DEFEND_BONUS is already pretty tightly tied to implementing city walls or similar city defences, so it probably doesn't hurt. Plus your fix could be back-ported to S2_1 if desired, whereas mine couldn't (the CityTile universal doesn't exist on S2_1 IIRC). (file #9391) ___ Additional Item Attachment: File name: S2_2-greatwall-effect.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16080] The Great Wall affects all units which is staying out of City
Follow-up Comment #2, bug #16080 (project freeciv): The problem is due to the fact that the effect EFT_DEFEND_BONUS is potentially applicable to any unit - including outdoor units - in the game and that for the Great Wall, as the game is checking for this wonder player-wide, the bonus would be applied player-wide too. Resolving this problem yielded another related issue: for the same reasons, the firepower reset of units with F_BADWALLATTACKER attacking fortified cities did actually happen when attacking any unit - including outdoor units - of the nation controlling the Great Wall, making this nation even more hard to fight with custom rulesets using F_BADWALLATTACKER. Hard-coding the EFT_DEFEND_BONUS range to garrisoned units only, attached patches fix the problems for both the trunk and S2_2. (file #9382, file #9383) ___ Additional Item Attachment: File name: trunk-great-wall.diff Size:2 KB File name: S2_2-great-wall.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16080] The Great Wall affects all units which is staying out of City
Follow-up Comment #1, bug #16080 (project freeciv): Confirmed on S2_2. Blimey, that seems like quite a serious error -- Great Wall confers a massive advantage (+200% defence for all land units). I wonder if that's behind any of the reports on the forums of invulnerable AI? From inspection I think the same error applies to S2_1, but I haven't tested it. I think it probably came in around r11179, PR#14314 http://bugs.freeciv.org/Ticket/Display.html?id=14314 (2005!) On the head of S2_2 I think it affects defense_multiplication() and also get_modified_firepower() (in the F_BADWALLATTACKER case, which isn't used in any of the default rulesets). ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16080] The Great Wall affects all units which is staying out of City
URL: http://gna.org/bugs/?16080 Summary: The Great Wall affects all units which is staying out of City Project: Freeciv Submitted by: None Submitted on: Wednesday 05/26/2010 at 09:30 CEST Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.2.0 Discussion Lock: Any Operating System: Microsoft Windows Planned Release: ___ Details: All outdoor land units gets the defence bounus if its nation builds the wonder of Great Wall. ___ Reply to this item at: http://gna.org/bugs/?16080 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
