http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
Marko Lindqvist:
> 2008/5/18 jacobn:
> >
> > I don't see an easy way out of this, unless the policy of using pointer
> > comparison is reversed. Temporarily modifying the tile in-place seems
> > evil (especially as the comments for city_tile_
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
2008/5/18 jacobn:
>
> I don't see an easy way out of this, unless the policy of using pointer
> comparison is reversed. Temporarily modifying the tile in-place seems
> evil (especially as the comments for city_tile_output() make it clear
> th
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
> Can you make version for other branches (S2_2 and TRUNK) too?
Attached is a straight-ish port to S2_2 (auto-farmland-ter-2-2.diff). It
is functional, but I'm unhappy with it, as it's no longer robust :(
On S2_2, various tests (e.g., is_ci
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
> The reason to have two separate variables to access dummy tile is not
> that the second one is pointer, but the added security of the const.
> So I suggest you name this variable const_dummy_tile instead of
> p_dummy_tile.
On the other ha
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
2008/5/3 [EMAIL PROTECTED]
<[EMAIL PROTECTED]>:
>
> - introduce and use a const p_dummy_tile; this attempts to mitigate the
>pointer aliasing introduced by my change, but the result looks a
>little awkward;
The reason to have two
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
Here's a new patch which is functionally equivalent to my previous one
but includes Madeline's suggestion:
- rename "tile" to "dummy_tile" throughout
and also includes the more controversial changes mentioned previously,
such that I'm not
http://bugs.freeciv.org/Ticket/Display.html?id=40207 >
Since at least one other person seems to think it's a real bug, I've
investigated further.
Looking further down the function, it becomes obvious why the temporary
setting of S_FARMLAND isn't having any effect while S_IRRIGATION is: the
effec
