[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Update of patch #3815 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #11, patch #3815 (project freeciv): S2_4 version (file #17837) ___ Additional Item Attachment: File name: StaticOceanMoveHelp-S2_4.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #9, patch #3815 (project freeciv): Old description is redundant, but is it still something that makes people to realize the difference between Ocean and Deep Ocean while they are less likely to spot that unit class lists differ? I agree. I think it's worth keeping the Deep Ocean text the way it is, but still removing the redundancy from the Ocean/Lake descriptions. New trunk patch attached. (file #17825) ___ Additional Item Attachment: File name: quick-terrain-nativity-static-help-changes-bis.patch Size:2 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #10, patch #3815 (project freeciv): While we have no formal string freeze for beta2, I'd leave out patch that *only* changes texts (i.e, is not doing it as part of larger bugfix) now that we have 100% translations. ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #5, patch #3815 (project freeciv): The attached files provide one possible adjustment to the static helptexts for S2_4 and trunk. In trunk, I did not remove the phrases Planet's radiation makes it impossible for Earthly organisms to survive here., Burrowing units are unable to burrow through these mountains., or No ship without special equipment can enter. for the alien ruleset as they were phrased in the negative, and I thought they added a nice flavour and sense of environment beyond their value as indicators of nativity. Similarly, one could add Trireme captains fear swamping by the heavy seas, and will not enter. or so to the Deep Ocean texts for classic/experimental/multiplayer, enriching the storyline of the ruleset without overloading the nativity data provided by this patch. (file #17723, file #17724) ___ Additional Item Attachment: File name: quick-terrain-nativity-static-help-changes.S2_4.patch Size:4 KB File name: quick-terrain-nativity-static-help-changes.patch Size:4 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #8, patch #3815 (project freeciv): I committed the helptext generation part, but would really like more opinions of the changes to static texts. Old description is redundant, but is it still something that makes people to realize the difference between Ocean and Deep Ocean while they are less likely to spot that unit class lists differ? ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #4, patch #3815 (project freeciv): - S2_4 version that compiles We may want to change static helptexts for some terrains too. Now Ocean helptext redundantly mentions that it can be traveled by sea and trireme units, and deep ocean points out that trireme cannot travel there. (file #17694) ___ Additional Item Attachment: File name: TerrainMoveClassHelp-S2_4.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Update of patch #3815 (project freeciv): Status:None = Ready For Test Assigned to:None = cazfi ___ Follow-up Comment #1: Usually jtn has had the last say in help changes, but OTOH he may be busy with other things. Feel free to take this ticket from me if you want. Either way is fine by me. I think S2_4 would benefit from such a help improvement. ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #2, patch #3815 (project freeciv): I didn't mean to rush processing of this patch with the comment in patch #3816 , rather I just wanted to provide a hint for testing, as when I checked the submitted patch against revision 22638 it didn't apply cleanly. Anyway, I believe that terrain-nativity-help.S2_4.patch should provide essentially the same value ported to S2_4. I was unable to build S2_4 from revision 22639 due to a LUA error (which I presume related to some local configuration on my machine), so this is entirely theoretical, rather than a tested patch. (file #17643) ___ Additional Item Attachment: File name: terrain-nativity-help.S2_4.patch Size:1 KB ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Follow-up Comment #3, patch #3815 (project freeciv): Seems like a fine change to me. ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Emmet Hikory writes: I was unable to build S2_4 from revision 22639 due to a LUA error (which I presume related to some local configuration on my machine), so this is entirely theoretical, rather than a tested patch. What's the nature of the failure? If we're releasing 2.4.0-beta2 soon, I'm interested in portability hazards. (Guess: are you switching a single working directory between trunk and S2_4? This is currently fraught, requiring make maintainer-clean and starting again. This bites me in my mad git-svn setup.) ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Mon, Apr 01, 2013, Jacob Nevins wrote: What's the nature of the failure? If we're releasing 2.4.0-beta2 soon, I'm interested in portability hazards (Guess: are you switching a single working directory between trunk and S2_4? This is currently fraught, requiring make maintainer-clean and starting again. This bites me in my mad git-svn setup.) Ah, yes, precisely. Thanks for the explanation: I wondered why it didn't work. I had thought that git reset --hard would be sufficient, but perhaps that requires being less agressive with info/exclude :) Strangely, it had worked previously for some of my deeper history investigation, but perhaps I just got lucky (or went far enough back in time that the build system figured my machine was lying to it). Do I need to do anything other than `make maintainer-clean` to operate in this manner, or are there other tricks that are important if porting patches to stable branches for accurate testing? -- Emmet HIKORY ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
Update of patch #3815 (project freeciv): Planned Release: = 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3815] Provide information about unit class nativity in terrain help
URL: http://gna.org/patch/?3815 Summary: Provide information about unit class nativity in terrain help Project: Freeciv Submitted by: persia Submitted on: Sat 30 Mar 2013 03:46:16 PM GMT Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The current help provides Land units cannot travel on oceanic terrains. as part of the helpstring for any oceanic terrain. Given the concept of terrain nativity, and that units are no longer one of Land, Sea, or Air based on UMT_LAND, UMT_SEA, and UMT_BOTH, this isn't very helpful when playing a ruleset with complex nativity. This patch replaces that with a constructed string of unit classes that are native to that terrain without any special, base, or road. The string is reused from the code to generate the road help, which I hope will reduce the impact of the new string on translators. I would be happy to backport the patch to S2_4 or earlier, if someone believes it should also be applied there. ___ File Attachments: --- Date: Sat 30 Mar 2013 03:46:16 PM GMT Name: terrain-nativity-help.patch Size: 2kB By: persia http://gna.org/patch/download.php?file_id=17614 ___ Reply to this item at: http://gna.org/patch/?3815 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
