Update of patch #3839 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Update of patch #3839 (project freeciv):
Planned Release: = 2.5.0, 2.6.0
___
Reply to this item at:
http://gna.org/patch/?3839
___
Message sent
Update of patch #3839 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #9:
For the SDL client fix, it's mostly a random swipe to remove it
from grep results. That
Follow-up Comment #10, patch #3839 (project freeciv):
This change may increase the cases where a player may attempt an impossible
paradrop, but it also reduces the cases where a player may not attempt a
possible paradrop. While it makes no difference for classical rulesets, this
code means that
Follow-up Comment #7, patch #3839 (project freeciv):
- assess_danger()
Use utype_can_take_over() to indicate danger to cities
I think this one affects even standard rulesets, and is a bug in all branches
(to be fixed in S2_4, S2_5, TRUNK). AI does not consider enemy Helicopters
city
Follow-up Comment #8, patch #3839 (project freeciv):
assess_danger() now in bug #20785
further reduced patch attached.
(file #17889)
___
Additional Item Attachment:
File name: low-hanging-nativity-fixes-more-reduced.patch Size:2 KB
Follow-up Comment #5, patch #3839 (project freeciv):
base_assess_defense_unit() change now part of patch #3885
___
Reply to this item at:
http://gna.org/patch/?3839
___
Message sent via/by
Follow-up Comment #6, patch #3839 (project freeciv):
Reduced patch, no longer including base_assess_defense_unit() or
kill_something_with()
(file #17850)
___
Additional Item Attachment:
File name: low-hanging-nativity-fixes-reduced.patch
Follow-up Comment #3, patch #3839 (project freeciv):
kill_something_with() is the change I'm most worried about too. You just let
more units (in non-default rulesets) to go on with the main codepath, and I've
seen that code to crash when unit properties unexpected to original
implementation
Follow-up Comment #4, patch #3839 (project freeciv):
Ah, in that case, let's assume the kill_something_with() hunk to be unsafe:
there's enough other work to be done in that part of the code for complex
nativity that it will surely be revisited.
Update of patch #3839 (project freeciv):
Status:None = In Progress
Assigned to:None = cazfi
___
Follow-up Comment #1:
all fairly
Follow-up Comment #2, patch #3839 (project freeciv):
Heh, perhaps my definition of lightweight was adjusted by the remainder of
the nativity stuff :) I've no objection to splitting this into bits: it was
assembled from bits as I tried to clean up nativity everywhere: these were the
ones that
URL:
http://gna.org/patch/?3839
Summary: Low hanging nativity fixes
Project: Freeciv
Submitted by: persia
Submitted on: Mon 08 Apr 2013 04:58:06 PM JST
Category: general
Priority: 5 - Normal
13 matches
Mail list logo
