[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #16300 (project freeciv): what system do you use? The warnings are for variables of type 'size_t' printed using '%lu'. What is the type of size_t on your system? As a solution casts could be added to all lines with warning ... I do compile using '--enable-debug=check

[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Matthias Pfafferodt
Update of bug #16300 (project freeciv): Status:None => Ready For Test Assigned to:None => syntron Planned Release: => 2.3.0 _

[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Lavrentij P Berija
Follow-up Comment #3, bug #16300 (project freeciv): I use Ubuntu Karmic 32 bit. Is there a possibility that these casts can go wrong on 32 bit or 64 bit? Compilation of savegame2.c works OK with this patch, but I can't test if saving/loading the game is correct because of another warning in gtkit

[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #4, bug #16300 (project freeciv): > I use Ubuntu Karmic 32 bit. Is there a possibility that these > casts can go wrong on 32 bit or 64 bit? This could be the case for size_t ... (32 bit on 32 and 64 bit on 64?) > Compilation of savegame2.c works OK with this patch, but I > ca

[Freeciv-Dev] [bug #16301] update queue not working with player pointers

2010-07-26 Thread Matthias Pfafferodt
hments: --- Date: Montag 26.07.2010 um 12:34 Name: 20100726-02-trunk-fix-set_client_page.patch Size: 812B By: syntron <http://gna.org/bugs/download.php?file_id=9565> ___ Reply to this item at: <http://gna.

[Freeciv-Dev] [patch #1739] [players] use pointers for players

2010-07-26 Thread Matthias Pfafferodt
the update queue for page changes; see gna bug #16301 (file #9566) ___ Additional Item Attachment: File name: 20100726-01-trunk-use-pointers-for-players.patch Size:100 KB ___ R

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Matthias Pfafferodt
Update of patch #1732 (project freeciv): Depends on: => bugs #16301 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1741] [players] use player_slot_count

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1741 (project freeciv): updated version (file #9567) ___ Additional Item Attachment: File name: 20100726-03-trunk-use-player_slot_count.patch Size:9 KB

[Freeciv-Dev] [patch #1742] [players] cleanup game_init()

2010-07-26 Thread Matthias Pfafferodt
568) ___ Additional Item Attachment: File name: 20100726-04-trunk-split-game_init-into-game_init-and-game_default.patch Size:1 KB ___ Reply to this item at: <http://gna.org/patch

[Freeciv-Dev] [patch #1743] [players] dynamically allocate player->diplstates

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1743 (project freeciv): updated version (file #9569) ___ Additional Item Attachment: File name: 20100726-05-trunk-dynamically-allocate-player-diplstates.patch Size:71 KB

[Freeciv-Dev] [patch #1745] [players] dynamically allocate ai_data

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1745 (project freeciv): updated version (file #9570) ___ Additional Item Attachment: File name: 20100726-07-trunk-dynamically-allocate-ai_data.patch Size:49 KB

[Freeciv-Dev] [patch #1759] [players] fix debugging tool in score.c

2010-07-26 Thread Matthias Pfafferodt
etails: ___ File Attachments: --- Date: Montag 26.07.2010 um 12:45 Name: 20100726-08-trunk-fix-debugging-tool-in-score.c.patch Size: 808B By: syntron <http://gna.org/patch/download.ph

[Freeciv-Dev] [patch #1760] [players] define MAX_NUM_PLAYER_SLOTS

2010-07-26 Thread Matthias Pfafferodt
etails: ___ File Attachments: --- Date: Montag 26.07.2010 um 12:46 Name: 20100726-09-trunk-define-MAX_NUM_PLAYER_SLOTS.patch Size: 7kB By: syntron <http://gna.org/patch/download.php?fil

[Freeciv-Dev] [patch #1761] [players] add team pointer

2010-07-26 Thread Matthias Pfafferodt
um 12:47 Name: 20100726-12-trunk-add-team-pointer.patch Size: 33kB By: syntron <http://gna.org/patch/download.php?file_id=9573> ___ Reply to this item at: <http://gna.

[Freeciv-Dev] [patch #1762] [players] dynamically allocate the team names

2010-07-26 Thread Matthias Pfafferodt
etails: * new network package ___ File Attachments: --- Date: Montag 26.07.2010 um 12:48 Name: 20100726-13-trunk-dynamically-allocate-the-team-names.patch Size: 15kB By: syntron

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Matthias Pfafferodt
Update of patch #1732 (project freeciv): Depends on: => patch #1746 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1763] [players] rename player->ai_common.control to player->ai_controlled

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [players] rename player->ai_common.control to player->ai_controlled Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 13:10 Category: general

[Freeciv-Dev] [patch #1763] [players] rename player->ai_common.control to player->ai_controlled

2010-07-26 Thread Matthias Pfafferodt
575) ___ Additional Item Attachment: File name: 20100726-14-trunk-rename-player-ai_common.control-to-player-ai_contr.patch Size:66 KB ___ Reply to this item at: <http://gna.org/patch/?1763> ___

[Freeciv-Dev] [patch #1764] [players] fix unit->server.ai->hunted

2010-07-26 Thread Matthias Pfafferodt
etails: * a bv_player bitvector is needed for > 32 players * move the definition into fc_types.h ___ File Attachments: --- Date: Montag 26.07.2010 um 13:11 Name: 20100726-15-trunk-fix

[Freeciv-Dev] [patch #1765] cleanup bitvectors

2010-07-26 Thread Matthias Pfafferodt
nit_flags bv_roles => bv_unit_roles (new) bv_impr_flags (new) bv_tech_flags changes to the network protocol ___ File Attachments: --- Date: Montag 26.07.2010 um 13:12 Na

[Freeciv-Dev] [patch #1766] remove TEST_BIT from server/score.c

2010-07-26 Thread Matthias Pfafferodt
etails: ___ File Attachments: --- Date: Montag 26.07.2010 um 13:12 Name: 20100726-17-trunk-remove-TEST_BIT-from-server-score.c.patch Size: 1kB By: syntron <http://gna.org/patch/download.ph

[Freeciv-Dev] [patch #1767] [players] fix bv_player in sdl client

2010-07-26 Thread Matthias Pfafferodt
an int was used for all_players in ./clinet/gui-sdl/gotodlg.c ___ File Attachments: --- Date: Montag 26.07.2010 um 13:13 Name: 20100726-18-trunk-fix-bv_player-in-sdl-client.patch Siz

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Matthias Pfafferodt
Update of patch #1732 (project freeciv): Depends on: => patch #1761 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1732 (project freeciv): some memory data (debug build; using pmap and the value for the total size): 1 player 30 player 126 player S2_2 34864K 77008K - svn17555 37336K 78640K - svn17568 41644K 83424K221

[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Lavrentij P Berija
Follow-up Comment #5, bug #16300 (project freeciv): Thanks, it worked out. Saving/loading games works OK, as far as I have tested. ___ Reply to this item at: ___

[Freeciv-Dev] [patch #1765] cleanup bitvectors

2010-07-26 Thread Marko Lindqvist
Follow-up Comment #1, patch #1765 (project freeciv): > bv_flags => bv_unit_flags This is unit type specific flags that unit has, right? When you are changing it, you should also make it clear that unit class specific flags are not here. __

[Freeciv-Dev] [patch #1765] cleanup bitvectors

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1765 (project freeciv): > This is unit type specific flags that unit has, right? When > you are changing it, you should also make it clear that unit > class specific flags are not here. I had to think some time to understand the request. Here is an updated patch: cl

[Freeciv-Dev] [patch #1765] cleanup bitvectors

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #1765 (project freeciv): it should be: bv_flags => bv_unit_type_flags bv_roles => bv_unit_type_roles ___ Reply to this item at: ___

[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats

2010-07-26 Thread anonymous
URL: Summary: Incorrect sabotage handling for diplomats Project: Freeciv Submitted by: None Submitted on: Monday 07/26/2010 at 19:31 CEST Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats

2010-07-26 Thread anonymous
Follow-up Comment #1, bug #16305 (project freeciv): Since I see nowhere in the rules/help that diplomats have half the success chance of spies, I figure this is a bug. Then again, it's kind of an obvious bug when you notice that sabotaging by diplomats fail very often, so maybe it's the security

[Freeciv-Dev] [patch #1768] [dbv] create new file ./utility/bitvector.(c|h)

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] create new file ./utility/bitvector.(c|h) Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority: 5 - No

[Freeciv-Dev] [patch #1769] [dbv] fix include of bitvector.h

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] fix include of bitvector.h Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1770] [dbv] dynamic bitvector (dbv)

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] dynamic bitvector (dbv) Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1771] [dbv] rename player_map_allocate() => player_map_init()

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] rename player_map_allocate() => player_map_init() Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority

[Freeciv-Dev] [patch #1772] [dbv] define an interface to call different functions at client and server

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] define an interface to call different functions at client and server Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general

[Freeciv-Dev] [patch #1773] [dbv] remove tile:tile_seen

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] remove tile:tile_seen Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1774] [dbv] remove tile:tile_known

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [dbv] remove tile:tile_known Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:24 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1775] [Metaticket] dynamic bitvector

2010-07-26 Thread Matthias Pfafferodt
URL: Summary: [Metaticket] dynamic bitvector Project: Freeciv Submitted by: syntron Submitted on: Montag 26.07.2010 um 22:27 Category: general Priority: 5 - Normal

[Freeciv-Dev] [patch #1775] [Metaticket] dynamic bitvector

2010-07-26 Thread Matthias Pfafferodt
Update of patch #1775 (project freeciv): Depends on: => patch #1768 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1775] [Metaticket] dynamic bitvector

2010-07-26 Thread Matthias Pfafferodt
Update of patch #1775 (project freeciv): Depends on: => patch #1732 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #1732 (project freeciv): additional data for the dynamic bitvector patch (it's for mapsize 30): 1 player 30 player 126 player S2_2 34864K 77008K - svn17555 37336K 78640K - svn17568 41644K 83424K221056K (

[Freeciv-Dev] [bug #16300] doesn't compile with --enable-debug

2010-07-26 Thread Jacob Nevins
Follow-up Comment #6, bug #16300 (project freeciv): This seems to be a FAQ on comp.lang.c... the consensus there seems to be that casting to (unsigned long), as file #9564 does, is OK for C90 implementations, since size_t is guaranteed to fit in that. That's not true for C99, but there you can us

[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats

2010-07-26 Thread Jacob Nevins
Follow-up Comment #2, bug #16305 (project freeciv): Well spotted. I suspect the difference in success probability between Diplomats and Spies is unintentional. I think it's been there at least since this area was last substantially modified in r9000, RT#11058

[Freeciv-Dev] [patch #1732] [Metaticket] increase number of players

2010-07-26 Thread Andreas Rosdal
Follow-up Comment #4, patch #1732 (project freeciv): Nice work, Matthias. The dynamic bitvector patch has pretty impressive memory usage now. ___ Reply to this item at: _

[Freeciv-Dev] [bug #16305] Incorrect sabotage handling for diplomats

2010-07-26 Thread Daniel Markstedt
Follow-up Comment #3, bug #16305 (project freeciv): I cannot remember a specific decision regarding diplomat vs spy success rates. Tried to look around a bit but couldn't find any reference. It is a tricky business though, balancing diplomats/spies. There was a time a few years ago when they wer

[Freeciv-Dev] [bug #16308] Great Wall protects wrong units

2010-07-26 Thread George Koehler
URL: Summary: Great Wall protects wrong units Project: Freeciv Submitted by: kernigh Submitted on: Tuesday 07/27/2010 at 01:10 Category: rulesets Severity: 3 - Normal