[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > > [EMAIL PROTECTED] - Mon Jun 16 01:14:01 2008]: > > 2008/6/15 Madeline Book: > > > > This gave me another idea along the same lines: PREREQS_KNOWN. > > I were worried this would turn out too long, but in the end I'm quite > happy with it. In addition to this change, I moved word "GOAL" before > modifier "PREREQS_KNOWN" or "UNKNOWN" in reqtree parts. Great, this makes the code both clearer and more uniform in its naming. > > It could also apply to player_invention_reachable() making it > > bool player_invention_prereqs_known(player, tech). > > There 'reachable' = 'ever reachable'. Ah yes... I have been confused by the old and new "reachable". ;) -- ご苦労さまでした ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > 2008/6/15 Madeline Book: > > This gave me another idea along the same lines: PREREQS_KNOWN. I were worried this would turn out too long, but in the end I'm quite happy with it. In addition to this change, I moved word "GOAL" before modifier "PREREQS_KNOWN" or "UNKNOWN" in reqtree parts. > It could also apply to player_invention_reachable() making it > bool player_invention_prereqs_known(player, tech). There 'reachable' = 'ever reachable'. - ML PlayerInventionReachable_40280-2.diff.bz2 Description: BZip2 compressed data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > > [EMAIL PROTECTED] - Sun Jun 15 19:07:47 2008]: > > Actually, HAS_PREREQS sounds like technology that has prereqs > defined, not one that somebody has prereqs researched for. Yes that ambiguity is a little annoying. :/ > How about PREREQS_OK? This gave me another idea along the same lines: PREREQS_KNOWN. It could also apply to player_invention_reachable() making it bool player_invention_prereqs_known(player, tech). - 面白くなっています。続きましょう！ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > > [EMAIL PROTECTED] - Sun Jun 15 14:01:02 2008]: > > Discussion about this started in #38372. > > Attached patch renames: > > TECH_REACHABLE -> TECH_PREREQS > COLOR_REQTREE_REACHABLE -> COLOR_REQTREE_PREREQS > COLOR_REQTREE_REACHABLE_GOAL -> COLOR_REQTREE_PREREQS_GOAL If the goal is to make the names more intuitive from the point of view of an English speaker, then in my opinion "HAS_PREREQS" (or maybe even "HAVE" to implicitly indicate that it is I/you/we the player that has the pre- requisites) would be a little clearer than just "PREREQS". Otherwise, I agree with the other changes and think they improve the readability especially for people reading that part of the code for the first time. -- だからいいと思います。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > 2008/6/15 Madeline Book: > If the goal is to make the names more intuitive from the > point of view of an English speaker, then in my opinion > "HAS_PREREQS" (or maybe even "HAVE" to implicitly > indicate that it is I/you/we the player that has the pre- > requisites) would be a little clearer than just "PREREQS". In some cases it refers to his tech, sometimes to mine. These are used both client and server side. How about PREREQS_OK? Actually, HAS_PREREQS sounds like technology that has prereqs defined, not one that somebody has prereqs researched for. As always, I very much prefer native speakers (or others speaking fluent English) to tell me how to name things. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#40280) [Patch] Renamed player_invention_is_ready
http://bugs.freeciv.org/Ticket/Display.html?id=40280 > Discussion about this started in #38372. Attached patch renames: player_invention_is_ready() -> player_invention_reachable() TECH_REACHABLE -> TECH_PREREQS COLOR_REQTREE_REACHABLE_GOAL -> COLOR_REQTREE_PREREQS_GOAL COLOR_REQTREE_UNREACHABLE_GOAL -> COLOR_REQTREE_UNKNOWN_GOAL COLOR_REQTREE_REACHABLE -> COLOR_REQTREE_PREREQS COLOR_REQTREE_UNREACHABLE -> COLOR_REQTREE_UNKNOWN and similar reqtree color changes for tilespec format and adds new reqtree color for really unreachable techs. - ML PlayerInventionReachable.diff.bz2 Description: BZip2 compressed data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
