[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-26 Thread Pepeto
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > [EMAIL PROTECTED] - Wed Jun 25 17:28:11 2008]: > > No. In fact it appears there is no game_info being received in pregame. > Right for 2.0. It appears too that there is no player_info being received in pregame. So game.nplayers stays to

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-25 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Pepeto wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > > I am not sure about it, but I think that the packet game_info is > received before the packet remove_player. This causes a invalid set of > game.nplayers: No. In fa

[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-25 Thread Pepeto
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > I am not sure about it, but I think that the packet game_info is received before the packet remove_player. This causes a invalid set of game.nplayers: game.nplayers = 1 game_info: set game.nplayers to 0 remove_player: renumbers players and d

[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Indeed, the same bug was present before but the symptoms were not as harsh. After the "fix" game.players[-1] gets entirely overwritten; before only some of it did, when game.nplayers dropped to negative in the client. The error seems to be

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Seems this IS bringing to light a major bug: game_renumber_players is being called and dropping the number of players below 0 in the client. This patch adds a very valid assert. It triggers when following the previous instructions. This

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > 2008/6/24 Jason Dorje Short: > > Marko - do you see this same error with an older S2_0 version, say, 14855? Yes - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/lis

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Marko Lindqvist wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > > 2008/6/24 Jason Dorje Short <[EMAIL PROTECTED]>: >> http://bugs.freeciv.org/Ticket/Display.html?id=40319 > >> >> Pepeto _ wrote: >> How do I reproduce i

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > 2008/6/24 Jason Dorje Short <[EMAIL PROTECTED]>: > > http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > > Pepeto _ wrote: > >>> How do I reproduce it? >> >> 1) Connect to a server. >> 2) Remove yourself via /remove. >> 3) send a chat li

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Pepeto _ wrote: >> How do I reproduce it? > > 1) Connect to a server. > 2) Remove yourself via /remove. > 3) send a chat line. Nothing. And no errors reported by valgrind. Can anyone else reproduce any errors here? -jason __

[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > [EMAIL PROTECTED] - Tue Jun 24 15:42:57 2008]: > > I can't reproduce this and it makes no sense that it would be caused > by PR#39745. It didn't occur before, and it does now. I don't know why. I think there is a more serious hidden probl

Re: [Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Pepeto _ wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40319 > > > When a player is removed, the client is disconnected the next time it > tried to send a packet to the server (e.g. chat or pong). The error > message prints: > 1: c

[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > When a player is removed, the client is disconnected the next time it tried to send a packet to the server (e.g. chat or pong). The error message prints: 1: cut connection server (connexion incomplète) due to huge send buffer (2) It's relate