[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Jacob Nevins]

Update of bug #21409 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Jacob Nevins]

Update of bug #21409 (project freeciv):

  Status: In Progress => Ready For Test 
Operating System:None => Any
 Planned Release: => 2.4.3, 2.5.0, 2.6.0

___

Follow-up Comment #6:

> the "Corruption" entry on the city dialog [...] would benefit 
> from becoming clickable and having a proper breakdown of 
> corruption effects (Courthouses, etc) under a separate ticket.
I left this ticket hanging in the hope of getting around to that, but I'm
clearly not doing so. I've raised patch #4706 as a placeholder for that and I
intend to commit these new patches (which are practically unchanged from the
previously posted one).

(file #20779, file #20780)
___

Additional Item Attachment:

File name: trunk-S2_5-notradesize-corruption-ui.patch Size:9 KB
File name: S2_4-notradesize-corruption-ui.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Jacob Nevins]

Follow-up Comment #5, bug #21409 (project freeciv):

Autogame testing with this patch (and notradesize=1, fulltradesize=2 to
exercise it) showed no difference from vanilla trunk.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Jacob Nevins]

Update of bug #21409 (project freeciv):

  Status:None => In Progress
 Assigned to:None => jtn

___

Follow-up Comment #4:

Here's a proof of concept patch (for trunk) that makes the "size penalty"
visible in the client.

It still needs some work before becoming a commit candidate:
* Autogame testing, since it has the potential to break the waste
calculation.
* Currently it shows up when you click on an output type, alongside
"Corruption", "Trade routes", etc. But the "Corruption" entry on the city
dialog is still not accounted for in this way, which is a bit annoying. That
would benefit from becoming clickable and having a proper breakdown of
corruption effects (Courthouses, etc) under a separate ticket. If/when that
happens, the "size penalty" should move there, and the city output breakdown
should just say "corruption" (with "size penalty" being understood to be a
form of corruption, and is referred to as such in too many places in the UI to
change).

(file #20181)
___

Additional Item Attachment:

File name: trunk-notradesize-corruption-ui-wip.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Jacob Nevins]

Follow-up Comment #3, bug #21409 (project freeciv):

So, how can we improve the UI?

The client clearly has the information to distinguish city-size-based trade
loss from 'real' corruption -- we can split it out from city_waste(). But
what's the patter?

The obvious gloss is that small cities just don't produce trade, but you can
see it coming off the land, so we need some explanation for where it goes
other than 'Corruption'.

I suppose we could just baldly say "Size penalty".

> btw what is the default value for server setting 'notradesize' ?
0.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[anonymous]

Follow-up Comment #2, bug #21409 (project freeciv):

Thank you, btw what is the default value for server setting 'notradesize' ?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21409] Notradesize disabled trade shown as corruption

[Marko Lindqvist]

Update of bug #21409 (project freeciv):

Category:rulesets => general
 Summary: V241 gtk - no research? => Notradesize disabled
trade shown as corruption

___

Follow-up Comment #1:

After debugging this a bit it turns out that server setting 'notradesize' is
at value 3, meaning that cities smaller than 4 get no trade at all. Notice
also how size 4 Torino actually gets 1 trade, but due to 60% tax, 40% sci, it
gets to treasury and not to research.

That explains the problem to the extend that freeciv "works as expected", but
I'm keeping this ticket open and retargeting to make user interface better -
"no trade" should not be counted as corruption.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev