Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/11/07, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > On 6/11/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > > > On Sun, 10 Jun 2007, Vasco Alexandre da Silva Costa wrote: > > >>> What version of gcc/platform are you using? I don't get these errors... > > >> > > >> I use Fedora 7. > > >> > > >> [EMAIL PROTECTED] ~]$ gcc --version > > >> gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12) > > >> > > > > > > Is this a X86-64 platform perchance? > > > > Yes. > > > >- Per > > I studied this a bit a couple of months back. There should be old > ticket for this. I believe the warnings are about pointers cast to ints or back. This is used by some tricks with pointer tables, which I guess are used by some interpreters. If 32-bit pointers are being cast to 32-bit ints, it works. But if 64-bit pointers are being cast to 32-bits, there is not enough space to fit the data. A 64-bit int type should be used then. Even better, since we use C99, intptr_t or uintptr_t can be used. Of course, if the Lua people fixed this, we probably should just upgrade. Otherwise we should fix it and give them a patch. -- Vasco Alexandre da Silva Costa ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/11/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > On Sun, 10 Jun 2007, William Allen Simpson wrote: > > But since getting various reports of warnings turning into fatal errors, > > probably should upgrade the entire lua package. > > Anyone know which version we have in our repository? It does not say. PR#12706: Add lua 5.0.2 and tolua 5.0 to the dependencies directory. > > I'll note that included gettext is pretty old, too. > > I think we should just remove it. I do not think anyone use it. People > either have gettext in their system, or just get it included with their > binary download. Agreed. > Speaking of gettext, in recent versions it now has support for qualified > strings. However, their solution is rather different than ours. We may > want to convert eventually. > > -- Vasco Alexandre da Silva Costa ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/11/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > On Sun, 10 Jun 2007, Vasco Alexandre da Silva Costa wrote: > >>> What version of gcc/platform are you using? I don't get these errors... > >> > >> I use Fedora 7. > >> > >> [EMAIL PROTECTED] ~]$ gcc --version > >> gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12) > >> > > > > Is this a X86-64 platform perchance? > > Yes. > >- Per I studied this a bit a couple of months back. There should be old ticket for this. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On Sun, 10 Jun 2007, William Allen Simpson wrote: > But since getting various reports of warnings turning into fatal errors, > probably should upgrade the entire lua package. Anyone know which version we have in our repository? It does not say. > I'll note that included gettext is pretty old, too. I think we should just remove it. I do not think anyone use it. People either have gettext in their system, or just get it included with their binary download. Speaking of gettext, in recent versions it now has support for qualified strings. However, their solution is rather different than ours. We may want to convert eventually. - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On Sun, 10 Jun 2007, Vasco Alexandre da Silva Costa wrote: >>> What version of gcc/platform are you using? I don't get these errors... >> >> I use Fedora 7. >> >> [EMAIL PROTECTED] ~]$ gcc --version >> gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12) >> > > Is this a X86-64 platform perchance? Yes. - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > I don't get those warnings/errors, either. Of course, I'm running gcc 3.3 on a G5 -- gcc 4.1 itself won't even compile on this system, something wrong with the register assignment last time I checked (months ago). But since getting various reports of warnings turning into fatal errors, probably should upgrade the entire lua package. Especially as lua isn't really used for much yet. Nip the problem in the bud. Assuming the new version doesn't have bigger and better errors. I'll note that included gettext is pretty old, too. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > On Sun, 10 Jun 2007, Jason Short wrote: > On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > >> How should we fix these? Modify lua code in repository, or try to > upgrade > >> it to a more recent lua version? > > > > Would upgrading help? Anyone tried compiling a more recent lua with > > all the -W parameters we use? > > > > What version of gcc/platform are you using? I don't get these errors... > > I use Fedora 7. > > [EMAIL PROTECTED] ~]$ gcc --version > gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12) > Is this a X86-64 platform perchance? 'uname -a' -- Vasco Alexandre da Silva Costa On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: http://bugs.freeciv.org/Ticket/Display.html?id=39391 >On Sun, 10 Jun 2007, Jason Short wrote:On 6/10/07, Per I. Mathisen < [EMAIL PROTECTED]> wrote:>> How should we fix these? Modify lua code in repository, or try to upgrade>> it to a more recent lua version?>> Would upgrading help? Anyone tried compiling a more recent lua with > all the -W parameters we use?>> What version of gcc/platform are you using? I don't get these errors...I use Fedora 7.[EMAIL PROTECTED] ~]$ gcc --versiongcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12)Is this a X86-64 platform perchance?'uname -a'-- Vasco Alexandre da Silva Costa ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On Sun, 10 Jun 2007, Jason Short wrote: On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: >> How should we fix these? Modify lua code in repository, or try to upgrade >> it to a more recent lua version? > > Would upgrading help? Anyone tried compiling a more recent lua with > all the -W parameters we use? > > What version of gcc/platform are you using? I don't get these errors... I use Fedora 7. [EMAIL PROTECTED] ~]$ gcc --version gcc (GCC) 4.1.2 20070502 (Red Hat 4.1.2-12) - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39391) Warnings in lua code
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > cc1: warnings being treated as errors > ltable.c: In function ‘luaH_mainposition’: > ltable.c:108: warning: cast from pointer to integer of different size > ltable.c:110: warning: cast from pointer to integer of different size > make[5]: *** [ltable.o] Error 1 > make[5]: Leaving directory `/home/devel/freeciv/dependencies/lua/src' > > How should we fix these? Modify lua code in repository, or try to upgrade > it to a more recent lua version? Would upgrading help? Anyone tried compiling a more recent lua with all the -W parameters we use? What version of gcc/platform are you using? I don't get these errors... -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
