Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-27 Thread Egor Vyscrebentsov

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

On Wed, 26 Sep 2007 22:52:56 -0700 Daniel Markstedt wrote:

> On 9/27/07, Uğur Çetin  wrote:
> >
> > 27-09-2007 07:18 Daniel Markstedt:
> > > And what about leaving it as it was: "Osman Gazi" and keeping "Bey " as
> > > title.
> >
> > It won't look meaningful because we use "Bey" after a name, not before it. 
> > It
> > will look like writing "Smith Mr." in English if we write "Bey Osman" or 
> > "Bey
> > Osman Gazi".
> 
> This is true for a number of other nations; right now I can think of
> "Khan" in Mongolian et.al. and "Koku-o"/"Jo-o" in Ryukyuan.
> 
> Adding support for appended ruler titles would be a nice nighttime
> project for someone. ;)

So, what do you want? A function which will return string contains
leader name and title in proper order?

-- 
Thanks, evyscr



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-26 Thread Daniel Markstedt

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

On 9/27/07, Uğur Çetin <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39720 >
>
> 27-09-2007 07:18 Daniel Markstedt:
> > > > Good. Only problem here is that "Osman Bey" in a despotist gov will
> > > > appear as "Bey Osman Bey". Does this look ok in Turkish?
> > >
> > > No, It doesn't look okay. Actually "Bey" should be appended to ruler's
> > > name, not prepended.
> > >
> > > So, if it can be configured to append, we should remove "Bey" from "Osman
> > > Bey". If not, "Bey" shouldn't be a title. (btw. "Bey" means "mister" in
> > > Turkish with one little difference that it sholud be appended to a name)
> >
> > (...)
> >
> > And what about leaving it as it was: "Osman Gazi" and keeping "Bey " as
> > title.
>
> It won't look meaningful because we use "Bey" after a name, not before it. It
> will look like writing "Smith Mr." in English if we write "Bey Osman" or "Bey
> Osman Gazi".
>
> --
> Uğur Çetin
>
>
>

This is true for a number of other nations; right now I can think of
"Khan" in Mongolian et.al. and "Koku-o"/"Jo-o" in Ryukyuan.

Adding support for appended ruler titles would be a nice nighttime
project for someone. ;)

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-26 Thread Uğur Çetin

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

27-09-2007 07:18 Daniel Markstedt:
> > > Good. Only problem here is that "Osman Bey" in a despotist gov will
> > > appear as "Bey Osman Bey". Does this look ok in Turkish?
> >
> > No, It doesn't look okay. Actually "Bey" should be appended to ruler's
> > name, not prepended.
> >
> > So, if it can be configured to append, we should remove "Bey" from "Osman
> > Bey". If not, "Bey" shouldn't be a title. (btw. "Bey" means "mister" in
> > Turkish with one little difference that it sholud be appended to a name)
>
> (...)
>
> And what about leaving it as it was: "Osman Gazi" and keeping "Bey " as
> title.

It won't look meaningful because we use "Bey" after a name, not before it. It 
will look like writing "Smith Mr." in English if we write "Bey Osman" or "Bey 
Osman Gazi".

-- 
Uğur Çetin



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-26 Thread Daniel Markstedt

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

On 9/27/07, Uğur Çetin <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39720 >
>
> 27-09-2007 06:24 Daniel Markstedt:
> > As Daniil is saying, this is to avoid the scenario of having both the
> > Turks and the Ottomans from the beginning of a game. If you want them
> > to civil war to each other, that's ok.
>
> I now agree that it should stand as it was before. Two nations are for
> different eras.
>
> > Good. Only problem here is that "Osman Bey" in a despotist gov will
> > appear as "Bey Osman Bey". Does this look ok in Turkish?
>
> No, It doesn't look okay. Actually "Bey" should be appended to ruler's name,
> not prepended.
>
> So, if it can be configured to append, we should remove "Bey" from "Osman
> Bey". If not, "Bey" shouldn't be a title. (btw. "Bey" means "mister" in
> Turkish with one little difference that it sholud be appended to a name)
>
(...)

And what about leaving it as it was: "Osman Gazi" and keeping "Bey " as title.

 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-26 Thread Uğur Çetin

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

27-09-2007 06:24 Daniel Markstedt:
> As Daniil is saying, this is to avoid the scenario of having both the
> Turks and the Ottomans from the beginning of a game. If you want them
> to civil war to each other, that's ok.

I now agree that it should stand as it was before. Two nations are for 
different eras.

> Good. Only problem here is that "Osman Bey" in a despotist gov will
> appear as "Bey Osman Bey". Does this look ok in Turkish?

No, It doesn't look okay. Actually "Bey" should be appended to ruler's name, 
not prepended.

So, if it can be configured to append, we should remove "Bey" from "Osman 
Bey". If not, "Bey" shouldn't be a title. (btw. "Bey" means "mister" in 
Turkish with one little difference that it sholud be appended to a name)

> Quality work!

Thanks for the review.

-- 
Uğur Çetin



signature.asc
Description: PGP signature
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-26 Thread Daniel Markstedt

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

On 9/24/07, Uğur Çetin <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39720 >
>
> Hi,
>
> This morning I read some Turkish history sites to refresh my elementary school
> memories and come up with this ottoman patch at the end(patch is aganist
> trunk). Changes:
>
> * Removed conflict with Turks (I'm not sure about that. I just didn't see any
> reason for this conflict.)

As Daniil is saying, this is to avoid the scenario of having both the
Turks and the Ottomans from the beginning of a game. If you want them
to civil war to each other, that's ok.

Note that even if two nations 'conflicts' with each other, you can
still select both manually in pregame. It only stops the automatic
selection of both.

> * Updated leader names with their original in Latin letters (also added first
> founder Ertuğrul Gazi)

Good. Only problem here is that "Osman Bey" in a despotist gov will
appear as "Bey Osman Bey". Does this look ok in Turkish?

> * Updated ( or downdate :) ) city names with their original in Ottoman Empire
> and sorted them with historical conquest/foundation order.
> * Fixed a little typo and some tab characters
>
> Review please...
>
> --
> Uğur Çetin
>

Quality work!

Thanks,
 ~Daniel



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#39720) ottoman nation patch

2007-09-23 Thread Daniil Ivanov

http://bugs.freeciv.org/Ticket/Display.html?id=39720 >

The reason for that conflict is Turkey was part of Ottoman Empire and
they never coexist. The same as for Russia and Soviet Union.

Thanks, Daniil.

On 23/09/2007, Uğur Çetin <[EMAIL PROTECTED]> wrote:
>
> http://bugs.freeciv.org/Ticket/Display.html?id=39720 >
>
> Hi,
>
> This morning I read some Turkish history sites to refresh my elementary school
> memories and come up with this ottoman patch at the end(patch is aganist
> trunk). Changes:
>
> * Removed conflict with Turks (I'm not sure about that. I just didn't see any
> reason for this conflict.)
> * Updated leader names with their original in Latin letters (also added first
> founder Ertuğrul Gazi)
> * Updated ( or downdate :) ) city names with their original in Ottoman Empire
> and sorted them with historical conquest/foundation order.
> * Fixed a little typo and some tab characters
>
> Review please...
>
> --
> Uğur Çetin
>
>
> ___
> Freeciv-dev mailing list
> Freeciv-dev@gna.org
> https://mail.gna.org/listinfo/freeciv-dev
>
>
>



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev