Re: [Freeipa-devel] [PATCH] 297 Fixed enroll labels.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 07:44 PM, Endi Sukma Dewata wrote: On 10/26/2011 7:09 AM, Petr Vobornik wrote: 1) add_dialog was renamed to entity_adder_dialog but its method add_dialog_create wasn't renamed Fixed. ACK -- Petr Vobornik ___ Freeipa-devel mailing

Re: [Freeipa-devel] [PATCH] 300 Refactored validation code.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 08:09 PM, Endi Sukma Dewata wrote: The validation code in details facet, dialog, and sections have been modified to work more consistently. This is required by patch #301. ACK -- Petr Vobornik ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 301 Added password field in user adder dialog.

2011-10-27 Thread Petr Vobornik
On 10/26/2011 08:11 PM, Endi Sukma Dewata wrote: The user adder dialog has been modified to provide optional fields to specify password during user creation. Ticket #1646 1) message in: 'field2.show_error('Passwords do not match');' should use translated string. -- Petr Vobornik

Re: [Freeipa-devel] [PATCH] 900 fix users in nis netgroup

2011-10-27 Thread Martin Kosek
On Wed, 2011-10-26 at 18:06 -0400, Rob Crittenden wrote: Users weren't appearing in ypcat output in the netgroup map due to a syntax error. This patch should fix new and existing installations. rob ACK. Works great for both update and new installations. Pushed to master, ipa-2-1. Martin

Re: [Freeipa-devel] [PATCH] 302 Fixed inconsistent image names.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 12:31 AM, Endi Sukma Dewata wrote: The images have been renamed to be more consistent and moved into the images directory to mimic the original jQuery UI structure. Ticket #1613 ACK -- Petr Vobornik ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 156 Create pkey-only option for find commands

2011-10-27 Thread Martin Kosek
On Wed, 2011-10-26 at 14:07 -0500, Endi Sukma Dewata wrote: On 10/26/2011 1:43 PM, Martin Kosek wrote: I think we probably need 2 different size limits: one for regular queries (set on LDAP server) and the other for pulling primary keys (maintained by IPA server). Suppose we have a

Re: [Freeipa-devel] [PATCH] 303 Fixed inconsistent details facet validation.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 01:39 AM, Endi Sukma Dewata wrote: The details facet validation has been moved out of update() such that all subclasses perform consistent validation. Ticket #1455 ACK with a small doubt. I'm not sure if moving the validation call to update button's click handler is the right

[Freeipa-devel] [PATCH] 029 Page is cleared before it is visible

2011-10-27 Thread Petr Vobornik
https://fedorahosted.org/freeipa/ticket/1459 Changes: * added clear method to widgets, section, search, details, association facets * clear method in facet is called only if key/filter was changed -- Petr Vobornik From 22d6ba37f74ec40a8223082b8f6869ec9f1155a5 Mon Sep 17 00:00:00 2001 From:

[Freeipa-devel] [PATCH] 56 Add new Param method for marshalling values from complex data types

2011-10-27 Thread Jan Cholasta
Add new Param method for marshalling values from complex data types to primitive data types suitable for transmission over RPC. This change makes it possible to use complex data types (like python-netaddr IPAddress) in parameters. https://fedorahosted.org/freeipa/ticket/2033 This will help

Re: [Freeipa-devel] [PATCH] 880 don't check for existing 389-ds instances

2011-10-27 Thread Martin Kosek
On Fri, 2011-10-21 at 15:29 -0400, Rob Crittenden wrote: Rob Crittenden wrote: We don't need to prohibit existing 389-ds instances when installing IPA, just that the ports we need are available. Remove this check. For master only. rob Re-based patch against master. rob Works

Re: [Freeipa-devel] ipalib vs. ipapython?

2011-10-27 Thread Rob Crittenden
Adam Young wrote: On 10/25/2011 05:24 PM, John Dennis wrote: Usually when I look at a source code directory layout it's fairly obvious what belongs in each directory. I'll be honest, I've never quite understood the role of ipapython vs. ipalib. From time to time I have to do some code

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Petr Vobornik
I'll rebase this patch on recent patches (which will be soon pushed). This effort is doing too many things, I'll split the patch into several. On 10/25/2011 07:57 PM, Endi Sukma Dewata wrote: On 10/25/2011 7:49 AM, Petr Vobornik wrote: 2. The set_facet() is added to widget. I don't think we

Re: [Freeipa-devel] [PATCH] 297 Fixed enroll labels.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 2:07 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 299 Merged widget's metadata and param_info.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 2:22 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 302 Fixed inconsistent image names.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 3:36 AM, Petr Vobornik wrote: ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 156 Create pkey-only option for find commands

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 3:39 AM, Martin Kosek wrote: IIUC your idea is to have 2 new config-mod options like this: # ipa config-show --all ... Search time limit: 2 Search size limit: 100 Search time limit with pkey-only: 10 Search size limit with pkey-only: 5000 Hm, I am still not sold for

Re: [Freeipa-devel] [PATCH] 301 Added password field in user adder dialog.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 2:58 AM, Petr Vobornik wrote: 1) message in: 'field2.show_error('Passwords do not match');' should use translated string. Fixed. I'm considering to move the password fields into a reusable section, but that will be a separate issue. -- Endi S. Dewata From

Re: [Freeipa-devel] [PATCH] 301 Added password field in user adder dialog.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 04:59 PM, Endi Sukma Dewata wrote: On 10/27/2011 2:58 AM, Petr Vobornik wrote: 1) message in: 'field2.show_error('Passwords do not match');' should use translated string. Fixed. I'm considering to move the password fields into a reusable section, but that will be a separate

Re: [Freeipa-devel] [PATCH] 303 Fixed inconsistent details facet validation.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 4:29 AM, Petr Vobornik wrote: ACK with a small doubt. I'm not sure if moving the validation call to update button's click handler is the right move. I think, this way the handler is doing more things than it should do. However I'm fond of changing the update method to be more

[Freeipa-devel] Extending the IPA-API

2011-10-27 Thread Adam Young
We had a pretty good discussion about the apporach we are looking at to allow end sites to extend their IPA implementations without getting in the way of upgrades etc. Here are some of the things I took away from that meeting. We want to maintain the namespace as it is. A site might decide

[Freeipa-devel] minimum python?

2011-10-27 Thread John Dennis
So I looked in our freeipa spec file and I didn't see a minimum Python version specified. Do we have a minimum version of Python we require to run? Do we just make the assumption it's 2.6 since that's what's in RHEL? I also assume that means any Python feature added in 2.7 cannot be used,

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 8:39 AM, Petr Vobornik wrote: But still I think it would be better to be able to get container (facet/dialog) for a widget. As you wrote, that.entity.get_facet() may not always be what we want. One possibility is to convert the facet dialog into subclasses of an abstract

Re: [Freeipa-devel] minimum python?

2011-10-27 Thread Rob Crittenden
John Dennis wrote: So I looked in our freeipa spec file and I didn't see a minimum Python version specified. Do we have a minimum version of Python we require to run? Do we just make the assumption it's 2.6 since that's what's in RHEL? I also assume that means any Python feature added in 2.7

Re: [Freeipa-devel] minimum python?

2011-10-27 Thread Alexander Bokovoy
On Thu, 27 Oct 2011, John Dennis wrote: So I looked in our freeipa spec file and I didn't see a minimum Python version specified. Do we have a minimum version of Python we require to run? Do we just make the assumption it's 2.6 since that's what's in RHEL? Yes. I'm not sure we tried hard to

Re: [Freeipa-devel] [PATCH] 028 Code cleanup of HBAC, Sudo rules

2011-10-27 Thread Adam Young
On 10/27/2011 05:51 PM, Endi Sukma Dewata wrote: On 10/27/2011 8:39 AM, Petr Vobornik wrote: But still I think it would be better to be able to get container (facet/dialog) for a widget. As you wrote, that.entity.get_facet() may not always be what we want. One possibility is to convert the

Re: [Freeipa-devel] Extending the IPA-API

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 10:59 AM, Adam Young wrote: The web UI can implement a similar mechanism. We do not want end sites modifying the .js files shipped with the IPA server RPM, other wise, they could inject columns and fields there, but they would be susceptible to breaking during upgrade. Instead, we