[Freeipa-devel] [DESIGN] IPA client in AD DNS domain

2016-05-19 Thread Alexander Bokovoy
Hi, A new design page is ready for review: http://www.freeipa.org/page/V4/IPA_Client_in_Active_Directory_DNS_domain Below is the text for convenience. I did test both scenarios successfully. Single sign-on scenario: - Client has A/ record in IDM DNS domain and CNAME record in AD DNS domain

[Freeipa-devel] [PATCH 0146-0147] Server Roles: basic infrastructure

2016-05-19 Thread Martin Babinsky
Patch 0146 implements lower-lever infrastructure for querying server roles/attributes Patch 0147 are some basic tests slapped together for the `serverroles` backend to ensure that it works as expected. The new/modified CLI commands specified in the design page [1] will be coming soon. Also

Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set

2016-05-19 Thread Ganna Kaihorodova
Hello! Everything is ok, so ack Best regards, Ganna Kaihorodova Associate Software Quality Engineer - Original Message - From: "Lenka Doudova" To: "Ganna Kaihorodova" Cc: freeipa-devel@redhat.com Sent: Thursday, May 19, 2016 12:42:34 PM Subject: Re: [Freeipa-devel] [TESTS]{PATCH 0013]

Re: [Freeipa-devel] [PATCH 556] makeapi: use the same formatting for `int` and `long` values

2016-05-19 Thread Martin Basti
On 19.05.2016 16:43, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Pushed to: master: 83f6ddb473156c0eb1d85f98a7eb2997e7b70dc5 ipa-4-3: f8edf37e9544e319adfff75ba87df826bb1ca42e -- Manage your subscription for the Freeipa-deve

[Freeipa-devel] [PATCH 556] makeapi: use the same formatting for `int` and `long` values

2016-05-19 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 42ddc01aecf3bfd84f3b4c6afc07e962f0555031 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Thu, 19 May 2016 16:24:47 +0200 Subject: [PATCH] makeapi: use the same formatting for `int` and `lo

Re: [Freeipa-devel] [PATCH 554] build: fix client-only build

2016-05-19 Thread Martin Basti
On 19.05.2016 14:14, Jan Cholasta wrote: On 19.5.2016 13:30, Jan Cholasta wrote: On 19.5.2016 10:38, Martin Babinsky wrote: On 05/19/2016 10:34 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Self-NACK, I have just noti

Re: [Freeipa-devel] [PATCH 0112] pylint: replace Refactor category with individual check name

2016-05-19 Thread Martin Basti
On 19.05.2016 14:26, Petr Spacek wrote: Hello, pylint: replace Refactor category with individual check names This eases enabling/disabling individual tests like cyclic-import. I like this patch but, NACK . * Module ipalib.config ipalib/config.py:260: [R0204(redefined-v

[Freeipa-devel] [PATCH 0112] pylint: replace Refactor category with individual check name

2016-05-19 Thread Petr Spacek
Hello, pylint: replace Refactor category with individual check names This eases enabling/disabling individual tests like cyclic-import. -- Petr^2 Spacek From 76b008d10433bf7c791a3422ca0afbc2552834cf Mon Sep 17 00:00:00 2001 From: Petr Spacek Date: Thu, 19 May 2016 14:25:31 +0200 Subject: [PATC

Re: [Freeipa-devel] [PATCH 554] build: fix client-only build

2016-05-19 Thread Jan Cholasta
On 19.5.2016 13:30, Jan Cholasta wrote: On 19.5.2016 10:38, Martin Babinsky wrote: On 05/19/2016 10:34 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Self-NACK, I have just noticed that the client-only build fails without 3

Re: [Freeipa-devel] [PATCH 553] spec file: bump minimum required pki-core version

2016-05-19 Thread Jan Cholasta
On 19.5.2016 10:35, Martin Babinsky wrote: On 05/19/2016 10:20 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Thanks. Pushed to: master: 1276083d95b41c91796cae9f8635fa4c89635bbd ipa-4-2: bd5abb444cd5099f90471f9121b37ce19b36

Re: [Freeipa-devel] [PATCH 0477] upgrade: always start CA

2016-05-19 Thread Stanislav Laznicka
Also, I tried to upgrade from 4.2.4 to 4.3.1 and it seems that it might be necessary to start the service even earlier in the upgrade logic. Attached is the trace that occurred during the upgrade. I sent the whole log earlier accidentally, hopefully it will not arrive here as well. On 05/19/

Re: [Freeipa-devel] [PATCH] 0057..0058 Fix caIPAserviceCert regression

2016-05-19 Thread Jan Cholasta
On 19.5.2016 13:03, Fraser Tweedale wrote: On Thu, May 19, 2016 at 09:52:08AM +0200, Jan Cholasta wrote: On 19.5.2016 01:31, Fraser Tweedale wrote: On Wed, May 18, 2016 at 03:17:37PM +0200, Jan Cholasta wrote: Hi, On 18.5.2016 08:09, Fraser Tweedale wrote: Rebased version of 0057 attached, a

Re: [Freeipa-devel] [PATCH 554] build: fix client-only build

2016-05-19 Thread Jan Cholasta
On 19.5.2016 10:38, Martin Babinsky wrote: On 05/19/2016 10:34 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK Self-NACK, I have just noticed that the client-only build fails without 389-ds-base-devel installed. -- Jan Cho

Re: [Freeipa-devel] [PATCH] 0057..0058 Fix caIPAserviceCert regression

2016-05-19 Thread Fraser Tweedale
On Thu, May 19, 2016 at 09:52:08AM +0200, Jan Cholasta wrote: > On 19.5.2016 01:31, Fraser Tweedale wrote: > > On Wed, May 18, 2016 at 03:17:37PM +0200, Jan Cholasta wrote: > > > Hi, > > > > > > On 18.5.2016 08:09, Fraser Tweedale wrote: > > > > Rebased version of 0057 attached, along with new pat

Re: [Freeipa-devel] [Testplan Review]

2016-05-19 Thread Petr Vobornik
On 05/19/2016 12:38 PM, Oleg Fayans wrote: > Hi all, > > I've created the first versio of the testplan for Topology Management > feature in 4.4 release: > http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan > > Could someone please review it? > I'll mention what are the imp

Re: [Freeipa-devel] [DESIGN-REVIEW] V4/Manage_replication_topology_4_4

2016-05-19 Thread Petr Vobornik
On 05/19/2016 08:45 AM, Oleg Fayans wrote: > Hi Martin, > > I should probably rephrase my question: will the server_del API call be > added to 'ipa-server-install --uninstall' within 4.4 or is it a more > distant plan? It will be added in 4.4. Martin 3 is working on it. http://www.freeipa.org/pa

Re: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set

2016-05-19 Thread Lenka Doudova
On 05/18/2016 01:51 PM, Ganna Kaihorodova wrote: - Original Message - From: "Lenka Doudova" To: "Ganna Kaihorodova" Sent: Wednesday, May 18, 2016 10:37:49 AM Subject: Fwd: [Freeipa-devel] [TESTS]{PATCH 0013] Maximum username length higher than 255 cannot be set Forwarded

[Freeipa-devel] [Testplan Review]

2016-05-19 Thread Oleg Fayans
Hi all, I've created the first versio of the testplan for Topology Management feature in 4.4 release: http://www.freeipa.org/page/V4/Manage_replication_topology_4_4/Test_Plan Could someone please review it? -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for t

Re: [Freeipa-devel] [PATCH 0477] upgrade: always start CA

2016-05-19 Thread Stanislav Laznicka
NACK, see my comments below +# following upgrade steps require running CA This is a nitpicky nitpick but could you please change this comment for # the following ... Took me a while to understand what you were trying to say here. +if ca_running and not ca.is_running(): +ca.sto

Re: [Freeipa-devel] [PATCH 554] build: fix client-only build

2016-05-19 Thread Martin Babinsky
On 05/19/2016 10:34 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeI

Re: [Freeipa-devel] [PATCH 553] spec file: bump minimum required pki-core version

2016-05-19 Thread Martin Babinsky
On 05/19/2016 10:20 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK -- Martin^3 Babinsky -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeI

[Freeipa-devel] [PATCH 554] build: fix client-only build

2016-05-19 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 47ab6ccda11061c39ac5b29409c9237b78630f59 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Fri, 13 May 2016 08:40:53 +0200 Subject: [PATCH] build: fix client-only build https://fedorahosted

[Freeipa-devel] [PATCH 553] spec file: bump minimum required pki-core version

2016-05-19 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From a6465d4dd56cdfd51378ca6f840fe378029c3ae3 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Thu, 19 May 2016 10:03:54 +0200 Subject: [PATCH] spec file: bump minimum required pki-core version

Re: [Freeipa-devel] [PATCH 0483] fix referenced before assignment error in baseldap

2016-05-19 Thread Stanislav Laznicka
ACK On 05/18/2016 07:24 PM, Martin Basti wrote: Patch attached -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 0057..0058 Fix caIPAserviceCert regression

2016-05-19 Thread Jan Cholasta
On 19.5.2016 01:31, Fraser Tweedale wrote: On Wed, May 18, 2016 at 03:17:37PM +0200, Jan Cholasta wrote: Hi, On 18.5.2016 08:09, Fraser Tweedale wrote: Rebased version of 0057 attached, along with new patch 0058 that detects when the Dogtag version of caIPAserviceCert has been erroneously impo

Re: [Freeipa-devel] [PATCH 0032] Remove dangling RUVs even if replicas are offline

2016-05-19 Thread Stanislav Laznicka
On 05/19/2016 08:52 AM, Ludwig Krispenz wrote: On 05/19/2016 08:02 AM, Stanislav Laznicka wrote: On 05/18/2016 04:44 PM, Petr Vobornik wrote: On 05/18/2016 04:36 PM, Stanislav Laznicka wrote: There's no ticket for this patch but as there was a fix to 389-ds mentioned in https://fedorahosted.o