Re: [Freeipa-devel] [PATCH] 0033 webui: Mention SAN names in 'Issue new certificate'

On Fri, Jun 03, 2016 at 05:17:12PM +0200, Petr Vobornik wrote: > On 05/10/2016 04:52 PM, Pavel Vomacka wrote: > > Hi all, > > > > please review the patch for webUI which adds SAN names into 'Issue new > > certificate' dialog. The SAN names are mentioned only in dialogs for > > requesting for host

[Freeipa-devel] [PATCH] 958 admintools: missing python3-ipaclient dependency

admintools doesn't pull python[2|3]-ipaclient by default which ends with exception if CLI is used. -- Petr Vobornik From 8342e64430949bf66b6f7254d3a432f875023842 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Fri, 3 Jun 2016 18:26:25 +0200 Subject: [PATCH] admintools:

[Freeipa-devel] [PATCH] script for provisioning

Hello, A performance bottleneck during provisioning was described http://www.freeipa.org/page/V4/Performance_Improvements#typical_provisioning:_ldapadd_entries.2C_migrate-ds... I wrote the attached script that is following http://www.freeipa.org/page/V4/Performance_Improvements#Algorithm

[Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

I am sending rebased patches implementing http://www.freeipa.org/page/V4/Server_Roles I hope the patches work since I have had a lot of fun rebasing them on top of thin client and DNS locations effort. https://fedorahosted.org/freeipa/ticket/5181 -- Martin^3 Babinsky From

Re: [Freeipa-devel] [PATCH] 0033 webui: Mention SAN names in 'Issue new certificate'

On 05/10/2016 04:52 PM, Pavel Vomacka wrote: > Hi all, > > please review the patch for webUI which adds SAN names into 'Issue new > certificate' dialog. The SAN names are mentioned only in dialogs for > requesting for host and service certificate, according to the design page: >

Re: [Freeipa-devel] [PATCH 0149-0152] Server Roles: user-facing part

On 05/30/2016 07:13 PM, Martin Babinsky wrote: These patches implement the usable part of Server Roles design. There might be some discrepancies between the design and actual implementation, I was head first in hacking and was not very disciplined in keeping the design up to date. I will fix

Re: [Freeipa-devel] [PATCH 0146-0147] Server Roles: basic infrastructure

On 05/19/2016 04:59 PM, Martin Babinsky wrote: Patch 0146 implements lower-lever infrastructure for querying server roles/attributes Patch 0147 are some basic tests slapped together for the `serverroles` backend to ensure that it works as expected. The new/modified CLI commands specified in

Re: [Freeipa-devel] [PATCH] 0035: webui: change Restore cert to Remove cert hold

On 05/20/2016 01:17 PM, Pavel Vomacka wrote: > Hi, > > please review attached patch. It change Restore certificate strings to > Remove certificate hold to be consistent with CLI. > > https://fedorahosted.org/freeipa/ticket/5878 > > -- > > Pavel^3 Vomacka > > ACK rebased (internal.py move)

Re: [Freeipa-devel] [PATCH] 0032 webui: change lang.hitch to the javascript bind method

On 04/29/2016 03:15 PM, Pavel Vomacka wrote: > Hi, > > please review the attached patch. > > https://fedorahosted.org/freeipa/ticket/5702 > > -- > > Pavel^3 Vomacka > ACK pushed to master: * b16e59bdaa4acba7b8a190a4ca32b7a113b32cd1 Change lang.hitch to javascript bind method -- Petr

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

On 06/03/2016 08:27 AM, Pavel Vomacka wrote: > > > On 06/02/2016 06:45 PM, Petr Vobornik wrote: >> On 04/20/2016 07:05 PM, Pavel Vomacka wrote: >>> On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: > Hello, > > This patch adds ability to

Re: [Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

On 3.6.2016 12:51, Martin Basti wrote: > > > On 03.06.2016 08:53, Petr Spacek wrote: >> On 2.6.2016 17:53, Martin Basti wrote: >>> Typo - redundant ' ' at the end. Conditional NACK, warnings mentioned in

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

On 03.06.2016 15:10, Petr Vobornik wrote: On 06/02/2016 01:40 PM, Pavel Vomacka wrote: Hello, please review my patches which add webui for server roles. Did not test yet. I'm waiting for rebase of backend. Patch 36: ACK (assuming it works when ^^ is available) Patch 37: 1. typo:

Re: [Freeipa-devel] [PATCH] Fix minor typo

On 03.06.2016 15:20, Yuri Chornoivan wrote: Hi, There is a minor typo in one of the FreeIPA user visible messages: "you OTP device" -> "your OTP device". Thanks for fixing it. Best regards, Yuri Thank you! ACK Pushed to master: fd4386d5c98e4b823a9f05e18c8b0db857bf1284 -- Manage

Re: [Freeipa-devel] [PATCH] Fix minor typo

On 06/03/2016 06:50 PM, Yuri Chornoivan wrote: Hi, There is a minor typo in one of the FreeIPA user visible messages: "you OTP device" -> "your OTP device". Thanks for fixing it. Best regards, Yuri LGTM -- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io -- Manage

Re: [Freeipa-devel] [PATCH 0032] Remove dangling RUVs even if replicas are offline

On 19.05.2016 09:30, Stanislav Laznicka wrote: On 05/19/2016 08:52 AM, Ludwig Krispenz wrote: On 05/19/2016 08:02 AM, Stanislav Laznicka wrote: On 05/18/2016 04:44 PM, Petr Vobornik wrote: On 05/18/2016 04:36 PM, Stanislav Laznicka wrote: There's no ticket for this patch but as there was

[Freeipa-devel] [PATCH] Fix minor typo

Hi, There is a minor typo in one of the FreeIPA user visible messages: "you OTP device" -> "your OTP device". Thanks for fixing it. Best regards, Yuri 0001-Fix-minor-typo.patch Description: Binary data -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

On 06/02/2016 01:40 PM, Pavel Vomacka wrote: > Hello, > > please review my patches which add webui for server roles. > Did not test yet. I'm waiting for rebase of backend. Patch 36: ACK (assuming it works when ^^ is available) Patch 37: 1. typo: 'overriden' - twice 2. 'create_column_link'

Re: [Freeipa-devel] [PATCH 0031] Fix replica deletion when there's no RUVs on the server

On 13.05.2016 15:48, Stanislav Laznicka wrote: Fix. On 05/13/2016 03:43 PM, Stanislav Laznicka wrote: Got distracted with the code, beautifying replacement of previous patch attached. On 05/13/2016 03:30 PM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5307 Please

Re: [Freeipa-devel] [PATCH 0042] Removed dead code from LDAPRemoveReverseMember

On 06/03/2016 02:19 PM, Martin Basti wrote: On 03.06.2016 14:13, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5892 NACK please remove it from LDAPAddReverseMember too, it contains the same code Martin^2 Please see the modified patch. Standa From

Re: [Freeipa-devel] [Test][patch-0042] Automated 2 testcases from Managed Topology testplan

On 06/03/2016 02:09 PM, Oleg Fayans wrote: The patch applies and passes pylint Hi Oleg, You don't need to implement server-del tests as I have an extensive CI test suite for that already, see https://www.redhat.com/archives/freeipa-devel/2016-April/msg00101.html. -- Martin^3 Babinsky

Re: [Freeipa-devel] [PATCH 0042] Removed dead code from LDAPRemoveReverseMember

On 03.06.2016 14:13, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5892 NACK please remove it from LDAPAddReverseMember too, it contains the same code Martin^2 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [PATCH 0042] Removed dead code from LDAPRemoveReverseMember

https://fedorahosted.org/freeipa/ticket/5892 From 350cfa89f34a6f9beddc85a195963966e1aa561d Mon Sep 17 00:00:00 2001 From: Stanislav Laznicka Date: Fri, 3 Jun 2016 14:08:59 +0200 Subject: [PATCH] Removed dead code from LDAPRemoveReverseMember

[Freeipa-devel] [Test][patch-0042] Automated 2 testcases from Managed Topology testplan

The patch applies and passes pylint -- Oleg Fayans Quality Engineer FreeIPA team RedHat. From 39fd39118a6d6e84a4c8791c17ad54da5cbffd0d Mon Sep 17 00:00:00 2001 From: Oleg Fayans Date: Fri, 3 Jun 2016 13:22:48 +0200 Subject: [PATCH] Automated 2 managed topology 4.4 testcases

[Freeipa-devel] [PATCH 0041] Increase nsslapd-db-locks

Hello, The attached patch implements solution to https://fedorahosted.org/freeipa/ticket/5914. The patch is rather hacky as nsslapd-db-locks requires to be modified when DS is not running although I accept proposals for better solution. Standa From f46164b12228708eac9656c85ff82657fa2b2a1f

Re: [Freeipa-devel] [PATCH 0040] Always add hostname=IPAREALM to krb5.conf

On 03.06.2016 10:15, Alexander Bokovoy wrote: On Thu, 02 Jun 2016, Martin Basti wrote: On 02.06.2016 16:02, Stanislav Laznicka wrote: Hello, In this patch I am adding the mapping = to krb5.conf as requested in https://fedorahosted.org/freeipa/ticket/5903. ACK I have just one

Re: [Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

On 03.06.2016 08:53, Petr Spacek wrote: On 2.6.2016 17:53, Martin Basti wrote: Typo - redundant ' ' at the end. Conditional NACK, warnings mentioned in http://www.freeipa.org/page/V4/DNS_Location_Mechanism#CLI are not there. I'm open to changing this to ACK if you open a separate ticket

[Freeipa-devel] [PATCH 0102] test: test_cli: Do not expect defaults in kwargs.

https://fedorahosted.org/freeipa/ticket/4739 With this patch all but one test in test_cli.py will pass again. The one failing is bug in the dns* commands prompt behavior and will be fixed soon. -- David Kupka From b3501bdc4a3195b8736a8d05992874ec72e7d97f Mon Sep 17 00:00:00 2001 From: David

[Freeipa-devel] [python-pytest-multihost][PATCH 0003] Added force option to rmdir

Hi All, Please review this patch. -- Thanks, Abhijeet Kasurde IRC: akasurde http://akasurde.github.io From 9148f39e340f9441be2b9e613485374b0f769559 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Fri, 3 Jun 2016 14:54:14 +0530 Subject: [PATCH] Added force option to

Re: [Freeipa-devel] [PATCH 0040] Always add hostname=IPAREALM to krb5.conf

On Thu, 02 Jun 2016, Martin Basti wrote: On 02.06.2016 16:02, Stanislav Laznicka wrote: Hello, In this patch I am adding the mapping = to krb5.conf as requested in https://fedorahosted.org/freeipa/ticket/5903. ACK I have just one question, where is install/share/krb5.conf.template

Re: [Freeipa-devel] [PATCH] 0002 Add the culprit line when a configuration file has an incorrect format

On 06/02/2016 07:18 PM, Martin Basti wrote: On 30.05.2016 18:11, Florence Blanc-Renaud wrote: Hi Martin, thanks for the review and the suggestion. Please find the updated patch attached. Flo. On 05/30/2016 11:00 AM, Martin Basti wrote: On 27.05.2016 11:35, Florence Blanc-Renaud

Re: [Freeipa-devel] [PATCH 0040] Always add hostname=IPAREALM to krb5.conf

On 06/02/2016 08:11 PM, Martin Basti wrote: On 02.06.2016 16:02, Stanislav Laznicka wrote: Hello, In this patch I am adding the mapping = to krb5.conf as requested in https://fedorahosted.org/freeipa/ticket/5903. ACK I have just one question, where is install/share/krb5.conf.template

Re: [Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

On 2.6.2016 17:53, Martin Basti wrote: > >> Typo - redundant ' ' at the end. >> >> >> Conditional NACK, warnings mentioned in >> http://www.freeipa.org/page/V4/DNS_Location_Mechanism#CLI >> are not there. >> >> I'm open to changing this to ACK if you open a

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

On 06/02/2016 06:45 PM, Petr Vobornik wrote: On 04/20/2016 07:05 PM, Pavel Vomacka wrote: On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: Hello, This patch adds ability to convert users from preserved to staged state. Fixes this

Re: [Freeipa-devel] [WIP] Thin client

On 25/05/16 16:07, Jan Cholasta wrote: On 25.5.2016 15:03, David Kupka wrote: On 18/05/16 08:01, Jan Cholasta wrote: On 16.5.2016 16:35, Martin Basti wrote: On 09.05.2016 14:07, Jan Cholasta wrote: On 6.5.2016 14:32, Martin Basti wrote: On 28.04.2016 14:45, Jan Cholasta wrote: Hi, I