[Freeipa-devel] [freeipa PR#246][closed] Build: ignore rpmbuild for lint target

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/246 Author: tomaskrizek Title: #246: Build: ignore rpmbuild for lint target Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/246/head:pr246 git checkout pr246 -- Manag

[Freeipa-devel] [freeipa PR#246][comment] Build: ignore rpmbuild for lint target

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/246 Title: #246: Build: ignore rpmbuild for lint target mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/28c5e128c823f32787a4bde87e6b248928a2cd0a """ See the full comment

[Freeipa-devel] [freeipa PR#247][comment] Add 'ipa local-env' subcommand

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/247 Title: #247: Add 'ipa local-env' subcommand mbasti-rh commented: """ You have PEP8 error there ``` ./ipalib/cli.py:57:1: E402 module level import not at top of file ``` """ See the full comment at htt

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/244 Title: #244: Add templating to ipaplatform path [RFC] mbasti-rh commented: """ Edit: wrong PR """ See the full comment at https://github.com/freeipa/freeipa/pull/244#issuecomment-260964435 -- Manage your subs

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/244 Title: #244: Add templating to ipaplatform path [RFC] mbasti-rh commented: """ You have PEP8 error there ``` ./ipalib/cli.py:57:1: E402 module level import not at top of file ``` """ See the full comment at http

[Freeipa-devel] [freeipa PR#180][closed] Make api.env.nss_dir relative to api.env.confdir

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/180 Author: tiran Title: #180: Make api.env.nss_dir relative to api.env.confdir Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/180/head:pr180 git checkout pr180 -- M

[Freeipa-devel] [freeipa PR#180][comment] Make api.env.nss_dir relative to api.env.confdir

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/9006ed34bb1edfaafc3345c1128800dc802c14ff """ See the full

[Freeipa-devel] [freeipa PR#180][+pushed] Make api.env.nss_dir relative to api.env.confdir

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/

[Freeipa-devel] [freeipa PR#180][+ack] Make api.env.nss_dir relative to api.env.confdir

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/180 Title: #180: Make api.env.nss_dir relative to api.env.confdir Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Con

[Freeipa-devel] [freeipa PR#247][comment] Add 'ipa show_env' subcommand

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/247 Title: #247: Add 'ipa show_env' subcommand mbasti-rh commented: """ So then it should be called `local-env` to be clear what does it do """ See the full comment at https://github.com/freeipa/freeipa/pu

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/244 Title: #244: Add templating to ipaplatform path [RFC] mbasti-rh commented: """ LGTM then, I'll wait for final version for testing """ See the full comment at https://github.com/freeipa/freeipa/pull/244#iss

[Freeipa-devel] [freeipa PR#241][comment] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/241 Title: #241: Port ipapython.dnssec.odsmgr to xml.etree mbasti-rh commented: """ Commit has no ticket `Use xml.etree in ipa-client-automount script` """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#244][comment] Add templating to ipaplatform path [RFC]

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/244 Title: #244: Add templating to ipaplatform path [RFC] mbasti-rh commented: """ It has missing ticket """ See the full comment at https://github.com/freeipa/freeipa/pull/244#issuecomment-260937077 -- Manage you

[Freeipa-devel] [freeipa PR#182][comment] Use env var IPA_CONFDIR to get confdir for 'cli' context

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/182 Title: #182: Use env var IPA_CONFDIR to get confdir for 'cli' context mbasti-rh commented: """ This should have test because it is completely new so it is not part of any current test suites. However final revie

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ ACK: removing admin_conn connections - just for future, python doesn't like to have too many dereference from performance point fo view. So you shoul

[Freeipa-devel] [freeipa PR#236][+pushed] Build phase 7: cleanup

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#236][closed] Build phase 7: cleanup

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/236 Author: pspacek Title: #236: Build phase 7: cleanup Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/236/head:pr236 git checkout pr236 -- Manage your subscription

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/198cd5fab3937fd8948bea4b4949e30db4e490a4 """ See the full comment

[Freeipa-devel] [freeipa PR#236][comment] Build phase 7: cleanup

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/236 Title: #236: Build phase 7: cleanup mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/27e7a89a6289d0d3009f5f7feb9802b7db171a15 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#229][closed] Remove the renewal lock file upon uninstall

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Author: flo-renaud Title: #229: Remove the renewal lock file upon uninstall Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/229/head:pr229 git checkout pr229 -- M

[Freeipa-devel] [freeipa PR#229][+pushed] Remove the renewal lock file upon uninstall

2016-11-16 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contr

[Freeipa-devel] [freeipa PR#229][+ack] Remove the renewal lock file upon uninstall

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribu

[Freeipa-devel] [freeipa PR#229][comment] Remove the renewal lock file upon uninstall

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/229 Title: #229: Remove the renewal lock file upon uninstall mbasti-rh commented: """ Works for me on both domain levels, I'd ACK this if nobody is against """ See the full comment at https://github.com/fr

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication mbasti-rh commented: """ Works for me, but because to test this against IPA 3.x is not my destiny because "issues" I cannot add ACK yet """ See

[Freeipa-devel] [freeipa PR#223][comment] LDAP refactoring: remove admin_conn

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/223 Title: #223: LDAP refactoring: remove admin_conn mbasti-rh commented: """ Works for me, I'll check code tomorrow """ See the full comment at https://github.com/freeipa/freeipa/pull/223#issuecomment-260710722 -

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication mbasti-rh commented: """ @martbab Working on it """ See the full comment at https://github.com/freeipa/freeipa/pull/234#issuecomment-260683430 -- Ma

[Freeipa-devel] [freeipa PR#240][comment] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Title: #240: Document make_delete_command method in UserTracker mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4b3bd5424246d8386a33a73f9a98c6958823093e ipa-4-4: https://fedorahos

[Freeipa-devel] [freeipa PR#240][+pushed] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Title: #240: Document make_delete_command method in UserTracker Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/pag

[Freeipa-devel] [freeipa PR#240][closed] Document make_delete_command method in UserTracker

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/240 Author: mirielka Title: #240: Document make_delete_command method in UserTracker Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/240/head:pr240 git checkout pr240

[Freeipa-devel] [freeipa PR#233][closed] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Author: pspacek Title: #233: Build phase 6: %install cleanup Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/233/head:pr233 git checkout pr233 -- Manage your subs

[Freeipa-devel] [freeipa PR#233][+pushed] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/636aaa7dbc649e685233f382cb8dd424345bebd3 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup mbasti-rh commented: """ @tiran do you agree with changes? """ See the full comment at https://github.com/freeipa/freeipa/pull/233#issuecomment-260666363 -- Manage you

[Freeipa-devel] [freeipa PR#241][comment] Port ipapython.dnssec.odsmgr to xml.etree

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/241 Title: #241: Port ipapython.dnssec.odsmgr to xml.etree mbasti-rh commented: """ I wrote some inline comments, I will test it later, DNSSEC is very hard to debug when an issue occurs, so review must be perfect. ""&

[Freeipa-devel] [freeipa PR#242][+pushed] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#242][closed] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Author: mirielka Title: #242: [master] Tests: Providing trust tests with tree root domain Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/242/head:pr242 git checko

[Freeipa-devel] [freeipa PR#242][comment] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/4df1d9d1a566af57b23d45ca4377ab77ed9e4d60 """

[Freeipa-devel] [freeipa PR#242][+ack] [master] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/242 Title: #242: [master] Tests: Providing trust tests with tree root domain Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.o

[Freeipa-devel] [freeipa PR#119][+pushed] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freei

[Freeipa-devel] [freeipa PR#119][closed] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Author: mirielka Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/119/head:pr119 git check

[Freeipa-devel] [freeipa PR#119][comment] [ipa-4-4] Tests: Providing trust tests with tree root domain

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: [ipa-4-4] Tests: Providing trust tests with tree root domain mbasti-rh commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/949e67692c427e0082ed32b729875b4fcffe631e """

[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-15 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option mbasti-rh commented: """ So please re-triage it today, yesterday was only 4.5 milestone agreed """ See the full comment at http

[Freeipa-devel] [freeipa PR#238][comment] Build system refactoring phase 8: update translation system

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/238 Title: #238: Build system refactoring phase 8: update translation system mbasti-rh commented: """ Lint failed ``` cd .; ./makeaci --validate ./makeaci: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module named b

[Freeipa-devel] [freeipa PR#197][+ack] Make setup.py files PyPI compatible

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/197 Title: #197: Make setup.py files PyPI compatible Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#174][+rejected] add log module

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#174][closed] add log module

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Author: shanyin Title: #174: add log module Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/174/head:pr174 git checkout pr174 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module mbasti-rh commented: """ Hello, we agreed on devel meeting that this is not the right way how to audit/log inspection should be done with FreeIPA: - centralized logging is preferred solution However w

[Freeipa-devel] [freeipa PR#224][comment] Integration tests for certs in idoverrides

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/224 Title: #224: Integration tests for certs in idoverrides mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/f1c9c56f40b542068b512e2010d40e87a2dd83df https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#224][+pushed] Integration tests for certs in idoverrides

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/224 Title: #224: Integration tests for certs in idoverrides Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contri

[Freeipa-devel] [freeipa PR#224][closed] Integration tests for certs in idoverrides

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/224 Author: ofayans Title: #224: Integration tests for certs in idoverrides Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/224/head:pr224 git checkout pr224 -- Manag

[Freeipa-devel] [freeipa PR#119][comment] Tests: Providing trust tests with tree root domain

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: Tests: Providing trust tests with tree root domain mbasti-rh commented: """ And master too """ See the full comment at https://github.com/freeipa/freeipa/pull/119#issuecomment-260400800 -- Manage you

[Freeipa-devel] [freeipa PR#119][comment] Tests: Providing trust tests with tree root domain

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/119 Title: #119: Tests: Providing trust tests with tree root domain mbasti-rh commented: """ Needs rebase for 4.4 branch ``` error: ipatests/pytest_plugins/integration.py: patch does not apply ``` """ See the full

[Freeipa-devel] [freeipa PR#178][+pushed] ipatests: Fix assert_deepequal outside of pytest process

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/178 Title: #178: ipatests: Fix assert_deepequal outside of pytest process Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.o

[Freeipa-devel] [freeipa PR#178][comment] ipatests: Fix assert_deepequal outside of pytest process

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/178 Title: #178: ipatests: Fix assert_deepequal outside of pytest process mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e54109c167526ae6b1cd4c977915da884482891b """

[Freeipa-devel] [freeipa PR#157][comment] git: Add commit template

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/157 Title: #157: git: Add commit template mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/2df709838905dec3ee2c2eaec47f506336d85a6e """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#157][+pushed] git: Add commit template

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/157 Title: #157: git: Add commit template Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#157][closed] git: Add commit template

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/157 Author: mzidek-rh Title: #157: git: Add commit template Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/157/head:pr157 git checkout pr157 -- Manage your subscript

[Freeipa-devel] [freeipa PR#185][+pushed] TESTS: Update group type name

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/185 Title: #185: TESTS: Update group type name Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#185][closed] TESTS: Update group type name

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/185 Author: pvomacka Title: #185: TESTS: Update group type name Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/185/head:pr185 git checkout pr185 -- Manage your subsc

[Freeipa-devel] [freeipa PR#185][comment] TESTS: Update group type name

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/185 Title: #185: TESTS: Update group type name mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6e475988e1ec1b89d44b495cd667a444526733a7 """ See the full comment at https://g

[Freeipa-devel] [freeipa PR#190][+pushed] [4.4] Fix tests install dom0

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/190 Title: #190: [4.4] Fix tests install dom0 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#190][comment] [4.4] Fix tests install dom0

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/190 Title: #190: [4.4] Fix tests install dom0 mbasti-rh commented: """ Fixed upstream ipa-4-4: https://fedorahosted.org/freeipa/changeset/bf799988137769c4d0cbd16b988d4afca5d85042 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#190][closed] [4.4] Fix tests install dom0

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/190 Author: mbasti-rh Title: #190: [4.4] Fix tests install dom0 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/190/head:pr190 git checkout pr190 -- Manage your

[Freeipa-devel] [freeipa PR#239][closed] cainstance: use correct certificate for replica install check

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/239 Author: tomaskrizek Title: #239: cainstance: use correct certificate for replica install check Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/239/head:pr239 git c

[Freeipa-devel] [freeipa PR#239][+pushed] cainstance: use correct certificate for replica install check

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/239 Title: #239: cainstance: use correct certificate for replica install check Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.free

[Freeipa-devel] [freeipa PR#239][comment] cainstance: use correct certificate for replica install check

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/239 Title: #239: cainstance: use correct certificate for replica install check mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/d6300dca285acaad296f6271421c23999e3c1071 """

[Freeipa-devel] [freeipa PR#237][comment] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/623cc428cfd79ea228bda6e88dc48bad9aaf61aa ""&

[Freeipa-devel] [freeipa PR#237][closed] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/237 Author: pspacek Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/237/head:pr237

[Freeipa-devel] [freeipa PR#237][+pushed] Update man page for ipa-adtrust-install by removing --no-msdcs option

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/237 Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs option Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http:/

[Freeipa-devel] [freeipa PR#194][+pushed] Tests: Verify that validity info is present in cert-show and cert-find command

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/194 Title: #194: Tests: Verify that validity info is present in cert-show and cert-find command Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIP

[Freeipa-devel] [freeipa PR#194][comment] Tests: Verify that validity info is present in cert-show and cert-find command

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/194 Title: #194: Tests: Verify that validity info is present in cert-show and cert-find command mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/414ed0d182e55dfe18f31ebbbc97095b989fc162

[Freeipa-devel] [freeipa PR#194][closed] Tests: Verify that validity info is present in cert-show and cert-find command

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/194 Author: mirielka Title: #194: Tests: Verify that validity info is present in cert-show and cert-find command Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/194/h

[Freeipa-devel] [freeipa PR#194][+ack] Tests: Verify that validity info is present in cert-show and cert-find command

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/194 Title: #194: Tests: Verify that validity info is present in cert-show and cert-find command Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#197][comment] Make setup.py files PyPI compatible

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/197 Title: #197: Make setup.py files PyPI compatible mbasti-rh commented: """ I have some inline questions """ See the full comment at https://github.com/freeipa/freeipa/pull/197#issuecomment-260383809 -- Manage you

[Freeipa-devel] [freeipa PR#185][+ack] TESTS: Update group type name

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/185 Title: #185: TESTS: Update group type name Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#178][+ack] ipatests: Fix assert_deepequal outside of pytest process

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/178 Title: #178: ipatests: Fix assert_deepequal outside of pytest process Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/

[Freeipa-devel] [freeipa PR#178][comment] ipatests: Fix assert_deepequal outside of pytest process

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/178 Title: #178: ipatests: Fix assert_deepequal outside of pytest process mbasti-rh commented: """ ACK, because fixing PEP8 makes readability worse in this case and it is against PEP8 :) """ See the full comment

[Freeipa-devel] [freeipa PR#158][comment] WebUI: update Patternfly and Bootstrap

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/158 Title: #158: WebUI: update Patternfly and Bootstrap mbasti-rh commented: """ Bump for review """ See the full comment at https://github.com/freeipa/freeipa/pull/158#issuecomment-260331171 -- Manage your subs

[Freeipa-devel] [freeipa PR#157][+ack] git: Add commit template

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/157 Title: #157: git: Add commit template Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#143][+pushed] Issue6386 nss dir

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#143][comment] Issue6386 nss dir

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/143 Title: #143: Issue6386 nss dir mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/a22a5dd676f581910ac7872c1a20322278fc7d4a """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#143][closed] Issue6386 nss dir

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/143 Author: tiran Title: #143: Issue6386 nss dir Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/143/head:pr143 git checkout pr143 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module mbasti-rh commented: """ @shanyin great, I suppose you want those translations in IPA 4.4.x, so I could try to copy them from master. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#203][+rejected] Add sdist_list plugin to all setup.py

2016-11-14 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/203 Title: #203: Add sdist_list plugin to all setup.py Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#235][synchronized] Make Knob function deprecated

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/235 Author: mbasti-rh Title: #235: Make Knob function deprecated Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/235/head:pr235 git checkout pr235 From

[Freeipa-devel] [freeipa PR#235][edited] Remove unused Knob function

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/235 Author: mbasti-rh Title: #235: Remove unused Knob function Action: edited Changed field: title Original value: """ Make Knob function deprecated """ -- Manage your subscription for the Freeipa-devel mailin

[Freeipa-devel] [freeipa PR#235][comment] Make Knob function deprecated

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Make Knob function deprecated mbasti-rh commented: """ I would wait with ACK, I realized that Knobs with capital K are not used anymore, so we can remove it instead of deprecating """ See the full

[Freeipa-devel] [freeipa PR#235][-ack] Make Knob function deprecated

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/235 Title: #235: Make Knob function deprecated Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#235][opened] Make Knob function deprecated

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/235 Author: mbasti-rh Title: #235: Make Knob function deprecated Action: opened PR body: """ `Knob` function is outdated and was replaced by `knob`. Make explicit note in code about this. https://fedorahosted.org/freeipa/ticket/63

[Freeipa-devel] [freeipa PR#209][comment] Enumerate available options in IPA installer

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/209 Title: #209: Enumerate available options in IPA installer mbasti-rh commented: """ Hi, we changed a lot of code during refactoring, PR doesn't apply. IMO list of choices shown in --help should be handled in knob() if meta

[Freeipa-devel] [freeipa PR#212][synchronized] KRA: don't add KRA container when KRA replica

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/212 Author: mbasti-rh Title: #212: KRA: don't add KRA container when KRA replica Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/212/head:pr212 git che

[Freeipa-devel] [freeipa PR#207][+pushed] Provide user hint about IP address in IPA install

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/207 Title: #207: Provide user hint about IP address in IPA install Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [freeipa PR#207][closed] Provide user hint about IP address in IPA install

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/207 Author: Akasurde Title: #207: Provide user hint about IP address in IPA install Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/207/head:pr207 git checkout pr207 -

[Freeipa-devel] [freeipa PR#207][comment] Provide user hint about IP address in IPA install

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/207 Title: #207: Provide user hint about IP address in IPA install mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/28bc54f91dfbd76887180fa67ceecb46977a4fb8 """ See the full

[Freeipa-devel] [freeipa PR#207][+ack] Provide user hint about IP address in IPA install

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/207 Title: #207: Provide user hint about IP address in IPA install Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Co

[Freeipa-devel] [freeipa PR#214][comment] ipaldap: remove do_bind from LDAPClient

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/214 Title: #214: ipaldap: remove do_bind from LDAPClient mbasti-rh commented: """ ``` ipaserver/install/ca.py:226: [W0612(unused-variable), install_step_1] Unused variable 'dm_password') ``` """ See the ful

[Freeipa-devel] [freeipa PR#234][comment] Always use GSSAPI to set up initial replication

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/234 Title: #234: Always use GSSAPI to set up initial replication mbasti-rh commented: """ ``` Traceback (most recent call last): File "/sbin/ipa-server-install", line 23, in from ipaserver.install import ipa_server_

[Freeipa-devel] [freeipa PR#174][comment] add log module

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/174 Title: #174: add log module mbasti-rh commented: """ @shanyin Did centralized logging meet your requirements? """ See the full comment at https://github.com/freeipa/freeipa/pull/174#issuecomment-259939617 -- Ma

[Freeipa-devel] [freeipa PR#233][comment] Build phase 6: %install cleanup

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/233 Title: #233: Build phase 6: %install cleanup mbasti-rh commented: """ Build failed ``` Failed to open: 'freeipa.spec.in', not a valid spec file. ``` """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#207][comment] Provide user hint about IP address in IPA install

2016-11-11 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/207 Title: #207: Provide user hint about IP address in IPA install mbasti-rh commented: """ LGTM, I'll test later """ See the full comment at https://github.com/freeipa/freeipa/pull/207#issuecomment-259938389 -

<    1   2   3   4   5   6   7   8   9   10   >