[Freeipa-devel] [freeipa PR#764][comment] Basic uninstaller for the CA

2017-05-16 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/764 Title: #764: Basic uninstaller for the CA pvoborni commented: """ We need to develop something like this, but right now it is not the best time for it. First we need to stabilize 4.5.1 (seems that's almost done). Then focus on te

[Freeipa-devel] [freeipa PR#764][+postponed] Basic uninstaller for the CA

2017-05-16 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/764 Title: #764: Basic uninstaller for the CA Label: +postponed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#782][comment] [WIP] Improving GUI text in "Add DNS Zones" popup

2017-05-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/782 Title: #782: [WIP] Improving GUI text in "Add DNS Zones" popup pvoborni commented: """ Ok, when one field is not usuable because IP address or network address are also valid DNS zones, then the proper way is to

[Freeipa-devel] [freeipa PR#782][comment] [WIP] Improving GUI text in "Add DNS Zones" popup

2017-05-12 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/782 Title: #782: [WIP] Improving GUI text in "Add DNS Zones" popup pvoborni commented: """ I'm not completely sure that the approach suggested in bug report is correct. That is why I suggested alternative in ht

[Freeipa-devel] [freeipa PR#773][comment] [WIP] Warn in cert-request if CSR doesn't contain SAN

2017-05-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/773 Title: #773: [WIP] Warn in cert-request if CSR doesn't contain SAN pvoborni commented: """ I don't think it makes sense to spend time on configuration of warning - that is larger change (ldap attr, schema, api...) and as such out

[Freeipa-devel] [freeipa PR#773][comment] [WIP] Warn in cert-request if CSR doesn't contain SAN

2017-05-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/773 Title: #773: [WIP] Warn in cert-request if CSR doesn't contain SAN pvoborni commented: """ AFAIK, there was not an agreement not implementing this, otherwise the ticket would be closed. The ticket #6663 was created to warn u

[Freeipa-devel] [freeipa PR#764][comment] Basic uninstaller for the CA

2017-05-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/764 Title: #764: Basic uninstaller for the CA pvoborni commented: """ Let's first clarify the problem to solve. If I understand @rcritten right, the problem is that if ipa-ca-install fail then one must reinstall the whole

[Freeipa-devel] [freeipa PR#761][comment] Fixing adding authenticator indicators to host

2017-05-04 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/761 Title: #761: Fixing adding authenticator indicators to host pvoborni commented: """ I'd fix it on all places in host-mod: ``` 885 raise errors.ACIError(info=msg) 886 obj_classes = entry_attrs_o

[Freeipa-devel] [freeipa PR#679][comment] Make sure remote hosts have our keys

2017-05-02 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/679 Title: #679: Make sure remote hosts have our keys pvoborni commented: """ What is this PR waiting for? """ See the full comment at https://github.com/freeipa/freeipa/pull/679#issuecomment-298530908 -- Manage you

[Freeipa-devel] [freeipa PR#748][comment] restore: restart/reload gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/748 Title: #748: restore: restart/reload gssproxy after restore pvoborni commented: """ Should work: ``` def debian_service_class_factory(name, api=None): if name == 'dirsrv': return redhat_services.RedHatDirectorySe

[Freeipa-devel] [freeipa PR#738][+rejected] restore: restart gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/738 Title: #738: restore: restart gssproxy after restore Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#738][closed] restore: restart gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/738 Author: pvoborni Title: #738: restore: restart gssproxy after restore Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/738/head:pr738 git checkout pr738 -- Manage

[Freeipa-devel] [freeipa PR#738][comment] restore: restart gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/738 Title: #738: restore: restart gssproxy after restore pvoborni commented: """ PR #748 obsoletes this one - this PR was created badly and so I cannot force update it. New one uses reload-or-restart """ See the full

[Freeipa-devel] [freeipa PR#748][comment] restore: restart/reload gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/748 Title: #748: restore: restart/reload gssproxy after restore pvoborni commented: """ Obsoletes PR #738 """ See the full comment at https://github.com/freeipa/freeipa/pull/748#issuecomment-297962322 -- Manage you

[Freeipa-devel] [freeipa PR#748][opened] restore: restart/reload gssproxy after restore

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/748 Author: pvoborni Title: #748: restore: restart/reload gssproxy after restore Action: opened PR body: """ So that gssproxy picks up new configuration and therefore related usages like authentication of CLI against server works ht

[Freeipa-devel] [freeipa PR#723][-ack] Store GSSAPI session key in /var/run/httpd

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/723 Title: #723: Store GSSAPI session key in /var/run/httpd Label: -ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#723][-pushed] Store GSSAPI session key in /var/run/httpd

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/723 Title: #723: Store GSSAPI session key in /var/run/httpd Label: -pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#741][+blocker] 6.9 -> 7.4 migration fixes

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/741 Title: #741: 6.9 -> 7.4 migration fixes Label: +blocker -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#694][+blocker] RFC: implement local PKINIT deployment in server/replica install

2017-04-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/694 Title: #694: RFC: implement local PKINIT deployment in server/replica install Label: +blocker -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#737][+blocker] Vault: Explicitly default to 3DES CBC

2017-04-27 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/737 Title: #737: Vault: Explicitly default to 3DES CBC Label: +blocker -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#735][comment] automount install: do not wait for sssd restart on uninstallation

2017-04-27 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Title: #735: automount install: do not wait for sssd restart on uninstallation pvoborni commented: """ The error message was reverted to original (I was fixing the comment below and wondered why it was not fixed, now I know). &q

[Freeipa-devel] [freeipa PR#735][synchronized] automount install: do not wait for sssd restart on uninstallation

2017-04-27 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Author: pvoborni Title: #735: automount install: do not wait for sssd restart on uninstallation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/735

[Freeipa-devel] [freeipa PR#738][opened] restore: restart gssproxy after restore

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/738 Author: pvoborni Title: #738: restore: restart gssproxy after restore Action: opened PR body: """ So that gssproxy picks up new configuration and therefore related usages like authentication of CLI against server works ht

[Freeipa-devel] [freeipa PR#737][comment] Vault: Explicitly default to 3DES CBC

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/737 Title: #737: Vault: Explicitly default to 3DES CBC pvoborni commented: """ Should go to 4.4.5 unless pki-core-10.4.0-1 is removed from f25. Blocking new Dogtag update in 4.4 doesn't seem right to me. """

[Freeipa-devel] [freeipa PR#735][comment] automount install: do not wait for sssd restart on uninstallation

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Title: #735: automount install: do not wait for sssd restart on uninstallation pvoborni commented: """ Thanks Rob, this reason for the wait didn't occurred to me. New patch changes api initialization so that it works f

[Freeipa-devel] [freeipa PR#735][synchronized] automount install: do not wait for sssd restart on uninstallation

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Author: pvoborni Title: #735: automount install: do not wait for sssd restart on uninstallation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/735

[Freeipa-devel] [freeipa PR#735][synchronized] automount install: do not wait for sssd restart on uninstallation

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Author: pvoborni Title: #735: automount install: do not wait for sssd restart on uninstallation Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/735

[Freeipa-devel] [freeipa PR#735][opened] automount install: do not wait for sssd restart on uninstallation

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/735 Author: pvoborni Title: #735: automount install: do not wait for sssd restart on uninstallation Action: opened PR body: """ Change in 2d4d1a9dc0ef2bbe86751768d6e6b009a52c0dc9 no longer initializes api in `ipa-client-automount -

[Freeipa-devel] [freeipa PR#734][opened] kerberos session: use CA cert with full cert chain for obtaining cookie

2017-04-26 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/734 Author: pvoborni Title: #734: kerberos session: use CA cert with full cert chain for obtaining cookie Action: opened PR body: """ Http request performed in finalize_kerberos_acquisition doesn't use CA certificate/certificate

[Freeipa-devel] [freeipa PR#699][comment] ipaclient/ipapython macOS compatibility fixes

2017-04-19 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/699 Title: #699: ipaclient/ipapython macOS compatibility fixes pvoborni commented: """ IMO this can be put to 4.5.1 (ipa-4-5 branch) but in order to do it, according to FreeIPA devel processes, it needs to be attached (have a ticket

[Freeipa-devel] [freeipa PR#682][comment] ipserver/dcerpc: unify error processing

2017-04-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/682 Title: #682: ipserver/dcerpc: unify error processing pvoborni commented: """ A ticket was created for this PR: https://pagure.io/freeipa/issue/6859 """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#679][comment] Make sure remote hosts have our keys

2017-04-04 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/679 Title: #679: Make sure remote hosts have our keys pvoborni commented: """ Shouldn't the ticket number be: https://pagure.io/freeipa/issue/6838 ? """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#659][+ack] WebUI: Allow to add certs to certmapping with CERT LINES around

2017-03-27 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/659 Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#659][comment] WebUI: Allow to add certs to certmapping with CERT LINES around

2017-03-27 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/659 Title: #659: WebUI: Allow to add certs to certmapping with CERT LINES around pvoborni commented: """ Code LGTM, ACK give that it works for @flo-renaud """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#651][+ack] WebUI: Fix showing vault in selfservice view

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/651 Title: #651: WebUI: Fix showing vault in selfservice view Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#651][comment] WebUI: Fix showing vault in selfservice view

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/651 Title: #651: WebUI: Fix showing vault in selfservice view pvoborni commented: """ Works fine. ACK """ See the full comment at https://github.com/freeipa/freeipa/pull/651#issuecomment-288990983 -- Manage your subs

[Freeipa-devel] [freeipa PR#470][comment] WebUI: Size limit warning on details pages fixed

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/470 Title: #470: WebUI: Size limit warning on details pages fixed pvoborni commented: """ Code looks good and works fine, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/470#issuecom

[Freeipa-devel] [freeipa PR#470][+ack] WebUI: Size limit warning on details pages fixed

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/470 Title: #470: WebUI: Size limit warning on details pages fixed Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#639][+ack] WebUI: Login for AD Users

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/639 Title: #639: WebUI: Login for AD Users Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#639][comment] WebUI: Login for AD Users

2017-03-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/639 Title: #639: WebUI: Login for AD Users pvoborni commented: """ The code changes looks good to me. ACK given that it works fine (@abbra 's comment). """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#626][comment] Move helper code for integration plugin

2017-03-20 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/626 Title: #626: Move helper code for integration plugin pvoborni commented: """ From the PR description it is not clear what problem it solves or if it solves a problem. "doesn't play nice " is vague. " Certain aspec

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional pvoborni commented: """ If it improves messages then I assume so provided that in won't be controversial in other aspects. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional pvoborni commented: """ There was no result in the upstream discussion. My personal opinion is that one way or the other can work. They are for different use cases. I tend to prefer

[Freeipa-devel] [freeipa PR#577][comment] WebUI: Add support for AD users short name resolution

2017-03-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/577 Title: #577: WebUI: Add support for AD users short name resolution pvoborni commented: """ ACK if backend won't change """ See the full comment at https://github.com/freeipa/freeipa/pull/577#issuecomment-28637321

[Freeipa-devel] [freeipa PR#566][synchronized] webui: do not warn about CAs if there is only one master

2017-03-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/566 Author: pvoborni Title: #566: webui: do not warn about CAs if there is only one master Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/566/head:pr566 git

[Freeipa-devel] [freeipa PR#565][synchronized] permissions: add permissions for reading and modifying external group members

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/565 Author: pvoborni Title: #565: permissions: add permissions for reading and modifying external group members Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull

[Freeipa-devel] [freeipa PR#553][comment] Add check for removing last KRA server

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/553 Title: #553: Add check for removing last KRA server pvoborni commented: """ Fix for 6598 in #566 """ See the full comment at https://github.com/freeipa/freeipa/pull/553#issuecomment-285450624 -- Manage your subs

[Freeipa-devel] [freeipa PR#566][comment] webui: do not warn about CAs if there is only one master

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/566 Title: #566: webui: do not warn about CAs if there is only one master pvoborni commented: """ Written in a way that it can be then easily extended with KRA check. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#566][opened] webui: do not warn about CAs if there is only one master

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/566 Author: pvoborni Title: #566: webui: do not warn about CAs if there is only one master Action: opened PR body: """ Web UI showed pop-up dialog which recommends to install additional CA in topology section when only 1

[Freeipa-devel] [freeipa PR#565][opened] permissions: add permissions for reading and modifying external group members

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/565 Author: pvoborni Title: #565: permissions: add permissions for reading and modifying external group members Action: opened PR body: """ Issue: "User Administrator" role cannot add users to an External Group. https:/

[Freeipa-devel] [freeipa PR#556][comment] Don't allow standalone KRA uninstalls

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/556 Title: #556: Don't allow standalone KRA uninstalls pvoborni commented: """ OK, so this pr remove `--uninstall` from `ipa-kra-install`. Did it work in the past? Or it always broke the installation? AFAIK this workflow was not

[Freeipa-devel] [freeipa PR#556][comment] Don't allow standalone KRA uninstalls

2017-03-09 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/556 Title: #556: Don't allow standalone KRA uninstalls pvoborni commented: """ OK, so this pr remove `--uninstall` from `ipa-kra-install`. Did it work in the past? Or it always broke the installation? AFAIK this workflow was not

[Freeipa-devel] [freeipa PR#549][+ack] WebUI: certmap match

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/549 Title: #549: WebUI: certmap match Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#310][comment] WIP: CLI testing

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/310 Title: #310: WIP: CLI testing pvoborni commented: """ Marking as postponed. We cannot expect the changes to be addressed by @mirielka any time soon. And CLI testing might need design discussion. """ See the full

[Freeipa-devel] [freeipa PR#310][+postponed] WIP: CLI testing

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/310 Title: #310: WIP: CLI testing Label: +postponed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#331][comment] WebUI: don't change casing of Auth Indicators values

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/331 Title: #331: WebUI: don't change casing of Auth Indicators values pvoborni commented: """ ACK but I've find out that the change is not enough because of existing bug. See pr #554 """ See the full comment at http

[Freeipa-devel] [freeipa PR#331][+ack] WebUI: don't change casing of Auth Indicators values

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/331 Title: #331: WebUI: don't change casing of Auth Indicators values Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#554][opened] webui: fixes normalization of value in attributes widget

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/554 Author: pvoborni Title: #554: webui: fixes normalization of value in attributes widget Action: opened PR body: """ Fix is in checkboxes widget but the only affected one is attributes widget. Reproduction: 1. Add permission

[Freeipa-devel] [freeipa PR#300][+ack] WebUI: Add support for custom table pagination size

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/300 Title: #300: WebUI: Add support for custom table pagination size Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#400][+ack] WebUI: Certificate Mapping

2017-03-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#533][+ack] WebUI: Change structure of Identity submenu

2017-03-07 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/533 Title: #533: WebUI: Change structure of Identity submenu Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#520][synchronized] Change README to use Markdown

2017-03-02 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/520 Author: pvoborni Title: #520: Change README to use Markdown Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/520/head:pr520 git checkout pr520 From

[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

2017-03-01 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/502 Title: #502: Make pylint and jsl optional pvoborni commented: """ +1 Reasoning for not skipping linters was that reviewer or patch author can forget to run those. This problem was solved by travis checks. """

[Freeipa-devel] [freeipa PR#520][synchronized] Change README to use Markdown

2017-03-01 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/520 Author: pvoborni Title: #520: Change README to use Markdown Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/520/head:pr520 git checkout pr520 From

[Freeipa-devel] [freeipa PR#520][opened] Change README to use Markdown

2017-02-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/520 Author: pvoborni Title: #520: Change README to use Markdown Action: opened PR body: """ So that it will be nicely formatted on FreeIPA Pagure landing page. https://pagure.io/freeipa Some links were updated as other proj

[Freeipa-devel] [freeipa PR#519][comment] WebUI: add sizelimit:0 to cert-find

2017-02-28 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/519 Title: #519: WebUI: add sizelimit:0 to cert-find pvoborni commented: """ LGTM """ See the full comment at https://github.com/freeipa/freeipa/pull/519#issuecomment-283096563 -- Manage your subscription for the Fre

[Freeipa-devel] [freeipa PR#507][comment] Use https to get security domain from Dogtag

2017-02-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag pvoborni commented: """ I.e. I want to know if something needs to be or should be backported. """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#507][comment] Use https to get security domain from Dogtag

2017-02-24 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/507 Title: #507: Use https to get security domain from Dogtag pvoborni commented: """ What is a context of this patch? Is something broken only in master. Or also 4.4, Fedora, RHEL,...? """ See the full comment

[Freeipa-devel] [freeipa PR#484][closed] FIPS: Remove pkispawn cruft

2017-02-23 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/484 Author: stlaz Title: #484: FIPS: Remove pkispawn cruft Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/484/head:pr484 git checkout pr484 -- Manage your

[Freeipa-devel] [freeipa PR#484][comment] FIPS: Remove pkispawn cruft

2017-02-23 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/484 Title: #484: FIPS: Remove pkispawn cruft pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/728a6bd4229ba170b2e94f216127b19d5d94e2ba https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#484][+pushed] FIPS: Remove pkispawn cruft

2017-02-23 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/484 Title: #484: FIPS: Remove pkispawn cruft Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-23 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages pvoborni commented: """ Some distros like RHEL doesn't have python-wheel packaged. It can be disabled by downstream patch, but better would be to remove it or make it configu

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Also I added section to FreeIPA wiki: http://www.freeipa.org/page/V4/Build_system_refactoring#Packager_-_client_only_build """

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build pvoborni commented: """ #364 was pushed. """ See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-281690828 -- Manage your subscription for

[Freeipa-devel] [freeipa PR#494][closed] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Author: lslebodn Title: #494: Support client-only build Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/494/head:pr494 git checkout pr494 -- Manage your

[Freeipa-devel] [freeipa PR#494][+rejected] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/70554938d4f9ba5b347cd4bc8001428e905198e4 https://fedorahosted.org/fr

[Freeipa-devel] [freeipa PR#364][closed] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Author: tiran Title: #364: Client-only builds with --disable-server Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/364/head:pr364 git checkout pr364 -- Manage

[Freeipa-devel] [freeipa PR#364][+pushed] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#368][+ack] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox pvoborni commented: """ ACK given that Martin did functional testing """ See the full comment at https://github.com/freeipa/freeipa/p

[Freeipa-devel] [freeipa PR#368][comment] WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/368 Title: #368: WebUI: fix incorrect behavior of ESC button on combobox pvoborni commented: """ Code LGTM, but I did not tests the behavior, so cannot give ACK now. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#470][comment] WebUI: Size limit warning on details pages fixed

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/470 Title: #470: WebUI: Size limit warning on details pages fixed pvoborni commented: """ Would it be better to suppress the warning and use sensible size limit. I.e. the entity select doesn't need to show all entries. I'm afraid that

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-17 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still fail to see why we should care about `make dist` with `configure --disable-server` this is not a combination of options which should be

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop pvoborni commented: """ And AFAIK b) is not supported. @martbab , does something indicate otherwise? """ See the full comment at https://github.com/freeipa

[Freeipa-devel] [freeipa PR#331][comment] WebUI: don't change casing of Auth Indicators values

2017-02-15 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/331 Title: #331: WebUI: don't change casing of Auth Indicators values pvoborni commented: """ LGTM (reading code). """ See the full comment at https://github.com/freeipa/freeipa/pull/331#issuecomment-27998456

[Freeipa-devel] [freeipa PR#215][closed] Add script to setup krb5 NFS exports

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/215 Author: jumitche Title: #215: Add script to setup krb5 NFS exports Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/215/head:pr215 git checkout pr215 -- Manage

[Freeipa-devel] [freeipa PR#215][+rejected] Add script to setup krb5 NFS exports

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#215][comment] Add script to setup krb5 NFS exports

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/215 Title: #215: Add script to setup krb5 NFS exports pvoborni commented: """ Justin, pasting here re-phrased mail I wrote you on Dec 5. This is a tool which integrates external host with FreeIPA. It is written in a way th

[Freeipa-devel] [freeipa PR#23][+postponed] Time-Based HBAC Policies

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/23 Title: #23: Time-Based HBAC Policies Label: +postponed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#379][comment] Packaging: Add placeholder and IPA commands packages

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/379 Title: #379: Packaging: Add placeholder and IPA commands packages pvoborni commented: """ If there is reason it can be maintained in IPA, but what is the reason? """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#397][comment] Improve wheel building and provide ipaserver wheel for local testing

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/397 Title: #397: Improve wheel building and provide ipaserver wheel for local testing pvoborni commented: """ @tiran I have very vague idea how this is helpful. You have mentioned it during post-devconf "API meeting".

[Freeipa-devel] [freeipa PR#379][comment] Packaging: Add placeholder and IPA commands packages

2017-02-14 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/379 Title: #379: Packaging: Add placeholder and IPA commands packages pvoborni commented: """ I thought that I understand why this PR is needed bud in fact I don't. Ticket #6484 is closed. Why is it attached to it? How will the

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ As mention on meeting, if rpcserver prettyprints into output in debug mode then it is fine. """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ It's usually quicker to read raw response in browser than the folded "preview" because everything is visible and no clicking is required. Same for cu

[Freeipa-devel] [freeipa PR#459][comment] [WIP] Faster JSON encoder/decoder

2017-02-13 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/459 Title: #459: [WIP] Faster JSON encoder/decoder pvoborni commented: """ Is there a way(I did not read changes thoroughly) to enable sorting and indentation, e.g. for testing purposes? """ See the full comment

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-10 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ I still think that this use case needs to be documented in http://www.freeipa.org/page/V4/Build_system_refactoring#How_to_Use . IMHO `make

[Freeipa-devel] [freeipa PR#423][comment] dns-update-system-records: add support for nsupdate output format

2017-02-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/423 Title: #423: dns-update-system-records: add support for nsupdate output format pvoborni commented: """ I've added acceptance criteria and user story to the related FreeIPA ticket. I miss a "how to use part" - a spec

[Freeipa-devel] [freeipa PR#443][comment] Stronger check for DM password during server install

2017-02-08 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/443 Title: #443: Stronger check for DM password during server install pvoborni commented: """ Function check_password_fips_nssdb_compatible looks like a great candidate for unit test. """ See the full comment

[Freeipa-devel] [freeipa PR#437][comment] FIPS: replica install check

2017-02-07 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/437 Title: #437: FIPS: replica install check pvoborni commented: """ @MartinBasti I'm not sure from your comment if you would like to provide a way to change non-FIPS server into a FIPS server or just brainstorming ways how it can b

  1   2   >