Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-19 Thread Petr Viktorin
On 04/18/2012 12:38 AM, Dmitri Pal wrote: On 04/17/2012 01:13 PM, Petr Viktorin wrote: On 04/17/2012 06:46 PM, John Dennis wrote: Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's m

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Dmitri Pal
On 04/17/2012 01:13 PM, Petr Viktorin wrote: > On 04/17/2012 06:46 PM, John Dennis wrote: >> Thank you for the explanation Petr, it's very much appreciated. >> >> I do have a problem with this patch and I'm inclined to NAK it, but I'm >> open to discussion. Here's my thoughts, if I've made mistakes

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 06:46 PM, John Dennis wrote: Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's my thoughts, if I've made mistakes in my reasoning please point them out. The fundamental

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
Thank you for the explanation Petr, it's very much appreciated. I do have a problem with this patch and I'm inclined to NAK it, but I'm open to discussion. Here's my thoughts, if I've made mistakes in my reasoning please point them out. The fundamental problem is many of our command line util

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 04:12 PM, John Dennis wrote: There have been so many versions of the patch and various comments attached to it I'm afraid I'm still trying to wrap my head around what the actual problem is we're trying to solve, until I have that understanding I can't evaluate the proposed solution.

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread John Dennis
There have been so many versions of the patch and various comments attached to it I'm afraid I'm still trying to wrap my head around what the actual problem is we're trying to solve, until I have that understanding I can't evaluate the proposed solution. Could you please state simply what the

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-17 Thread Petr Viktorin
On 04/17/2012 12:12 AM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 04:15 PM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread Rob Crittenden
John Dennis wrote: On 04/16/2012 04:15 PM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree th

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
On 04/16/2012 04:15 PM, Rob Crittenden wrote: John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. At

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread Rob Crittenden
John Dennis wrote: On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. Attached patch removes the console log handler be

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
On 04/16/2012 01:31 PM, Rob Crittenden wrote: John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. Attached patch removes the console log handler before logging the res

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread Rob Crittenden
John Dennis wrote: On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. Attached patch removes the console log handler before logging the result. I read through log_manager, and found t

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-16 Thread John Dennis
On 04/13/2012 06:25 AM, Petr Viktorin wrote: When the utility sets logging to console, the extra log message gets printed out there. I agree this isn't optimal. Attached patch removes the console log handler before logging the result. I read through log_manager, and found that I can do this mo

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-13 Thread Petr Viktorin
On 04/12/2012 01:30 PM, Petr Viktorin wrote: On 04/10/2012 10:41 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliant

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-12 Thread John Dennis
On 03/30/2012 06:21 AM, Petr Viktorin wrote: Updated patch: only log if logging has been configured (detected by looking at the root logger's handlers), and changed the message to “The ipa-server-install command has succeeded/failed”. Actually the log_manager has an attribute called configure_s

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-12 Thread Petr Viktorin
On 04/10/2012 10:41 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that s

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-10 Thread Rob Crittenden
Petr Viktorin wrote: On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arg

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-04-04 Thread Petr Viktorin
On 03/30/2012 11:00 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-30 Thread Rob Crittenden
Petr Viktorin wrote: On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-30 Thread Petr Viktorin
On 03/26/2012 05:35 PM, Petr Viktorin wrote: On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup to detect ipa-server-

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-26 Thread Petr Viktorin
On 03/26/2012 04:54 PM, Rob Crittenden wrote: Some minor compliants. Ideally, there would be a routine that sets up the logging and handles command-line arguments in some uniform way (which is also needed before logging setup to detect ipa-server-install --uninstall). The original patch did

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-26 Thread Rob Crittenden
Petr Viktorin wrote: On 03/15/2012 11:30 AM, Petr Viktorin wrote: On 03/01/2012 11:45 AM, Petr Viktorin wrote: On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes ht

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-23 Thread Petr Viktorin
On 03/15/2012 11:30 AM, Petr Viktorin wrote: On 03/01/2012 11:45 AM, Petr Viktorin wrote: On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-15 Thread Petr Viktorin
On 03/01/2012 11:45 AM, Petr Viktorin wrote: On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2071 (Add final debug message

Re: [Freeipa-devel] [PATCH] 0014 Add final debug message in installers

2012-03-01 Thread Petr Viktorin
On 02/29/2012 07:46 PM, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-27 at 17:51 +0100, Petr Viktorin wrote: On 02/22/2012 10:41 AM, Petr Viktorin wrote: This fixes https://fedorahosted.org/freeipa/ticket/2071 (Add final debug message in installers). The try/except blocks at the e