Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-25 Thread Martin Basti
On 08/24/2015 04:07 PM, Lenka Doudova wrote: Attached. Lenka On 08/24/2015 03:14 PM, Martin Basti wrote: NACK You have unmerged changes in the patch On 08/24/2015 02:14 PM, Lenka Doudova wrote: from ipatests.test_xmlrpc import objectclasses + HEAD from ipatests.test_xmlrpc.xmlrpc_test

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Lenka Doudova
... and adding a patch version applicable for master branch Lenka On 08/24/2015 12:14 PM, Lenka Doudova wrote: On 08/20/2015 03:48 PM, Martin Basti wrote: On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Martin Basti
NACK You have unmerged changes in the patch On 08/24/2015 02:14 PM, Lenka Doudova wrote: from ipatests.test_xmlrpc import objectclasses + HEAD from ipatests.test_xmlrpc.xmlrpc_test import ( Declarative, fuzzy_digits, fuzzy_uuid, fuzzy_set_ci, add_sid, add_oc) +=== +from

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-24 Thread Lenka Doudova
On 08/20/2015 03:48 PM, Martin Basti wrote: On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-20 Thread Martin Basti
On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not fixed/changed. If the command remains and is fixed, the

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-18 Thread Martin Basti
On 08/14/2015 06:32 PM, Lenka Doudova wrote: Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not fixed/changed. If the command remains and is fixed, the

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
NACK syntax error, missing ')' -from ipatests.util import assert_equal, assert_not_equal, raises +from ipatests.util import ( +assert_equal, assert_not_equal, raises, assert_deepequal I cannot apply this patch, please check it Sorry for the error, corrected patch attached. I also added

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Martin Basti
On 08/14/2015 11:04 AM, Lenka Doudova wrote: NACK syntax error, missing ')' -from ipatests.util import assert_equal, assert_not_equal, raises +from ipatests.util import ( +assert_equal, assert_not_equal, raises, assert_deepequal I cannot apply this patch, please check it Sorry for the

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-14 Thread Lenka Doudova
Yes, that is correct - it's malfunctioning behavior of the plugin - command 'stageuser-add --from-delete', which is discussed in another thread. I left this test case for so long as it's not fixed/changed. If the command remains and is fixed, the test case will be valid, if it's changed I'll

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-13 Thread Martin Basti
On 08/11/2015 10:57 AM, Lenka Doudova wrote: On 08/11/2015 10:06 AM, thierry bordaz wrote: On 08/04/2015 01:37 PM, Lenka Doudova wrote: Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-11 Thread Lenka Doudova
On 08/11/2015 10:06 AM, thierry bordaz wrote: On 08/04/2015 01:37 PM, Lenka Doudova wrote: Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-11 Thread thierry bordaz
On 08/04/2015 01:37 PM, Lenka Doudova wrote: Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-08-04 Thread Lenka Doudova
Dne 30.7.2015 v 16:10 Martin Basti napsal(a): On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-30 Thread Martin Basti
On 30/07/15 16:09, Martin Basti wrote: On 29/07/15 16:10, Martin Basti wrote: On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On 27/07/15 16:47, Lenka Doudova wrote: Hi, I'm attaching

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-29 Thread Lenka Doudova
Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On 27/07/15 16:47, Lenka Doudova wrote: Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-29 Thread Martin Basti
On 27/07/15 16:47, Lenka Doudova wrote: Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test is affected as well (one class was added). The tests seem a bit of a mess even to myself, but what with the way

Re: [Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-29 Thread Martin Basti
On 29/07/15 15:29, Lenka Doudova wrote: Hi, thanks a lot for the comments, will work on it tomorrow. Lenka Dne 29.7.2015 v 15:27 Martin Basti napsal(a): On 27/07/15 16:47, Lenka Doudova wrote: Hi, I'm attaching a patch with automated tests for stageuser plugin

[Freeipa-devel] [PATCH 0002] TEST: Stageuser plugin

2015-07-27 Thread Lenka Doudova
Hi, I'm attaching a patch with automated tests for stageuser plugin (https://fedorahosted.org/freeipa/ticket/3813). The user plugin test is affected as well (one class was added). The tests seem a bit of a mess even to myself, but what with the way freeipa behaves I didn't know how else to