Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-04-03 Thread Martin Kosek
On 03/24/2014 02:33 PM, Nathaniel McCallum wrote: > On Wed, 2014-03-19 at 17:37 +0200, Alexander Bokovoy wrote: >> On Fri, 21 Feb 2014, Nathaniel McCallum wrote: >>> On Fri, 2014-02-21 at 00:08 +0200, Alexander Bokovoy wrote: On Thu, 20 Feb 2014, Nathaniel McCallum wrote: > There is an

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-03-24 Thread Nathaniel McCallum
On Wed, 2014-03-19 at 17:37 +0200, Alexander Bokovoy wrote: > On Fri, 21 Feb 2014, Nathaniel McCallum wrote: > >On Fri, 2014-02-21 at 00:08 +0200, Alexander Bokovoy wrote: > >> On Thu, 20 Feb 2014, Nathaniel McCallum wrote: > >> >> > >>There is an error in libotp's find() function which assumes tha

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-03-19 Thread Alexander Bokovoy
On Fri, 21 Feb 2014, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 00:08 +0200, Alexander Bokovoy wrote: On Thu, 20 Feb 2014, Nathaniel McCallum wrote: >> > >>There is an error in libotp's find() function which assumes that >> > >>get_basedn() always returns non-NULL value. This is not true fo

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 00:08 +0200, Alexander Bokovoy wrote: > On Thu, 20 Feb 2014, Nathaniel McCallum wrote: > >> > >>There is an error in libotp's find() function which assumes that > >> > >>get_basedn() always returns non-NULL value. This is not true for at > >> > >>least cn=Directory Manager. >

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Petr Viktorin
On 02/20/2014 07:45 PM, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered a

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Alexander Bokovoy
On Thu, 20 Feb 2014, Nathaniel McCallum wrote: From ead3ef011667dadacfc817725179f38c05177a00 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 20 Feb 2014 13:20:01 -0500 Subject: [PATCH 6/8] Fix a typo where self was omitted https://fedorahosted.org/freeipa/ticket/4099 --- ipalib/plu

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Alexander Bokovoy
On Thu, 20 Feb 2014, Nathaniel McCallum wrote: > >>There is an error in libotp's find() function which assumes that > >>get_basedn() always returns non-NULL value. This is not true for at > >>least cn=Directory Manager. > >> > >>Patch attached. > >More fixes required, now that Thierry produced th

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Nathaniel McCallum
On Fri, 2014-02-14 at 14:13 +0200, Alexander Bokovoy wrote: > On Wed, 12 Feb 2014, Nathaniel McCallum wrote: > >Through the review process, patches are getting shifted around, added, > >deleted, etc. So I'm now just going to be posting all the patches as an > >ordered set. The set attached is order

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Nathaniel McCallum
On Thu, 2014-02-20 at 09:19 -0500, Nathaniel McCallum wrote: > On Thu, 2014-02-20 at 14:33 +0200, Alexander Bokovoy wrote: > > On Thu, 20 Feb 2014, Alexander Bokovoy wrote: > > >There is definitely a bug (or more) in ipa-pwd-extop in handling > > >authentication cases. > > Some progress

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Nathaniel McCallum
On Thu, 2014-02-20 at 14:33 +0200, Alexander Bokovoy wrote: > On Thu, 20 Feb 2014, Alexander Bokovoy wrote: > >There is definitely a bug (or more) in ipa-pwd-extop in handling > >authentication cases. > Some progress on this investigation. > > Plugin precedence setting is broke

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Alexander Bokovoy
On Thu, 20 Feb 2014, Alexander Bokovoy wrote: There is definitely a bug (or more) in ipa-pwd-extop in handling authentication cases. Some progress on this investigation. Plugin precedence setting is broken in 389-ds. It is only set once, before running init function provided by the plugin and d

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-20 Thread Alexander Bokovoy
On Wed, 19 Feb 2014, Alexander Bokovoy wrote: On Wed, 19 Feb 2014, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Alexander Bokovoy wrote: On Thu, 13 Feb 2014, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-19 Thread Alexander Bokovoy
On Wed, 19 Feb 2014, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Alexander Bokovoy wrote: On Thu, 13 Feb 2014, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-19 Thread Alexander Bokovoy
On Mon, 17 Feb 2014, Alexander Bokovoy wrote: On Thu, 13 Feb 2014, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set.

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-18 Thread Alexander Bokovoy
On Tue, 18 Feb 2014, Petr Viktorin wrote: On 02/17/2014 06:17 PM, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-18 Thread Petr Viktorin
On 02/17/2014 06:17 PM, Alexander Bokovoy wrote: On Mon, 17 Feb 2014, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches a

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Alexander Bokovoy
On Mon, 17 Feb 2014, Nathaniel McCallum wrote: On Mon, 2014-02-17 at 12:32 +0200, Alexander Bokovoy wrote: On Thu, 13 Feb 2014, Alexander Bokovoy wrote: >On Wed, 12 Feb 2014, Nathaniel McCallum wrote: >>Through the review process, patches are getting shifted around, added, >>deleted, etc. So I'm

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Nathaniel McCallum
On Mon, 2014-02-17 at 12:32 +0200, Alexander Bokovoy wrote: > On Thu, 13 Feb 2014, Alexander Bokovoy wrote: > >On Wed, 12 Feb 2014, Nathaniel McCallum wrote: > >>Through the review process, patches are getting shifted around, added, > >>deleted, etc. So I'm now just going to be posting all the patc

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Alexander Bokovoy
On Mon, 17 Feb 2014, Nathaniel McCallum wrote: From 357cc6a40c58f3f88f8e86c5224f2c042ab974d8 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Mon, 16 Dec 2013 16:19:08 -0500 Subject: [PATCH 2/4] Add OTP last token plugin This plugin prevents the deletion or deactivation of the last vali

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Alexander Bokovoy
On patch 0001: On Mon, 17 Feb 2014, Nathaniel McCallum wrote: index 9cb9d71a81bc1f1089017a2236b4b7b94946ed35..8ab09e92b64b6a2f31c9c25d61a7dacc9fa608e8 100644 --- a/VERSION +++ b/VERSION @@ -90,4 +90,4 @@ IPA_DATA_VERSION=2010061412 I

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Alexander Bokovoy
On Mon, 17 Feb 2014, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered acco

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-17 Thread Alexander Bokovoy
On Thu, 13 Feb 2014, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my pre

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 12:37 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 01:13 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Petr Viktorin
On 02/14/2014 12:39 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Alexander Bokovoy
On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my preferred merge order. It also places easy to revi

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Alexander Bokovoy
On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my preferred merge order. It also places easy to revi

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-14 Thread Alexander Bokovoy
On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my preferred merge order. It also places easy to revi

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-13 Thread Petr Viktorin
On 02/13/2014 06:56 PM, Alexander Bokovoy wrote: On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-13 Thread Alexander Bokovoy
On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my preferred merge order. It also places easy to revi

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-13 Thread Alexander Bokovoy
On Wed, 12 Feb 2014, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered according to my preferred merge order. It also places easy to revi