URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns are related purely to C-code.
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
dkupka commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/329f080e6ac832ffd568e79ebca9907771f8ad61
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
Re-adding ACK which was removed while we were "resolving" our disagreement with
Lukas.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
We (lslebodn and pspacek) agree that we disagree about maintainability of
client_only in one monolithic configure.ac.
But we agreed that the refactoring of build system[1] is
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (21/10/16 00:41), Petr Špaček wrote:
>> Correct me If I am wrong. The configure script is and will be used
>just for detection of build dependencies for C-code.
>
>Maybe
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
> Correct me If I am wrong. The configure script is and will be used
just for detection of build dependencies for C-code.
Maybe this is why we do not understand each other.
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns are related purely to
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
On (20/10/16 10:29), Petr Špaček wrote:
>@lslebodn I'm really trying to explain this but I'm still not able to get the
>point across.
>> My concerns are related purely to
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
This PR including additional patches on top have passed build + all XMLRPC
tests in Jenkins:
job/build_refactoring-build-f24build_refactoring/18/
Additional commits can be found
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
@lslebodn I'm really trying to explain this but I'm still not able to get the
point across.
> My concerns are related purely to C-code.
Please understand that IPA client consists
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
This version replaces ipaplatform magic with symlinks generated by configure.
It should work with jcholast's PR 159.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you claim, especially when we count
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you claim, especially when we count
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> 08:53 < pspacek> lslebodn: I would appreciate patch showing the nicer
> solution to me. I do not think it
> is that easy as you claim, especially when we count
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
tiran commented:
"""
ACK
make rpms is passing on my machine.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-255099321
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
tiran commented:
"""
I agree with @lslebodn . It should be possible to build only the necessary bits
and pieces for an IPA client. It should be rather simple to implement a
```--without-server```
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
tiran commented:
"""
I agree with @lslebodn . It should be possible to build only the necessary bits
and pieces for an IPA client. It should be rather simple to implement a
```--without-server```
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
> Please note that current client-only build is quite broken and requires heavy
> machinery in downstream spec file so it is hard to speak about any reusage.
That's the problem of
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
@lslebodn Please discuss this matter on freeipa-devel list to gethigher
visibility.
Please note that current client-only build is quite broken and requires heavy
machinery in
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
My proposal would not require any reimplementation because it will reuse
current solution.
And I would like to know the reasons why upstream might consider to drop
client_only
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
@lslebodn Decision if we need client_only build is still open. We may drop it
so reimplementing it would be busy work.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
BTW I am really interested in how do you plan to implement client only build.
IMHO it would be much simpler include reduced version of daemon/configure.ac
(+others)
into top
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
I see you need to increase patch_count and not to have proper review
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254820687
--
Manage
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
mbasti-rh commented:
"""
I see just bikeshading here, on IRC Petr1 agreed that this should be pushed and
incrementally upgraded according our needs
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
@lslebodn If you read the pull request description you will notice that
client-only build will be solved later on.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
BTW.
previously it was possible to build just a client code. But after these changes
configure will require to have installed even daemon dependencies If someone
decide to build
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
I consider CURL topic to be just bikesheding.
Ad POPT: RHEL is going to require explicit configuration as designed in
http://www.freeipa.org/page/V4/Build_system_refactoring
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
and the explanation for changing curl is not appropriate.
-1
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254800904
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
stlaz commented:
"""
+1 to push, the comments were added to outdated diffs so I thought them
resolved. They are now.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
I am sorry I still do not agree with popt change reducing 3lines to 1 is not
huge simplification.
And it does not work on rhel7.2
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
Justification is above, please push.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254800046
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
-ACK,
my comments has not been addressed yet.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254797969
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
stlaz commented:
"""
ACK, works for me.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/171#issuecomment-254788258
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
lslebodn commented:
"""
ACK to
Build: modernize SASL library detection
Build: modernize XMLRPC-client library detection
Build: cleanup INI library detection
It would be good to push them if you do not
URL: https://github.com/freeipa/freeipa/pull/171
Title: #171: Build system cleanup phase 2
pspacek commented:
"""
This version fixes minor problems in error reporing and should have no other
visible effect.
"""
See the full comment at
35 matches
Mail list logo
