URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
master:
* 3064b890e24a5056c77f19c3951cfb59d49366f8 Conditionally import pyhbac
* 7c9df35d3dd812543cf537c0762c6db728379919 Add
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
Can you rebase please? I see Ben's commits in this PR
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
Sigh, I got it.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/397#issuecomment-291091639
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
Missing dependency `dbus-glib-devel` otherwise it works
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
@tiran sorry, but then something doesn't work as expected
```
$ dnf builddep -b -D "with_wheels 1" --spec freeipa.spec.in
$ make
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@MartinBasti ```dbus-devel``` is in the ```with_wheels``` section.
Documentation is part of https://pagure.io/freeipa/issue/6842 .
"""
See
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
So put it into specfile to `with_wheels` section
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
And document in `BUILD.txt` how to build wheels
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
You need dbus-devel package.
I opened https://pagure.io/freeipa/issue/6842 to track lack of documentation.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
Build failed:
```
make wheel_bundle IPA_SERVER_WHEELS=1
...
checking for DBUS... no
configure: error: Package requirements (dbus-1
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
Thanks @MartinBasti
I rebased the PR and added a small workaround for ```dbus-python```. The
package uses make to compile some of its
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
HonzaCholasta commented:
"""
LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/397#issuecomment-290632228
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
MartinBasti commented:
"""
Please rebase, it is ok to me, I see potential for future server unit testing.
I will test when rebased. If somebody is against this
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
PR is blocked by #613
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/397#issuecomment-288357734
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
I've moved the code to cert.py and raise SkipPluginModule from there.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@jdennis released python-nss 1.0.1. I removed my workaround.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
I didn't know about the ```SkipPluginModule``` feature. I agree with you, your
solution is more elegant.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
HonzaCholasta commented:
"""
The trust plugin and other trust bits are optional. The cert plugin, which
depends on `pyhbac`, is *not* optional, so you can't apply
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@HonzaCholasta FreeIPA has conditional imports for SSSD modules in several
places, e.g. in the trust plugin. 96f614e closes the gap and
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
HonzaCholasta commented:
"""
I can't say I agree with this approach. If this is just for testing, surely you
can work around the missing `pyhbac` in some isolated
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
To clarify and emphasis, this PR has nothing to do with the PyPI packaging
effort. Zero. Zip. Nada. Nilch!
The sole intent of this PR is
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
tiran commented:
"""
@pvoborni The main reason for this PR is explained in the initial PR message. I
like to run an IPA framework server with specially
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
stlaz commented:
"""
@pvoborni The remaining usages are server/CA certificates verification in
`certdb.py` and and apparently some encryption/decryption actions
URL: https://github.com/freeipa/freeipa/pull/397
Title: #397: Improve wheel building and provide ipaserver wheel for local
testing
pvoborni commented:
"""
@tiran I have very vague idea how this is helpful. You have mentioned it
during post-devconf "API meeting". But I no longer remember it
24 matches
Mail list logo
