Re: [Freeipa-devel] Reviewer in Trac

2014-02-25 Thread Jakub Hrozek
On Thu, Feb 20, 2014 at 02:11:08PM -0500, Simo Sorce wrote: > On Thu, 2014-02-20 at 17:29 +0100, Petr Viktorin wrote: > > Patchwork: > > patch arrives: nothing > > mark self as reviewer: use web interface > > send review: reply, find patch in Patchwork, mark status > > send fixed patch: sen

Re: [Freeipa-devel] Reviewer in Trac

2014-02-21 Thread Martin Kosek
On 02/20/2014 01:14 PM, Martin Kosek wrote: > We had a discussion with other developers how better track who is reviewing > which patch. Recently, we introduced the Reviewed-By tag in a commit message, > but that is a post-review tag which is not useful for someone who wants to > know > which patc

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 10:32 PM, Lukas Slebodnik wrote: > On (20/02/14 15:09), Martin Kosek wrote: >> On 02/20/2014 02:54 PM, Petr Spacek wrote: >>> On 20.2.2014 14:47, Martin Kosek wrote: On 02/20/2014 02:31 PM, Jan Cholasta wrote: > On 20.2.2014 13:14, Martin Kosek wrote: >> We had a discussi

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Spacek
On 20.2.2014 20:08, Martin Kosek wrote: But I think a simple script like "startreview.py some.patch" that Petr mentioned is a good start, few lines of code. I have modified my push.py to start_review.py. Clone https://github.com/spacekpe/freeipa-processes.git and read the commit message :-) I

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Lukas Slebodnik
On (20/02/14 15:09), Martin Kosek wrote: >On 02/20/2014 02:54 PM, Petr Spacek wrote: >> On 20.2.2014 14:47, Martin Kosek wrote: >>> On 02/20/2014 02:31 PM, Jan Cholasta wrote: On 20.2.2014 13:14, Martin Kosek wrote: > We had a discussion with other developers how better track who is >

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 04:41 PM, Petr Spacek wrote: On 20.2.2014 16:34, Petr Viktorin wrote: ... Note that Trac has XMLRPC so it is very very easy to have script for review assignment etc. $ start_review.py somerandomstring.patch can very easily grep ticket URL and add your name to 'Reviewer' field in t

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Simo Sorce
On Thu, 2014-02-20 at 17:29 +0100, Petr Viktorin wrote: > Patchwork: > patch arrives: nothing > mark self as reviewer: use web interface > send review: reply, find patch in Patchwork, mark status > send fixed patch: send the mail, find patch in Patchwork, mark > status, > find old patch in

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 05:29 PM, Petr Viktorin wrote: On 02/20/2014 04:55 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:34 +0100, Petr Viktorin wrote: ... Mail+Trac: patch arrives: tag message TODO when it comes in (1 keystroke) mark self as reviewer: use web interface (or API) send review: just

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Dmitri Pal
On 02/20/2014 08:15 AM, Martin Kosek wrote: On 02/20/2014 02:02 PM, Petr Spacek wrote: On 20.2.2014 13:31, Sumit Bose wrote: On Thu, Feb 20, 2014 at 01:14:50PM +0100, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we intro

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 04:55 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:34 +0100, Petr Viktorin wrote: On 02/20/2014 04:15 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote:

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Simo Sorce
On Thu, 2014-02-20 at 16:43 +0100, Tomas Babej wrote: > > No. The only thing that happened automatically in Patchwork was that > > entries got created. Patchwork doesn't even have threads - each > > version of a patch needed to be individually marked as superseded. > > Very much mindless clicking

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Simo Sorce
On Thu, 2014-02-20 at 16:34 +0100, Petr Viktorin wrote: > On 02/20/2014 04:15 PM, Simo Sorce wrote: > > On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: > >> On 02/20/2014 04:09 PM, Simo Sorce wrote: > >>> On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: > On 02/20/2014 03:52 PM, J

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Tomas Babej
On 02/20/2014 04:34 PM, Petr Viktorin wrote: > On 02/20/2014 04:15 PM, Simo Sorce wrote: >> On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: >>> On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: > On 02/20/2014 03:52 PM, Jakub Hrozek wr

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Spacek
On 20.2.2014 16:34, Petr Viktorin wrote: On 02/20/2014 04:15 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: On 02/20/2014 03:52 PM, Jakub Hrozek wrote: On Thu, Feb 2

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: On 02/20/2014 03:52 PM, Jakub Hrozek wrote: On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: On 02/20/2014 0

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 04:15 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: On 02/20/2014 04:09 PM, Simo Sorce wrote: On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: On 02/20/2014 03:52 PM, Jakub Hrozek wrote: On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Jakub Hrozek
On Thu, Feb 20, 2014 at 10:15:23AM -0500, Simo Sorce wrote: > On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: > > On 02/20/2014 04:09 PM, Simo Sorce wrote: > > > On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: > > >> On 02/20/2014 03:52 PM, Jakub Hrozek wrote: > > >>> On Thu, Feb 20,

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Simo Sorce
On Thu, 2014-02-20 at 16:13 +0100, Martin Kosek wrote: > On 02/20/2014 04:09 PM, Simo Sorce wrote: > > On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: > >> On 02/20/2014 03:52 PM, Jakub Hrozek wrote: > >>> On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: > On 02/20/2014 01

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 04:09 PM, Simo Sorce wrote: > On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: >> On 02/20/2014 03:52 PM, Jakub Hrozek wrote: >>> On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: On 02/20/2014 01:14 PM, Martin Kosek wrote: > We had a discussion with other

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Simo Sorce
On Thu, 2014-02-20 at 15:59 +0100, Martin Kosek wrote: > On 02/20/2014 03:52 PM, Jakub Hrozek wrote: > > On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: > >> On 02/20/2014 01:14 PM, Martin Kosek wrote: > >>> We had a discussion with other developers how better track who is > >>> rev

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 03:52 PM, Jakub Hrozek wrote: > On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: >> On 02/20/2014 01:14 PM, Martin Kosek wrote: >>> We had a discussion with other developers how better track who is reviewing >>> which patch. Recently, we introduced the Reviewed-By tag in

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Jakub Hrozek
On Thu, Feb 20, 2014 at 01:22:56PM +0100, Petr Viktorin wrote: > On 02/20/2014 01:14 PM, Martin Kosek wrote: > >We had a discussion with other developers how better track who is reviewing > >which patch. Recently, we introduced the Reviewed-By tag in a commit message, > >but that is a post-review t

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 02:54 PM, Petr Spacek wrote: > On 20.2.2014 14:47, Martin Kosek wrote: >> On 02/20/2014 02:31 PM, Jan Cholasta wrote: >>> On 20.2.2014 13:14, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Spacek
On 20.2.2014 14:47, Martin Kosek wrote: On 02/20/2014 02:31 PM, Jan Cholasta wrote: On 20.2.2014 13:14, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a pos

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Spacek
On 20.2.2014 14:31, Jan Cholasta wrote: On 20.2.2014 13:14, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not useful for someone

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 02:31 PM, Jan Cholasta wrote: > On 20.2.2014 13:14, Martin Kosek wrote: >> We had a discussion with other developers how better track who is reviewing >> which patch. Recently, we introduced the Reviewed-By tag in a commit message, >> but that is a post-review tag which is not useful

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Jan Cholasta
On 20.2.2014 13:14, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not useful for someone who wants to know which patches are alrea

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 02:02 PM, Petr Spacek wrote: > On 20.2.2014 13:31, Sumit Bose wrote: >> On Thu, Feb 20, 2014 at 01:14:50PM +0100, Martin Kosek wrote: >>> We had a discussion with other developers how better track who is reviewing >>> which patch. Recently, we introduced the Reviewed-By tag in a commi

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Spacek
On 20.2.2014 13:31, Sumit Bose wrote: On Thu, Feb 20, 2014 at 01:14:50PM +0100, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 01:36 PM, Martin Kosek wrote: On 02/20/2014 01:22 PM, Petr Viktorin wrote: On 02/20/2014 01:14 PM, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
On 02/20/2014 01:22 PM, Petr Viktorin wrote: > On 02/20/2014 01:14 PM, Martin Kosek wrote: >> We had a discussion with other developers how better track who is reviewing >> which patch. Recently, we introduced the Reviewed-By tag in a commit message, >> but that is a post-review tag which is not us

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Tomas Babej
On 02/20/2014 01:22 PM, Petr Viktorin wrote: > On 02/20/2014 01:14 PM, Martin Kosek wrote: >> We had a discussion with other developers how better track who is >> reviewing >> which patch. Recently, we introduced the Reviewed-By tag in a commit >> message, >> but that is a post-review tag which is

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Sumit Bose
On Thu, Feb 20, 2014 at 01:14:50PM +0100, Martin Kosek wrote: > We had a discussion with other developers how better track who is reviewing > which patch. Recently, we introduced the Reviewed-By tag in a commit message, > but that is a post-review tag which is not useful for someone who wants to >

Re: [Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Petr Viktorin
On 02/20/2014 01:14 PM, Martin Kosek wrote: We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not useful for someone who wants to know which patches are a

[Freeipa-devel] Reviewer in Trac

2014-02-20 Thread Martin Kosek
We had a discussion with other developers how better track who is reviewing which patch. Recently, we introduced the Reviewed-By tag in a commit message, but that is a post-review tag which is not useful for someone who wants to know which patches are already reviewed and which are not reviewed. W