Re: [Freeipa-devel] [PATCH] 632 add migration cmd docs

2010-12-13 Thread Rob Crittenden
David O'Brien wrote: Rob Crittenden wrote: Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2010 05:50 PM, Rob Crittenden wrote: Add some documentation to the migrate-ds command. rob Ack pushed to master Apologies for the late review; I've been off sick for

Re: [Freeipa-devel] [PATCH] 641 Check for existence of the group when adding a user.

2010-12-13 Thread Rob Crittenden
Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: The Managed Entries plugin will allow a user to be added even if a group of the same name exists. This would leave the user without a private group. We need to check for both the user and the group so we can do 1 of 3 things: - throw

Re: [Freeipa-devel] [PATCH] 643 Better handle permission updates

2010-12-13 Thread Rob Crittenden
Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: permissions are a real group pointed to by an aci, managed by the same plugin. Any given update can update one or both or neither. Do a better job at determining what it is that needs to be updated and handle the case where only the

Re: [Freeipa-devel] [PATCH] 635 wait for memberof plugin when doing reverse members

2010-12-13 Thread Rob Crittenden
Jan Zeleny wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Give the memberof plugin time to work when adding/removing reverse members. When we add/remove reverse members it looks like we're operating on group A but we're really

Re: [Freeipa-devel] UI seems to be completely broken

2010-12-13 Thread Dmitri Pal
David O'Brien wrote: Adam Young wrote: On 12/11/2010 10:41 AM, Dmitri Pal wrote: Adam Young wrote: On 12/10/2010 02:01 PM, Dmitri Pal wrote: Hi, I installed today build. I can get to the static frame with green line and rigt user name which indicates that I actually connected and

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Dmitri Pal
Dmitri Pal wrote: Adam Young wrote: Dmitri, While I don't expect you to do the review of the patch, I would appreciate at least a visual inspection of the completed UI. Since there seems to be something wrong with the install/UI right now, I've posed the lates on my Fedora People page.

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Adam Young
Lets walk through it tomorrow when I am in the office. On 12/13/2010 11:05 AM, Dmitri Pal wrote: Adam Young wrote: Dmitri, While I don't expect you to do the review of the patch, I would appreciate at least a visual inspection of the completed UI. Since there seems to be something

[Freeipa-devel] [PATCH] admiyo-0117-aci-unit-tests

2010-12-13 Thread Adam Young
This depends on my patch 0116. Something not mentioned in the commit message is that this also fixes the 'filter only' options. From c676e7a85fc679307a4639b8328a2230984eebe3 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Mon, 13 Dec 2010 12:48:09 -0500 Subject: [PATCH] aci

[Freeipa-devel] [Patch] sudo run as user or group AND tests

2010-12-13 Thread JR Aquino
Attached are patches to address: (https://fedorahosted.org/freeipa/ticket/570) 5) -The UI needs separate run-as-user and run-as-group categories for the As Whom section. The UI also needs a way to manage the list of users/groups for the run-as-user, and the list of groups for the run-as-group.

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Adam Young
On 12/13/2010 11:05 AM, Dmitri Pal wrote: Adam Young wrote: Dmitri, While I don't expect you to do the review of the patch, I would appreciate at least a visual inspection of the completed UI. Since there seems to be something wrong with the install/UI right now, I've posed the lates on

[Freeipa-devel] [PATCH] 646 move updates to bootstrap

2010-12-13 Thread Rob Crittenden
Move a bunch of objects created by the updater into the bootstrap ldif. It is cleaner to do it this way (and probably a bit faster too). rob From 4094295ade03897b62f14b1b5ff4a59227fadf1b Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Mon, 13 Dec 2010 13:23:04 -0500

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Dmitri Pal
In addition to the issues I explain above here is what I also noticed: 1) As we mentioned there is no Description in ACI. The description and name is the same field for ACI. Description is in the Meta data, and gets returned with ipa permission_show, role_show, and privilege_show May

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Adam Young
On 12/13/2010 01:28 PM, Dmitri Pal wrote: In addition to the issues I explain above here is what I also noticed: 1) As we mentioned there is no Description in ACI. The description and name is the same field for ACI. Description is in the Meta data, and gets returned with ipa

[Freeipa-devel] [PATCH] 647 check for 389-ds replication plugin

2010-12-13 Thread Rob Crittenden
Ensure that the replication plugin exists before creeating or installing a replica. ticket 502 rob From 5c751cd54b203e92db9e9d0f77f4147f717cf27b Mon Sep 17 00:00:00 2001 From: Rob Crittenden rcrit...@redhat.com Date: Mon, 13 Dec 2010 14:28:11 -0500 Subject: [PATCH] Verify that the replication

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Adam Young
On 12/13/2010 11:27 AM, Dmitri Pal wrote: Sorry this whole part just does not make sense to me. What is the target group? Where it came from? One ACI that uses this is 'add_user_to_default_group. This is used in the permission 'useradmin'. The json response for permission-show

Re: [Freeipa-devel] ACI permissions UI up for review

2010-12-13 Thread Dmitri Pal
Adam Young wrote: On 12/13/2010 11:27 AM, Dmitri Pal wrote: Sorry this whole part just does not make sense to me. What is the target group? Where it came from? One ACI that uses this is 'add_user_to_default_group. This is used in the permission 'useradmin'. The json response for

Re: [Freeipa-devel] [Patch] sudo run as user or group AND tests

2010-12-13 Thread Rob Crittenden
JR Aquino wrote: Attached are patches to address: (https://fedorahosted.org/freeipa/ticket/570) 5) -The UI needs separate run-as-user and run-as-group categories for the As Whom section. The UI also needs a way to manage the list of users/groups for the run-as-user, and the list of groups

Re: [Freeipa-devel] [PATCH] managed entry hostgroup netgroup support

2010-12-13 Thread Rob Crittenden
JR Aquino wrote: On 12/10/10 12:49 PM, Rob Crittendenrcrit...@redhat.com wrote: nack, found a couple of minor issues: - The patch doesn't apply against the master branch (probably from Simo's recent changes there) - looks like you copied the man page from ipa-ldap-updater, needs a few more

Re: [Freeipa-devel] [PATCH] 635 wait for memberof plugin when doing reverse members

2010-12-13 Thread Rob Crittenden
Jan Zelený wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zeleny wrote: Rob Crittendenrcrit...@redhat.com wrote: Jan Zelený wrote: Rob Crittendenrcrit...@redhat.comwrote: Give the memberof plugin time to work when adding/removing reverse members. When we add/remove reverse

Re: [Freeipa-devel] [PATCH] 637 group to group delegation

2010-12-13 Thread Adam Young
On 12/10/2010 01:36 PM, Rob Crittenden wrote: Rob Crittenden wrote: Rob Crittenden wrote: Round out our trio of access control plugins. This adds group to group delegation where you can grant group A the ability to write a set of attributes of group B (v1-style delegation). rob I'm