Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Martin Kosek
On Sun, 2012-02-26 at 11:22 -0500, John Dennis wrote: ... There is one other minor issue not included in any previous patches nor this one, the VERSION file should be updated to force the apache configuration to be updated. Thanks for the patches John, a lot of work have been done. I would

Re: [Freeipa-devel] [PATCH] 967 add requires on oddjob-mkhomedir

2012-02-27 Thread Martin Kosek
On Fri, 2012-02-24 at 16:45 -0500, Rob Crittenden wrote: Add Requires oddjob-mkhomedir on the client subpackage. This will avoid SELinux issues if mkhomedir is configured. rob ACK. I just needed to fix the log in the spec file, I am sure I am not an author of the change in 967 :-) Pushed

[Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-27 Thread Petr Viktorin
Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations is validated (#2407). Patch 17 makes these options honor params marked

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Martin Kosek
On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget the ending $. Thus it matches any string with the right beginning. Like this one: # ipa netgroup-add

Re: [Freeipa-devel] [PATCH] 935 fix winsync replica management

2012-02-27 Thread Martin Kosek
On Fri, 2012-01-27 at 13:21 -0500, Rob Crittenden wrote: The ipa-replica-manage tool was trying to contact the AD server to do replica management including re-initialize, force-sync and del. The AD server is unaware of IPA, the winsync plugin handles this for us. This patch avoids contact

Re: [Freeipa-devel] [PATCH] 943 detect duplicate winsync agreement

2012-02-27 Thread Martin Kosek
On Fri, 2012-02-24 at 13:09 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2012-02-08 at 14:52 -0500, Rob Crittenden wrote: We currnently only support a single winsync agreement against any given host so all we need to do is check to see if we have one with the remote host.

Re: [Freeipa-devel] [PATCH] 968 don't allow reconnection to deleted master

2012-02-27 Thread Martin Kosek
On Sat, 2012-02-25 at 17:43 -0500, Rob Crittenden wrote: This patch does two things: 1. Prompts when deleting a master to make clear that this is irreversible 2. Does not allow a deleted master to be reconnected. Reconnecting to a deleted master causes all heck to break loose because we

Re: [Freeipa-devel] [PATCH] 14 ipa permission-add does not fail if using invalid attribute

2012-02-27 Thread Rob Crittenden
Ondrej Hamada wrote: When adding or modifying permission with both type and attributes specified, check whether the attributes are allowed for specified type. In case of disallowed attributes the InvalidSyntax error is raised. New tests were also added to the unit-tests.

[Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as binary internally). This will result in a base64 encoded blob be

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 03:44 PM, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as binary internally).

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: On 02/27/2012 03:44 PM, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget the ending $. Thus it matches any string with the right beginning. Like this one:

Re: [Freeipa-devel] [PATCH] 970 ensure 389-ds is running during upgrade

2012-02-27 Thread Rob Crittenden
Simo Sorce wrote: On Sat, 2012-02-25 at 19:10 -0500, Rob Crittenden wrote: We need to start 389-ds when configuring memcached during an ugprade because that process adds the new service to cn=masters. ACK Simo. pushed to master and ipa-2-2 rob

Re: [Freeipa-devel] [PATCH] 202 Add reverse DNS record when forward is created

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-02-20 at 14:34 +0100, Martin Kosek wrote: On Fri, 2012-02-10 at 16:42 +0100, Martin Kosek wrote: On Tue, 2012-02-07 at 16:26 +0100, Martin Kosek wrote: On Mon, 2012-02-06 at 15:56 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-01-30 at 11:52

Re: [Freeipa-devel] [PATCH] 205 Remove UDP checks from conncheck

2012-02-27 Thread Martin Kosek
On Wed, 2012-02-01 at 17:55 +0100, Martin Kosek wrote: UDP port checks in ipa-replica-conncheck always returns OK even if they are closed by firewall. They cannot be reliably checked in the same way as TCP ports as there is no session management as in TCP protocol. We cannot guarantee a

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Simo Sorce
On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type (treated as

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Martin Kosek
On Mon, 2012-02-27 at 10:07 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget the ending $.

Re: [Freeipa-devel] [PATCH] 202 Add reverse DNS record when forward is created

2012-02-27 Thread Martin Kosek
On Mon, 2012-02-27 at 10:36 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2012-02-20 at 14:34 +0100, Martin Kosek wrote: On Fri, 2012-02-10 at 16:42 +0100, Martin Kosek wrote: On Tue, 2012-02-07 at 16:26 +0100, Martin Kosek wrote: On Mon, 2012-02-06 at 15:56 -0500, Rob

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as a python str type

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes. I've added a sanity checker to keep a value as

Re: [Freeipa-devel] [PATCH] 222 Sanitize UDP checks in conncheck

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: An easy way to check if master-replica UDP port check actually works is to simply configure few iptables rules to drop packets for tested UDP or TCP ports: A INPUT -m udp -p udp --dport 88 -j DROP -A INPUT -m tcp -p tcp --dport 88 -j DROP UDP port checks in

Re: [Freeipa-devel] [PATCH] 962 don't fail if SELinux isn't installed

2012-02-27 Thread Martin Kosek
On Wed, 2012-02-22 at 23:04 -0500, Rob Crittenden wrote: Check to see if SELinux is enabled and restorecon exists before trying to run it. This will prevent client install failures if SELinux isn't enabled. rob Works fine. Better safe than sorry. ACK. Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] [PATCH] 216 Add client hostname requirements to man

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: Changing a client hostname after ipa-client-install would break the enrollment on IPA server. Update relevant man pages to contain such information. https://fedorahosted.org/freeipa/ticket/1967 ACK ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 41 During ipa-client-install verify forward and reverse dns lookup of server

2012-02-27 Thread Rob Crittenden
JR Aquino wrote: ipa-server-install has a method for validating forward and reverse via ipaserver/install/installutils.py ipa-client-install does not currently have an equivalent This patch adds valid_dns to ipapython/ipautil.py to validate foward and reverse DNS This patch adds the valid_dns

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a Python bug where it reused the value of a default keyword

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Petr Viktorin
On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters into most attributes.

Re: [Freeipa-devel] [PATCH] 224 Add SSHFP update policy for existing zones

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: SSH public key support includes a feature to automatically add/update client SSH fingerprints in SSHFP records. However, the update won't work for zones created before this support was added as they don't allow clients to update SSHFP records in their update policies. This

Re: [Freeipa-devel] [PATCH] 216 Add client hostname requirements to man

2012-02-27 Thread Martin Kosek
On Mon, 2012-02-27 at 11:40 -0500, Rob Crittenden wrote: Martin Kosek wrote: Changing a client hostname after ipa-client-install would break the enrollment on IPA server. Update relevant man pages to contain such information. https://fedorahosted.org/freeipa/ticket/1967 ACK Pushed

Re: [Freeipa-devel] [PATCH] 224 Add SSHFP update policy for existing zones

2012-02-27 Thread Martin Kosek
On Mon, 2012-02-27 at 11:47 -0500, Rob Crittenden wrote: Martin Kosek wrote: SSH public key support includes a feature to automatically add/update client SSH fingerprints in SSHFP records. However, the update won't work for zones created before this support was added as they don't allow

Re: [Freeipa-devel] [PATCH] 41 During ipa-client-install verify forward and reverse dns lookup of server

2012-02-27 Thread JR Aquino
On Feb 27, 2012, at 8:43 AM, Rob Crittenden wrote: JR Aquino wrote: ipa-server-install has a method for validating forward and reverse via ipaserver/install/installutils.py ipa-client-install does not currently have an equivalent This patch adds valid_dns to ipapython/ipautil.py to validate

Re: [Freeipa-devel] [PATCH] 956 user lockout status

2012-02-27 Thread Martin Kosek
On Tue, 2012-02-21 at 17:41 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Tue, 2012-02-21 at 15:57 -0500, Rob Crittenden wrote: +other_ldap = ldap2(shared_instance=False, + ldap_uri='ldap://%s' % host, +

Re: [Freeipa-devel] [PATCH] 14 ipa permission-add does not fail if using invalid attribute

2012-02-27 Thread Ondrej Hamada
On 02/27/2012 03:22 PM, Rob Crittenden wrote: Ondrej Hamada wrote: When adding or modifying permission with both type and attributes specified, check whether the attributes are allowed for specified type. In case of disallowed attributes the InvalidSyntax error is raised. New tests were also

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a Python bug where it reused the value of a default

Re: [Freeipa-devel] [PATCH] 217-220 minor DNS fixes and improved validation

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-02-21 at 17:27 +0100, Martin Kosek wrote: This set of 3 DNS patches fixes 2 minor issues found during DNS test day (217, 218) and there is slightly longer patch (219) which improves and consolidates hostname/domain name validation. The testing should be pretty

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a

Re: [Freeipa-devel] [PATCH] 12 When migrating warn user if compat is enabled

2012-02-27 Thread Rob Crittenden
Ondrej Hamada wrote: On 02/21/2012 02:32 PM, Ondrej Hamada wrote: On 02/20/2012 06:53 PM, Rob Crittenden wrote: Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2274 Added check into migration plugin to warn user when compat is enabled. If compat is enabled, the migration fails

Re: [Freeipa-devel] Adding Debian support to the FreeIPA code

2012-02-27 Thread Simo Sorce
On Sun, 2012-02-26 at 21:41 +0200, Alexander Bokovoy wrote: Hi Krzysztof, first thank you for bringing up the topic of wider use of FreeIPA on different platforms. Thanks a lot indeed. The plan looks good, the only thing I'd like to stress is that we need to shot at maintainability and

Re: [Freeipa-devel] [PATCH] 41 During ipa-client-install verify forward and reverse dns lookup of server

2012-02-27 Thread Rob Crittenden
JR Aquino wrote: On Feb 27, 2012, at 8:43 AM, Rob Crittenden wrote: JR Aquino wrote: ipa-server-install has a method for validating forward and reverse via ipaserver/install/installutils.py ipa-client-install does not currently have an equivalent This patch adds valid_dns to

Re: [Freeipa-devel] [PATCH] 0008 - Make sure the nolog argument to ipautil.run is not a bare string

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: `ipautil.run` expects a tuple for its `nolog` argument, but works with any other iterable (sometimes we use lists as well). Since strings are also iterable, and yield their characters, this caused every individual character in the password to be replaced, leading to log

Re: [Freeipa-devel] [PATCHES] 0012-13 Don't allow deleting required config options

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: On 02/20/2012 08:51 PM, Rob Crittenden wrote: Petr Viktorin wrote: https://fedorahosted.org/freeipa/ticket/2159 says various config options are not marked Required, so entering an empty value for it will pass validation (and IPA will blow up later when it expects a

Re: [Freeipa-devel] [PATCHES] 0016-17 Fixes for{add, set, del}attr with managed attributes

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: Patch 16 defers validation conversion until after {add,del,set}attr is processed, so that we don't search for an integer in a list of strings (this caused ticket #2405), and so that the end result of these operations is validated (#2407). Patch 17 makes these options

Re: [Freeipa-devel] [PATCH] 0018 - Simplify CSV escaping syntax

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: This depends on my patch 0015. Since CSV escaping was entirely broken before that patch (however we decide to fix the problem), let's also fix the escaping syntax itself, without worrying about backwards compatibility. I tried to solve this according to Rob's comment on

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-02-27 at 10:07 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell

Re: [Freeipa-devel] [PATCH] 41 During ipa-client-install verify forward and reverse dns lookup of server

2012-02-27 Thread JR Aquino
On Feb 27, 2012, at 1:29 PM, Rob Crittenden wrote: JR Aquino wrote: On Feb 27, 2012, at 8:43 AM, Rob Crittenden wrote: JR Aquino wrote: ipa-server-install has a method for validating forward and reverse via ipaserver/install/installutils.py ipa-client-install does not currently have an

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 05:53 PM, Rob Crittenden wrote: John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate

Re: [Freeipa-devel] [PATCH] 971 detect binary LDAP data

2012-02-27 Thread Rob Crittenden
Petr Viktorin wrote: On 02/27/2012 05:10 PM, Rob Crittenden wrote: Rob Crittenden wrote: Simo Sorce wrote: On Mon, 2012-02-27 at 09:44 -0500, Rob Crittenden wrote: We are pretty trusting that the data coming out of LDAP matches its schema but it is possible to stuff non-printable characters

Re: [Freeipa-devel] [PATCH 63] Implement session activity timeout

2012-02-27 Thread Rob Crittenden
John Dennis wrote: Previously sessions expired after session_auth_duration had elapsed commencing from the start of the session. We new support a rolling expiration where the expiration is advanced by session_auth_duration everytime the session is accessed, this is equivalent to a inactivity

Re: [Freeipa-devel] [PATCH 62] Tweak the session auth to reflect developer consensus.

2012-02-27 Thread Rob Crittenden
John Dennis wrote: rebased patch against current ipa-2-2 branch ACK, pushed to master and ipa-2-2 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: On 02/27/2012 05:53 PM, Rob Crittenden wrote: John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob