Re: [Freeipa-devel] [PATCH 431] Configure 389ds with default cipher suite

On Tue, Mar 08, 2016 at 11:43:49AM +0100, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5684 > > patch attached I think the comment in install/updates/20-sslciphers.update should be updated. Apart from that, ACK. Cheers, Fraser -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH 0139] otptoken-add: improve the robustness of QR code printing to tty

On 8.3.2016 17:45, Martin Babinsky wrote: On 03/08/2016 05:35 PM, Jan Cholasta wrote: Hi, On 8.3.2016 16:21, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5700 1) Instead of checking for utf-8 in particular, I would prefer a more robust approach: try: qr =

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's a patch for webUI tests that provides test for creating user without private group. Related to ticket

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: > * old messages have been removed * > 1) > this method is unused please remove it > > def test_kra_install_master(self): >> Well, in fact it is used twice: in both domain levels,

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code, it would be good to create auxiliary function and

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

On 03/07/2016 04:29 PM, Pavel Vomacka wrote: On 02/25/2016 03:08 PM, Lenka Doudova wrote: Hi, here's a patch for webUI tests that provides test for creating user without private group. Related to ticket https://fedorahosted.org/freeipa/ticket/4986 Since the option to specify GID when

[Freeipa-devel] [PATCH 0432] stageuser-activate: noralize manager value

https://fedorahosted.org/freeipa/ticket/5481 Patch attached. From 4ba6a6daf58d751fbb95e23f785e6b4861e21079 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 7 Mar 2016 12:15:58 +0100 Subject: [PATCH] stageuser-activate: Normalize manager value Manager(s) were returned

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 02/22/2016 11:09 AM, Filip Skola wrote: - Original Message - On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016 11:11 AM, Filip Skola wrote: - Original

Re: [Freeipa-devel] [PATCH 0005] Refactor test_nesting, create HostGroupTracker

On 01/28/2016 10:45 AM, Filip Skola wrote: The same as with patch 0002: * Module ipatests.test_xmlrpc.tracker.hostgroup_plugin W:142,26: Calling a dict.iter*() method (dict-iter-method) Please use dict.items method. -- Milan Kubik Hi, attaching a fixed patch. This patch is

Re: [Freeipa-devel] [TESTS][PATCH 0010] WebUI tests - ID views

On 03/08/2016 12:43 PM, Pavel Vomacka wrote: On 02/23/2016 03:20 PM, Lenka Doudova wrote: Hi, attached is patch providing missing test coverage for ID views in webUI. Lenka Hi, Thank you for your patch. I have small one comment: The delete_associtaion() function duplicates code, it

Re: [Freeipa-devel] [PATCH 0002] Refactor test_group_plugin

On 08.03.2016 10:52, Milan Kubík wrote: On 02/22/2016 11:09 AM, Filip Skola wrote: - Original Message - On 02/10/2016 09:17 AM, Milan Kubík wrote: On 02/09/2016 04:19 PM, Milan Kubík wrote: On 01/28/2016 10:42 AM, Filip Skola wrote: - Original Message - On 01/25/2016

[Freeipa-devel] [PATCH 0432] use platform path for SSSD log directory

/var/log/SSSD is platform specific, thus should be added to ipaplatform module Patch attached. From 5873f755428903b9300f260221b5417a3697f279 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 8 Mar 2016 16:26:23 +0100 Subject: [PATCH] Use platform path constant for SSSD

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On 03/08/2016 04:49 PM, Simo Sorce wrote: On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky wrote: On 12/01/2015 10:08 PM, Simo Sorce wrote: On Tue, 2015-12-01 at 15:59 +0100, Martin Babinsky wrote: On 11/30/2015 07:42 PM, Simo Sorce wrote: On Wed, 2015-11-25 at 10:33 +0100, Martin Babinsky

[Freeipa-devel] [PATCH 0139] otptoken-add: improve the robustness of QR code printing to tty

https://fedorahosted.org/freeipa/ticket/5700 -- Martin^3 Babinsky From 24dfd3148d2a9a8118b9d87d61c179578668666d Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 8 Mar 2016 15:56:52 +0100 Subject: [PATCH] otptoken-add: improve the robustness of QR code printing to

[Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

https://fedorahosted.org/freeipa/ticket/4501 Patch attached. From ca3a3bd01e6990a42e2d7c809b1f698da53b04a4 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 4 Mar 2016 16:57:20 +0100 Subject: [PATCH] logging: add timestamps to log filenames Originally installation logs

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky wrote: > On 12/01/2015 10:08 PM, Simo Sorce wrote: > > On Tue, 2015-12-01 at 15:59 +0100, Martin Babinsky wrote: > >> On 11/30/2015 07:42 PM, Simo Sorce wrote: > >>> On Wed, 2015-11-25 at 10:33 +0100, Martin Babinsky wrote: > On 11/24/2015

Re: [Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

On 08.03.2016 16:31, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4501 Patch attached. Rebased patch attached. From 6539b6e438a391c24ed5b4f920ff825973537b0f Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 4 Mar 2016 16:57:20 +0100 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: > On 03/08/2016 04:49 PM, Simo Sorce wrote: > > On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky wrote: > >> On 12/01/2015 10:08 PM, Simo Sorce wrote: > >>> On Tue, 2015-12-01 at 15:59 +0100, Martin Babinsky wrote: > On 11/30/2015

[Freeipa-devel] [PATCH 0140] test_cert_plugin: use only first part of the hostname to construct short name

https://fedorahosted.org/freeipa/ticket/5688 -- Martin^3 Babinsky From bd93563703f9638cb720041eb6b6b1740bf7cd25 Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Tue, 8 Mar 2016 16:56:38 +0100 Subject: [PATCH] test_cert_plugin: use only first part of the hostname to

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On 03/08/2016 05:00 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: On 03/08/2016 04:49 PM, Simo Sorce wrote: On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky wrote: On 12/01/2015 10:08 PM, Simo Sorce wrote: On Tue, 2015-12-01 at 15:59 +0100, Martin Babinsky

Re: [Freeipa-devel] [PATCH 0139] otptoken-add: improve the robustness of QR code printing to tty

Hi, On 8.3.2016 16:21, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5700 1) Instead of checking for utf-8 in particular, I would prefer a more robust approach: try: qr = qrcode.QRCode() qr.add_data('test') qr.make() qr.print_ascii(tty=True) except

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On Tue, 2016-03-08 at 17:20 +0100, Martin Babinsky wrote: > On 03/08/2016 05:00 PM, Simo Sorce wrote: > > On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: > >> On 03/08/2016 04:49 PM, Simo Sorce wrote: > >>> On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky wrote: > On 12/01/2015

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On 03/08/2016 05:50 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 17:20 +0100, Martin Babinsky wrote: On 03/08/2016 05:00 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: On 03/08/2016 04:49 PM, Simo Sorce wrote: On Fri, 2015-12-04 at 14:23 +0100, Martin Babinsky

Re: [Freeipa-devel] [PATCH 0139] otptoken-add: improve the robustness of QR code printing to tty

On 03/08/2016 05:35 PM, Jan Cholasta wrote: Hi, On 8.3.2016 16:21, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5700 1) Instead of checking for utf-8 in particular, I would prefer a more robust approach: try: qr = qrcode.QRCode() qr.add_data('test')

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def test_kra_install_master(self): Well, in fact it is used twice: in

Re: [Freeipa-devel] [PATCH 558] Allow disabling requireing preauth by default for Service Principal Names

On 08.03.2016 18:02, Martin Babinsky wrote: On 03/08/2016 05:50 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 17:20 +0100, Martin Babinsky wrote: On 03/08/2016 05:00 PM, Simo Sorce wrote: On Tue, 2016-03-08 at 16:51 +0100, Martin Babinsky wrote: On 03/08/2016 04:49 PM, Simo Sorce wrote: On

Re: [Freeipa-devel] [PATCH 0434] log: add timestamp to filename of logs

On 08.03.2016 16:37, Martin Basti wrote: On 08.03.2016 16:31, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4501 Patch attached. Rebased patch attached. self-NACK Scripts print to CLI unformatted strings, it should not be so easy. See

Re: [Freeipa-devel] [PATCH] CONFIGURE: Replace obsolete macros

On 02.02.2016 09:36, Lukas Slebodnik wrote: ehlo, The AC_PROG_LIBTOOL macro is obsoleted by since libtool-2.0 which is already in rhel6+ https://fedorahosted.org/FedoraReview/wiki/AutoTools simple patch is attached LS ACK Pushed to master: ebbb2eba5bdf3eee9eca3e3db2b8964db5d8131f

Re: [Freeipa-devel] [PATCH 0140] test_cert_plugin: use only first part of the hostname to construct short name

On 08.03.2016 17:08, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5688 Pushed to: master: abe3abb46699428038cd77f13b814de69fd7d0a2 ipa-4-3: bbad720138575f7655154dd3ed52c590970d9961 -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [PATCH 0436] krb5.conf: use 'true' instead of 'yes'

https://fedorahosted.org/freeipa/ticket/5518 Patch attached. From d8bdb84de46923182b9d5b67e8ee6eba80aab396 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Tue, 8 Mar 2016 18:29:47 +0100 Subject: [PATCH] krb5conf: use 'true' instead of 'yes' for forwardable option 'yes' is

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def

Re: [Freeipa-devel] [PATCH 0140] test_cert_plugin: use only first part of the hostname to construct short name

On 08.03.2016 20:24, Martin Basti wrote: On 08.03.2016 17:08, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5688 Pushed to: master: abe3abb46699428038cd77f13b814de69fd7d0a2 ipa-4-3: bbad720138575f7655154dd3ed52c590970d9961 ACK :-) -- Manage your subscription for