Akasurde commented on a pull request
"""
@stlaz Thanks
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247312920
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
flo-renaud's pull request #50: "Add cert checks in ipa-server-certinstall" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/50
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/50/head:pr50
jcholast's pull request #88: "test_plugable: update the rest of test_init" was
opened
PR body:
"""
In commit ed4c2d9252a995d01dc098e5b761ded8cd9373d8, changes to the Plugin
class were made, but the test was updated only partially.
Update the rest to fix the failing test.
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was
opened
PR body:
"""
If ipa-client-install is executed with --no-sssd, check if pam_krb5 is
available before proceeding with the install.
https://fedorahosted.org/freeipa/ticket/5557
"""
See the full pull-request at
mbasti-rh commented on a pull request
"""
Please split this into 2 commits, it contains independent issues
* wrong path to IPA join
* extra attribute
It is not related to this PR, but for me it looks that this test is focused to
ipa-join command and I don't see how this is related to API tests.
Akasurde commented on a pull request
"""
@pspacek Should I close this PR then?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/25#issuecomment-247315968
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
jcholast's pull request #89: "client: remove hard dependency on pam_krb5" was
synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/89
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/89/head:pr89
mbasti-rh commented on a pull request
"""
I was thinking hard about it, if there should be SSSD restart, but I cannot
find any case where it is needed after server uninstall
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecomment-247322795
--
Manage your
ofayans commented on a pull request
"""
Probably Lenka has some use-case for this. I am pretty sure these lines weren't
added just for fun :)
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecomment-247328115
--
Manage your subscription for the Freeipa-devel mailing
rcritten commented on a pull request
"""
For the record this test used to pass. Don't blame the test when the code it is
testing was changed.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/84#issuecomment-247329152
--
Manage your subscription for the Freeipa-devel mailing
abbra commented on a pull request
"""
Update plugins are higher level of abstraction. They use
ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and
.update_from_dict() methods. Update plugins can produce dictionaries. With the
change in this pull request they will have to
ofayans's pull request #86: "Made sssd restart a non-raising opration" was
opened
PR body:
"""
Uninstallation of ipa-server usually removes sssd configuration file,
/etc/sssd/sssd.conf
If we then issue syustemctl restart sssd.service, the command fails because is
unable to find the config file.
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" label
*pushed* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
mbasti-rh commented on a pull request
"""
Sorry guys, but ticket is in closed milestone you need a new one.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247348762
--
Manage your subscription for the Freeipa-devel mailing list:
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been removed
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
ofayans commented on a pull request
"""
sure
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecomment-247344841
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
mbasti-rh commented on a pull request
"""
Can wait until Lenka give us the reason?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/86#issuecomment-247344542
--
Manage your subscription for the Freeipa-devel mailing list:
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" was closed
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/72/head:pr72
git checkout
mbasti-rh commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/b18a35145df92522ae990e020513d1a77e311493
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/72#issuecomment-247349710
--
Manage your subscription for the Freeipa-devel
Akasurde commented on a pull request
"""
@mbasti-rh I re-opened the ticket, Could you please provide ack ?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247519895
--
Manage your subscription for the Freeipa-devel mailing list:
Hi Martin,
The file was renamed. Did I understand correctly that for now we are
leaving the test as is and are planning to extend it later?
On 09/15/2016 09:49 AM, Martin Basti wrote:
On 14.09.2016 18:53, Sumit Bose wrote:
On Wed, Sep 14, 2016 at 06:03:37PM +0200, Martin Basti wrote:
On
On 14.09.2016 18:53, Sumit Bose wrote:
On Wed, Sep 14, 2016 at 06:03:37PM +0200, Martin Basti wrote:
On 14.09.2016 17:53, Alexander Bokovoy wrote:
On Wed, 14 Sep 2016, Martin Basti wrote:
On 14.09.2016 17:41, Alexander Bokovoy wrote:
On Wed, 14 Sep 2016, Martin Basti wrote:
1)
I still
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronized
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
On 09/15/2016 02:12 AM, jcholast wrote:
jcholast commented on a pull request
"""
In addition to my inline comments above:
1. "Certificate mapping" does not really evoke "certificate request templating"
to me, and is also used in the context of mapping identities to certificates. Could we use
stlaz's pull request #84: "Removed update_from_dict function from ldapupdate"
was opened
PR body:
"""
update_from_dict was basically dead code as it's used nowhere in
the project.
https://fedorahosted.org/freeipa/ticket/6311
"""
See the full pull-request at
pvomacka's pull request #85: "WebUI: Change group name from 'normal' to
'Non-POSIX'" was opened
PR body:
"""
It will correspond with CLI and will be more self-explanatory.
https://fedorahosted.org/freeipa/ticket/6334
"""
See the full pull-request at https://github.com/freeipa/freeipa/pull/85
stlaz's pull request #84: "Removed update_from_dict function from ldapupdate"
was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/84
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
jcholast commented on a pull request
"""
Functional ACK, but please don't use newlines in exception messages. If you
want the original error on a separate line, you can use the logger to log it,
but I think it would be preferable to use this format:
```
Peer's certificate issuer is not trusted
stlaz commented on a pull request
"""
Well, I did fix the test, then. I can imagine the function being pretty handy
as a library function although it'd better be used in the future.
What infuriates me is the fact that the test might have never worked (well, at
least year and a half, but my
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa
pvomacka's pull request #72: "WebUI: Add handling for HTTP error 404" label
*ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/72
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
jcholast's pull request #87: "dns: re-introduce --raw in dnsrecord-del" was
opened
PR body:
"""
The flag was removed in commit ff52c25ae299abba8bed653fe324951979a41293
because it is unused. Add it back for compatibility with old clients.
https://fedorahosted.org/freeipa/ticket/5644
"""
See the
mbasti-rh commented on a pull request
"""
Shouldn't external plugins use update files or update plugins as IPA does?
We don't have any guaranteed internal API for anything, we don't have any
document about external plugins, we don't have prepared any API for 3rd party
plugins. We just have
Akasurde's pull request #83: "Added a fix for setting Priority as required
field " label *ack* has been added
See the full pull-request at https://github.com/freeipa/freeipa/pull/83
--
Manage your subscription for the Freeipa-devel mailing list:
stlaz commented on a pull request
"""
Looks OK to me, thanks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/83#issuecomment-247310347
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to
35 matches
Mail list logo
