Re: [Freeipa-devel] [PATCH] 4 (1) ipa-client-install complains about non-existing nss_ldap

2011-07-06 Thread Rob Crittenden
Simo Sorce wrote: On Fri, 2011-07-01 at 14:18 +0200, Jan Cholasta wrote: On 1.7.2011 14:00, Alexander Bokovoy wrote: Hi, On 01.07.2011 14:54, Jan Cholasta wrote: On 1.7.2011 11:44, Alexander Bokovoy wrote: New version: forgot to import package_installed_name from ipautil. Previous version

Re: [Freeipa-devel] [PATCH] 3 ipa-client-install tries to start non-existing nscd

2011-07-06 Thread Rob Crittenden
Alexander Bokovoy wrote: Should we instead look to see if /usr/sbin/nscd exists before calling chkconfig? rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 4 (1) ipa-client-install complains about non-existing nss_ldap

2011-07-06 Thread Alexander Bokovoy
On 06.07.2011 17:26, Rob Crittenden wrote: I'm not sure adding even more complexity is helpful, especially when it's used just to print a warning message. But I'd like a second opinion on this. I think it is time we start renaming ipautil.py to ipautil-rh.py and do ourselves, or invite someone

Re: [Freeipa-devel] [PATCH] 3 ipa-client-install tries to start non-existing nscd

2011-07-06 Thread Alexander Bokovoy
On 06.07.2011 17:27, Rob Crittenden wrote: Alexander Bokovoy wrote: Should we instead look to see if /usr/sbin/nscd exists before calling chkconfig? When you call chkconfig for non-existing service, it is correctly reporting that it does not exist and sets return code appropriately. I

[Freeipa-devel] [PATCH] 820 make client errors clearer

2011-07-06 Thread Rob Crittenden
Some client errors were rather generic or outright misleading. This cleans up some return values and displays output from the ipa-enrollment extended operation. ticket https://fedorahosted.org/freeipa/ticket/1417 From 89cda040e7ae1f6b1aa97d2df8af25467c7ba410 Mon Sep 17 00:00:00 2001 From: Rob

[Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
From 5eab28192c0186d688712d463b6e14a19d167e23 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Tue, 5 Jul 2011 17:59:05 -0400 Subject: [PATCH] HBAC deny warning shows dialog if there are any HBAC deny rules. Dialog provides option to navigate to the HBAC page. Deny rules have

[Freeipa-devel] [PATCH] 199 Fixed HBAC/Sudo rules associations.

2011-07-06 Thread Endi Sukma Dewata
The HBAC/Sudo rules associations in users, groups, hosts and host groups have been fixed to use the correct associator and method names. Ticket #1438 -- Endi S. Dewata From 8a66e77d5d16a8150aa147e87813758ffe6e99f8 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Wed, 6 Jul

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
On 07/06/2011 11:13 AM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static

Re: [Freeipa-devel] [PATCH] 199 Fixed HBAC/Sudo rules associations.

2011-07-06 Thread Adam Young
On 07/06/2011 11:32 AM, Endi Sukma Dewata wrote: The HBAC/Sudo rules associations in users, groups, hosts and host groups have been fixed to use the correct associator and method names. Ticket #1438 ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
On 07/06/2011 11:40 AM, Adam Young wrote: On 07/06/2011 11:13 AM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Rebased. Also, updated the hbacrule_find.json sample

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view Some issues: 1. The red 'deny' text doesn't line up with the colum header or 'allow' text. The padding-left in .hbac-deny-rule class should be removed.

[Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
From cd7badadc666745ea4283f96f463140a626984b9 Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date: Wed, 6 Jul 2011 15:43:50 -0400 Subject: [PATCH] check required on blur previsouly was checked on key down, but that does the check too soon.

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view Some issues: 1. The red 'deny' text doesn't line up with the colum header or 'allow' text. The

Re: [Freeipa-devel] [PATCH] 045 Add DNS record modification command

2011-07-06 Thread Adam Young
On 07/05/2011 04:21 PM, Adam Young wrote: On 03/30/2011 11:13 AM, Martin Kosek wrote: Since this is a new-feature type patch it should be pushed only to master. --- The DNS record plugin does not support modification of a record. One can only add A type addresses to a DNS record or remove

[Freeipa-devel] [PATCH] 821 reset failed count when password is reset by admin

2011-07-06 Thread Rob Crittenden
Reset the login failed count to 0 when an admin (e.g. not the user) resets the password. Otherwise a newly reset password could fail too. ticket https://fedorahosted.org/freeipa/ticket/1441 rob From 846ac49a4fffb53a1f8a544b0c695ae75e3cf98a Mon Sep 17 00:00:00 2001 From: Rob Crittenden

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
On 07/06/2011 03:54 PM, Adam Young wrote: On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view Some issues: 1. The red 'deny' text doesn't line up with the

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
On 07/06/2011 03:44 PM, Adam Young wrote: ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel From d6148920eb1b079e935162e930c81fb66c6cdaa6 Mon Sep 17 00:00:00 2001 From: Adam Young

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Adam Young
On 07/06/2011 04:51 PM, Adam Young wrote: On 07/06/2011 03:54 PM, Adam Young wrote: On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view Some issues: 1.

[Freeipa-devel] [PATCH] 822 remove deny hbac rule type

2011-07-06 Thread Rob Crittenden
Remove deny from the available type options and prevent new ones from being created (either directly or via a mod). Type now defaults to allow and will autofill so on the cli the user won't be prompted for it in interactive mode. deny is still a valid type for searching, so hbacrule-find

Re: [Freeipa-devel] [PATCH] 0264-HBAC-deny-warning.

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 4:44 PM, Adam Young wrote: On 07/06/2011 04:51 PM, Adam Young wrote: On 07/06/2011 03:54 PM, Adam Young wrote: On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: On 7/6/2011 10:40 AM, Adam Young wrote: Rebased. Also, updated the hbacrule_find.json sample data to show to the deny

[Freeipa-devel] [PATCH] 200 Fixed blank self-service page.

2011-07-06 Thread Endi Sukma Dewata
The self-service navigation has been fixed to include the root of the navigation path. Ticket #1445 -- Endi S. Dewata From c3d8864cc64362f10b166ffc3ba3b184f97087e9 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata edew...@redhat.com Date: Wed, 6 Jul 2011 17:39:49 -0400 Subject: [PATCH] Fixed blank

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Endi Sukma Dewata
On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. To test, open user's adder dialog, don't enter anything, just click Add. The server will return an error (i.e. check_required() not called). Another

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-06 Thread Adam Young
On 07/06/2011 08:55 PM, Adam Young wrote: On 07/06/2011 08:12 PM, Endi Sukma Dewata wrote: On 7/6/2011 4:32 PM, Adam Young wrote: Some issues: 1. The check_required() is only called in blur events. It's not called on Add/Update. Fixed. Looks like this works even for checkboxes. To