Re: [Freeipa-devel] [PATCH] 812 Use RunAs in labels, not Run As

2011-07-12 Thread Martin Kosek
On Wed, 2011-06-29 at 15:12 -0400, Rob Crittenden wrote: For consistency we should use RunAs in sudo labels and not Run As. The API changes don't affect the wire API, label is in there to make one think twice about making changes :-) https://fedorahosted.org/freeipa/ticket/1328 ACK.

Re: [Freeipa-devel] [PATCHES] 814, 815, 816 Fix test failures

2011-07-12 Thread Martin Kosek
On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote: I found a few test failures that have resulted from some recent commits. These got lost in the mix of expected failures when I did initial testing on them. This has inspired me to try to fix all the test failures (see patch 817 too).

Re: [Freeipa-devel] [PATCHES] 814, 815, 816 Fix test failures

2011-07-12 Thread Alexander Bokovoy
On 12.07.2011 14:51, Martin Kosek wrote: On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote: I found a few test failures that have resulted from some recent commits. These got lost in the mix of expected failures when I did initial testing on them. This has inspired me to try to fix all

Re: [Freeipa-devel] [PATCH] 813 fix enrolledBy regression

2011-07-12 Thread Martin Kosek
On Fri, 2011-07-01 at 11:41 -0400, Rob Crittenden wrote: enrolledBy represents the DN of the entry that enrolled a host. We don't want an admin to manipulate this but an aci allowed it. This was a regression. ticket 302 rob Works fine with new IPA installation. Still, I have some

Re: [Freeipa-devel] [PATCH] 818 find_entry_by_attr() should fail if multiple entries are found

2011-07-12 Thread Martin Kosek
On Tue, 2011-07-05 at 13:42 -0400, Rob Crittenden wrote: It will only ever return one entry so if more than one are found then we raise an exception. This is most easily seen in the host plugin where we search on the server shortname which can be the same across sub-domains (e.g.

Re: [Freeipa-devel] [PATCH] 808 don't allow leading/trailing whitespace in strings

2011-07-12 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2011-07-11 at 17:45 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2011-06-24 at 16:37 -0400, Rob Crittenden wrote: Rob Crittenden wrote: Rob Crittenden wrote: This started as a problem in allowing leading/trailing whitespaces on primary keys. In nearly

Re: [Freeipa-devel] [PATCH] 818 find_entry_by_attr() should fail if multiple entries are found

2011-07-12 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-07-05 at 13:42 -0400, Rob Crittenden wrote: It will only ever return one entry so if more than one are found then we raise an exception. This is most easily seen in the host plugin where we search on the server shortname which can be the same across sub-domains

[Freeipa-devel] [PATCH] 28 Fix creation of reverse DNS zones

2011-07-12 Thread Jan Cholasta
This patch fixes reverse DNS zone creation so that a /24 IPv4 and /64 IPv6 reverse zones are created by default. The reverse zone can be customized using new --reverse-zone option in ipa-server-install, ipa-replica-prepare, ipa-replica-install and ipa-dns-install, which replaces the old way of

Re: [Freeipa-devel] [PATCHES] 814, 815, 816 Fix test failures

2011-07-12 Thread Rob Crittenden
Alexander Bokovoy wrote: On 12.07.2011 14:51, Martin Kosek wrote: On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote: I found a few test failures that have resulted from some recent commits. These got lost in the mix of expected failures when I did initial testing on them. This has

Re: [Freeipa-devel] [PATCHES] 814, 815, 816 Fix test failures

2011-07-12 Thread Martin Kosek
On Tue, 2011-07-12 at 09:52 -0400, Rob Crittenden wrote: Alexander Bokovoy wrote: On 12.07.2011 14:51, Martin Kosek wrote: On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote: I found a few test failures that have resulted from some recent commits. These got lost in the mix of

Re: [Freeipa-devel] [PATCHES] 814, 815, 816 Fix test failures

2011-07-12 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2011-07-12 at 09:52 -0400, Rob Crittenden wrote: Alexander Bokovoy wrote: On 12.07.2011 14:51, Martin Kosek wrote: On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote: I found a few test failures that have resulted from some recent commits. These got lost in

[Freeipa-devel] [PATCH] entity_select naming

2011-07-12 Thread Adam Young
pushed under the one line rule. commit e0238b5218d1c46bec3b0231db3bbef71a7403ef Author: Adam Young ayo...@redhat.com Date: Mon Jul 11 16:17:29 2011 -0400 entity_select naming http://fedorahosted.org/freeipa/ticket/1467 diff --git a/install/ui/widget.js b/install/ui/widget.js index

Re: [Freeipa-devel] [PATCH] 205 Fixed collapsed table in Chrome.

2011-07-12 Thread Endi Sukma Dewata
On 7/11/2011 8:15 PM, Endi Sukma Dewata wrote: The .content-table class has been modified to expand properly in Firefox and Chrome. Ticket #1450 ACKed and pushed by ayoung. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 089 Add DNS record modification command

2011-07-12 Thread Martin Kosek
Due to DNS plugin architecture --setattr and --addattr options are not available. DNS plugin does things in its own way and is based on LDAPQuery base class which cannot use --setattr and --addattr options. Hopefully the WebUI will be able to deal with it. --- The DNS record plugin does not

Re: [Freeipa-devel] [PATCH] 813 fix enrolledBy regression

2011-07-12 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2011-07-01 at 11:41 -0400, Rob Crittenden wrote: enrolledBy represents the DN of the entry that enrolled a host. We don't want an admin to manipulate this but an aci allowed it. This was a regression. ticket 302 rob Works fine with new IPA installation. Still, I

[Freeipa-devel] [PATCH] 206 Fixed object_name and object_name_plural, internationalization

2011-07-12 Thread Endi Sukma Dewata
The object_name, object_name_plural and messages that use these attributes have been converted to support translation. The label attribute in the Param class has been modified to accept unicode string. Ticket #1435 -- Endi S. Dewata From 0fb19d888e845dca25df219b374730e010499586 Mon Sep 17

Re: [Freeipa-devel] [PATCH] 089 Add DNS record modification command

2011-07-12 Thread Adam Young
On 07/12/2011 12:21 PM, Martin Kosek wrote: Due to DNS plugin architecture --setattr and --addattr options are not available. DNS plugin does things in its own way and is based on LDAPQuery base class which cannot use --setattr and --addattr options. Hopefully the WebUI will be able to deal

Re: [Freeipa-devel] [PATCH] 206 Fixed object_name and object_name_plural, internationalization

2011-07-12 Thread Adam Young
On 07/12/2011 03:42 PM, Endi Sukma Dewata wrote: The object_name, object_name_plural and messages that use these attributes have been converted to support translation. The label attribute in the Param class has been modified to accept unicode string. Ticket #1435

Re: [Freeipa-devel] [PATCH] 089 Add DNS record modification command

2011-07-12 Thread Adam Young
On 07/12/2011 03:59 PM, Adam Young wrote: On 07/12/2011 12:21 PM, Martin Kosek wrote: Due to DNS plugin architecture --setattr and --addattr options are not available. DNS plugin does things in its own way and is based on LDAPQuery base class which cannot use --setattr and --addattr options.